From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
Subject: Re: Assertion violation in pdumper.c
Date: Mon, 17 Aug 2020 16:28:21 +0000 [thread overview]
Message-ID: <CAOqdjBfasKFXcjSaJKjQPA9p_bvAk-7YKu6YTA81XkVTyzhjUQ@mail.gmail.com> (raw)
In-Reply-To: <83r1s5gybp.fsf@gnu.org>
On Mon, Aug 17, 2020 at 2:08 PM Eli Zaretskii <eliz@gnu.org> wrote:
> Since the recent changes in pdumper.c, Emacs started hitting an
> assertion violation and aborting during the build on one of my
> systems, see the backtrace below. I need the following to work around
> the abort:
>
> diff --git a/src/pdumper.c b/src/pdumper.c
> index 2d1b19283c..217ffa6783 100644
> --- a/src/pdumper.c
> +++ b/src/pdumper.c
> @@ -4999,7 +4999,7 @@ pdumper_find_object_type_impl (const void *obj)
> if (offset % DUMP_ALIGNMENT != 0)
> return PDUMPER_NO_OBJECT;
> ptrdiff_t bitno = offset / DUMP_ALIGNMENT;
> - if (offset < dump_private.header.cold_start
> + if (offset < dump_private.header.discardable_start
> && !dump_bitset_bit_set_p (&dump_private.last_mark_bits, bitno))
> return PDUMPER_NO_OBJECT;
> const struct dump_reloc *reloc =
That looks like the correct fix to me. I'd mistakenly thought cold
objects preceded discardable ones.
> My hypothesis is that we are trying to call dump_bitset_bit_set_p on a
> pointer that shouldn't be tested like that, because the number of
> words we reserve for a bitset is only enough for objects stored before
> discardable_start.
I agree.
next prev parent reply other threads:[~2020-08-17 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 14:07 Assertion violation in pdumper.c Eli Zaretskii
2020-08-17 16:28 ` Pip Cet [this message]
2020-08-17 16:32 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBfasKFXcjSaJKjQPA9p_bvAk-7YKu6YTA81XkVTyzhjUQ@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).