From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: =?UTF-8?Q?Re=3A_31395511=3A_=22Don=E2=80=99t_attempt_to_modify_constant_st?= =?UTF-8?Q?rings=22?= Date: Thu, 4 Jun 2020 04:38:19 +0000 Message-ID: References: <871rmvn7ge.fsf@gmail.com> <87lfl36abx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="23016"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Paul Eggert , emacs-devel To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 04 06:39:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jghfE-0005oy-6f for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 06:39:36 +0200 Original-Received: from localhost ([::1]:33220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jghfD-0002hB-7w for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 00:39:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jghec-0002Gm-Nw for emacs-devel@gnu.org; Thu, 04 Jun 2020 00:38:58 -0400 Original-Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]:34414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgheb-0000SA-CD for emacs-devel@gnu.org; Thu, 04 Jun 2020 00:38:58 -0400 Original-Received: by mail-oi1-x22b.google.com with SMTP id b8so3981587oic.1 for ; Wed, 03 Jun 2020 21:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xOJj7NNkJwwrzWVoTVqRQ2XcjD8IHfDrw8ecEpLH06U=; b=FlZyVYchvWVZYW1zzq4PAw82kDPkInf/s6fXxbwtZwewedkbUW0xLR+g6iX8AZ/m3j lt5AMfFlJk1a2LeVoqtYd8V1PgX9fp4M+lwCWYgEfUPmKW+mEg9qkPTUxIIWpLYYZzVz LNP6HtybumtSkUYbg7MlVPocx/RcZTczwNeWj5nw2njR4zAUjlcMzYdhdz1htu8BYKQp Na+UA1sd/BY58uzhNCcYe0FpZljMRYpw80MOkrs+TJch+nu5vNTpm3F8df7S1Txwe22T zb+yD8qJfg1Ok/WhuVdxMrEgRzo9YHODzfIG0vNDMLVIinygDWrDhYjFhJYHQ46QiNMD opzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xOJj7NNkJwwrzWVoTVqRQ2XcjD8IHfDrw8ecEpLH06U=; b=LrBojXwC4qf4DVqvl9qSe4k8Q40ZOyVvvmTRKg2IjZd3hMWP8d5t8ZqhW6CpFAyuNa zp+/g3qznGqiR8I+VGUwmF/K5Pu2877zJJkeyTV34ULuAq1S+nVpUEP+8Yfmu681MTOt jFinoZcfZgIMIsEyDClqd1vlqukRN0UwJmhUVC3kQ7TflOf7IgSI56LqPAUX8i4ijFWg yKdPjCcPu+x7oJVzth3VgLZ60Pj9vmNSjT3MSUGKX0mUnK5uBE9NuV0NHxf9lZBX3O4i GRa/QwwbOQaG4QbTm7P7+tmUI7pV8uy0UfryG5xvZviRGa4iFrwdcbtbMGlul1ZfuUMx BuMQ== X-Gm-Message-State: AOAM533Wwg0TEHad1QyjCLWHtSqA9YniR/xC5WTwMl1neFUPLhtWfb/I nGeaju0rLI2YHA38+YTqAgXbPN1kF34QlZqtvoA= X-Google-Smtp-Source: ABdhPJyG8XCxXjVbVYaDBDHFFz05XJOqd3fj29xNXPlngHCtPIghYpdC74e/72jkAZjW7gYx2ZQt82etdlgmxzUt/5s= X-Received: by 2002:aca:b708:: with SMTP id h8mr1922658oif.122.1591245535890; Wed, 03 Jun 2020 21:38:55 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::22b; envelope-from=pipcet@gmail.com; helo=mail-oi1-x22b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251844 Archived-At: On Wed, Jun 3, 2020 at 11:48 PM Jo=C3=A3o T=C3=A1vora wrote: > On Wed, Jun 3, 2020 at 11:42 PM Pip Cet wrote: >> I think you want >> (defun sly-make-action-button (label action &rest props) >> (apply #'sly--make-text-button >> label nil :type 'sly-action >> 'action action >> 'mouse-action action >> props)) >> >> instead, since the new function returns a copy of label rather than the >> string passed in. > By itself, that doesn't work. I have the same problem. Strange, I'd tried it locally and it appeared to work. > I think I'd rather this previous behavior were retained, or at least > achievable by request. I haven't touched this code in a long > I don't know what else might depend on it. But the previous behavior was buggy. Things like (defun sly-inspector-insert-more-button (index previous) (insert (sly-make-action-button (if previous " [--more--]\n" " [--more--]") #'sly-inspector-fetch-more 'range-args (list index previous)))) worked only by accident, before.