From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s Date: Sun, 7 Mar 2021 17:23:04 +0000 Message-ID: References: <20210305170955.27732.27579@vcs0.savannah.gnu.org> <20210305170957.AF99920E1B@vcs0.savannah.gnu.org> <83sg58wu0v.fsf@gnu.org> <83k0qkwnwt.fsf@gnu.org> <838s70wdb5.fsf@gnu.org> <83a6rft5z9.fsf@gnu.org> <837dmjt2e2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1043"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 07 18:24:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIx8Y-00009j-Nm for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 18:24:14 +0100 Original-Received: from localhost ([::1]:43996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIx8X-0001g2-Qh for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 12:24:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIx83-0001Fn-3L for emacs-devel@gnu.org; Sun, 07 Mar 2021 12:23:43 -0500 Original-Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]:35245) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIx81-0003xN-Hn; Sun, 07 Mar 2021 12:23:42 -0500 Original-Received: by mail-ot1-x32e.google.com with SMTP id j22so1110968otp.2; Sun, 07 Mar 2021 09:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p5DxgQnMK9MxYW8CT2isSXvIucIzF1humKqVSrRrkfw=; b=UZ3TDHBHdBVc9F/ygyxwlS71mdv/kVhr4uarDByeEv9BxTxc1EYgnjFvZ8LDv+s8B9 ky/3zETSnHSPy8ItsWfPkU2czVXwyrTA1J0fm9fI51NWBIry8cVK+yeklE8UDtUR8cGw GL4E6OJvmNBRXlPl1pI0Me/TreXEr/JunrTN223N1izUcuCgPiiCSs6DtYOLACb44/7g nJ5xG2edV/xRoChHNecqX5QppSdtxAZo9GBhrHse/VVroBd2f3xBxjUByDV/RJ5SCa5J QVJaRbY/v3KWnfmZZ5qtouOFDC9rWbV/YeDVo0J7jlALHxiFX5CqvTVNQxs8HnhUBEtd fe2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p5DxgQnMK9MxYW8CT2isSXvIucIzF1humKqVSrRrkfw=; b=mKVVTQzu7L/NLSNaMDQOPFtx1zfHAn5aPCO1a1UjNDARlfz+1Q2XJ1BwDYyOg3Xbiv NPHqXd5xGTYUpxPYz5jmyQUndt1zxy9ENZ7d7Ua6BdZptSEz6rBCX9vdG3unHNKSOyP7 Ce1T65nGrYZGuXQDNOecNWMdcqRhLT9YeJHazbk6IvDDEikNYLc+00sVbEmGUjFaWbbG Bd8wVlHVWDRXVXSuWU/2A/UNnh5pvPt7QJXkJ8MD6qhMsCwfxKxZU0+jes7MO2oTOesi UkiOPvCUCR5UtfD0hmXeJDtZDckcJYK4dE3I4Q3tE3lUYEBFYURXXlksnZypM4BvhKeg NHrw== X-Gm-Message-State: AOAM531wCjySWWMbS3FQHbi2IW9BNUhKNFKAteOxdeDzUv1VV4X0UpPR daEAcbmSQG++YtbhqrSHgEd5x1R4tpZD9HveoN3vysdcF74= X-Google-Smtp-Source: ABdhPJw4O7gy/mCY8R3eccpN9EphWIRUcSMrX6MiuYcl0lF/GA1+eiHQxqk/rn8HNoEOLoK2q3eLLmbEPGFSQRdJ9ZA= X-Received: by 2002:a9d:6e8d:: with SMTP id a13mr1456470otr.287.1615137820107; Sun, 07 Mar 2021 09:23:40 -0800 (PST) In-Reply-To: <837dmjt2e2.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::32e; envelope-from=pipcet@gmail.com; helo=mail-ot1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266138 Archived-At: On Sun, Mar 7, 2021 at 3:22 PM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Sun, 7 Mar 2021 14:21:51 +0000 > > Cc: Stefan Monnier , emacs-devel@gnu.org > > > > > > > I don't think I understand how will we know which function says it > > > > > never calls GC. > > > > > > > > By tagging it in the source code? > > > > > > How do you know which functions to tag? > > > > That's the part I wasn't volunteering for :-) We'd have to do that > > manually, but we wouldn't have to do it all at once. > I don't see how we can do that, without some methodical procedure. Incrementally? I say it might be worth a try, as long as it doesn't go the GCPRO route. If it does, let's delete it again. > > But usually there will already be a comment in those functions > > explaining that they must not call GC, right? > No, I think these are rare exceptions rather than the rule. So we can cover these rare exceptions, at least, converting an ambiguous and hard-to-grep comment into an unambiguous macro invocation? I don't really see the cons, though it's not as great as automatic tagging of functions would be... Pip