From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Some vars now limited to fixnum size. (Was: Merging bignum to master) Date: Mon, 20 Aug 2018 19:55:37 +0000 Message-ID: References: <877ekwu1mn.fsf@tromey.com> <611579fd-52f2-0104-ef82-a7a4a3929700@cs.ucla.edu> <878t51t32a.fsf_-_@red-bean.com> <28fcabff-d102-d67f-442f-f59eab5040c9@cs.ucla.edu> <31ba6457-6428-efc7-8423-1d6134c8e747@cs.ucla.edu> <8336v8ex5f.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1534795005 13865 195.159.176.226 (20 Aug 2018 19:56:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 19:56:45 +0000 (UTC) Cc: kfogel@red-bean.com, eggert@cs.ucla.edu, tom@tromey.com, emacs-devel@gnu.org To: eliz@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 21:56:41 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frqI4-0003SO-RX for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 21:56:40 +0200 Original-Received: from localhost ([::1]:49045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frqKB-0004w3-DN for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 15:58:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frqHq-0003uf-L1 for emacs-devel@gnu.org; Mon, 20 Aug 2018 15:56:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frqHp-0006Sn-Pt for emacs-devel@gnu.org; Mon, 20 Aug 2018 15:56:26 -0400 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:42598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frqHi-0006Jq-Po; Mon, 20 Aug 2018 15:56:19 -0400 Original-Received: by mail-lf1-x131.google.com with SMTP id z11-v6so9519449lff.9; Mon, 20 Aug 2018 12:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bwDeWoihOy9PyUgx6LSWt4DdvW1NbsD/An5oza0iFYg=; b=HAyU+hgTbppFFAW3hRYSVWQtsZqwuvYxLUdCB6WHdE05HjtSJiuLXjHWsVNEVTTzK8 K2tWukLVUehlL7wvkKYJCijcJkGieYYun86HaCmeKfcAY4sM+KsFgY2DMdZlRKT8c8e7 q58E5FvBHBO500N9CCnDaWN4SKGQidoKAd+4iTPfEIW29TiWIaZsENb0NunMi3E2M7Ic U38z+vGd0J3Ylc2dY238jaM/ZSCyJ5K1a/f/Umq8D2Z7SLr7eOSvkqOU56D05J1EAJsL 8WFcXOaLZb7iii/jdGDPchmYFcVe/ElxTLmVLvU+a5DTq2RwYDtt4lXxP9BpHdOKwS6C puUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bwDeWoihOy9PyUgx6LSWt4DdvW1NbsD/An5oza0iFYg=; b=sV7LPpe+kvN9OnojhfUFxZguIw6xLZ9QzOTwzBB9ajDApVPtPg9wsmyT4MmVZaTcoB eZJVtDmSSJizsJo2CixEd5PZuVnpRXRioNGsrT/Aa7Xf3jo2jh8Vap0LcHbPrgTPsikd yunmIzR9pOj1XjGPFdK6RI+R4rhtAtXbkJ6mC8XxDmAjSyBwglTv3AJsu+wsNyM0RZYd un7KH8cbX3n3YSZpl/9vUF1W0j6gpvuyOM5XzHVbRgubp8vHCiOxR6nXh1EGBPzB43Wj FUDf3sui03zid7GmClqFr6pOzqpcMXXINdtcfGD2dVnTi+Xo829yMjpIIdQp09IQsZf1 uvJg== X-Gm-Message-State: AOUpUlGXbT3GXarII2KBWwvuKp8MajgCQBQwcxmztYh6hL6oNoEj4I3W QgKtHlH5zRRUO0to28LsNRVWkY3puqOoZyPsVgwvaA== X-Google-Smtp-Source: AA+uWPwvcEoaCuaETb4xccbBZE740du3xFV9wr1rSh98223n01o9lgwprz6/jp3IyczAJFdEFxRPGWTuvgnU2GtPg7Q= X-Received: by 2002:a19:d204:: with SMTP id j4-v6mr29043575lfg.139.1534794975158; Mon, 20 Aug 2018 12:56:15 -0700 (PDT) In-Reply-To: <8336v8ex5f.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::131 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228761 Archived-At: On Mon, Aug 20, 2018 at 6:01 PM Eli Zaretskii wrote: > > From: Paul Eggert > > Date: Mon, 20 Aug 2018 10:27:34 -0700 > > Cc: tom@tromey.com, Pip Cet , emacs-devel@gnu.org > > > > + if (FIXNUMP (n)) > > + num = XFIXNUM (n); > > + else > > + { > > + num = mpz_sgn (XBIGNUM (n)->value); > > + if (0 < num) > > + num = EMACS_INT_MAX; /* LIST cannot possibly be this long. */ > > So we now silently replace the argument with another, smaller value, > and then go ahead as if business as usual? Is that a good, > user-friendly behavior? It's certainly incorrect for circular lists.