From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel,gmane.emacs.diffs Subject: Re: master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc. Date: Tue, 7 Jan 2020 19:36:23 +0000 Message-ID: References: <20200107192947.22465.82501@vcs0.savannah.gnu.org> <20200107192950.02DA2211A5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1202"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-diffs@gnu.org To: emacs-devel@gnu.org, Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 07 20:37:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ioufV-0015WG-Li for ged-emacs-devel@m.gmane.org; Tue, 07 Jan 2020 20:37:33 +0100 Original-Received: from localhost ([::1]:55436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioufU-0007gK-FX for ged-emacs-devel@m.gmane.org; Tue, 07 Jan 2020 14:37:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41954) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iouez-0007FF-LJ for emacs-devel@gnu.org; Tue, 07 Jan 2020 14:37:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iouey-0001n8-Ll for emacs-devel@gnu.org; Tue, 07 Jan 2020 14:37:01 -0500 Original-Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]:46282) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iouey-0001mS-EH; Tue, 07 Jan 2020 14:37:00 -0500 Original-Received: by mail-oi1-x236.google.com with SMTP id p67so452569oib.13; Tue, 07 Jan 2020 11:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eQzy1ymwSrlCds9YGhwp6ZagLebcI1D2LZikSaj+Uxk=; b=MX7wjFIgsj/6TILvTe+zfsUZJ1XEZlzLSDIn8krV0G2ryKxvBXAaAjzRC6fbZyt4Xa XMR+6rXr4oXgWRMFKxfGChbtJIp9Z7RzAPDzwEkAfvXuWRVUirzE/hauNtHiw4EJ2MJi bPVlt3KaJX+mtgYTdkWRkkVo88s0eJvcdm/fsD/qIiuf89+yIldzUa4XiApXjnSolFre f/ff5/8TtZ1tMl4FnO/RoSpJNRU9l8VR6Yc7NwOokZKdM1SWQAF3DU9AHgRWhIrSx+nX 4iKtz76v9gnK14Ba3BG8xZGLRTcnzOFfUK39eXYnRjFyrzBMqL2jJOzzPKlGRUbVGT3a 0raQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eQzy1ymwSrlCds9YGhwp6ZagLebcI1D2LZikSaj+Uxk=; b=BgPJGyOsAIChfM2qgAa5BFb968OQA89/UeR3C2vJd93QTAmV2uL0eUjNdAnSG2Emxq Ry01k853L9fggMbojZ8mspkr4nNSV6frLNh0BVWbS120Wnkq7igNgFLPIYpKNdPVeDT8 HfdEZAfoK0eEUFkAj7ER4nATmUw9n6hUE4b+1/E81tVEageN+Nimm0hIs3ZrFoeAQ2OR RY2XYbdqkAR1nYWMXl7YBLNiDbfbkuhEKvX6jNC5ZL7TOo2qU6l4t46asU/2LT3zsRKJ ZnCNK8Hj6B60gDOAQ3Gmlu/OtSnGZUgFKoOdsrGYaBc2++Bt8Y1ulMffZNT64Vhti0js iGBQ== X-Gm-Message-State: APjAAAWDbBPPbe4mGj4ohxgWbXDNsPENO4Ewwar/O58T5zkf3VCoOO8V qkPl+z6fGKLk4v6s6yxTvHEB+iQu/7m/6H6I5lZZiB8u X-Google-Smtp-Source: APXvYqx1maUlvdYM9k9FSebbfrq+32b5nY9LPwLpXDr41ePyz+uhNmxBuMmcp3cb7y3b2yTTCfU8v2vzp9pzC4uV4rc= X-Received: by 2002:a05:6808:208:: with SMTP id l8mr28134oie.112.1578425819472; Tue, 07 Jan 2020 11:36:59 -0800 (PST) In-Reply-To: <20200107192950.02DA2211A5@vcs0.savannah.gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:244097 gmane.emacs.diffs:154527 Archived-At: On Tue, Jan 7, 2020 at 7:29 PM Paul Eggert wrote: > + else if (pvec_type == PVEC_MARKER) > + { > + ptrdiff_t bytepos > + = XMARKER (obj)->buffer ? XMARKER (obj)->bytepos : 0; > + hash = sxhash_combine ((intptr_t) XMARKER (obj)->buffer, bytepos); > + hash = SXHASH_REDUCE (hash); > + } Again, I don't think there's any reason for using markers as keys in an equal-based hash table. But if you do, what you probably meant was to use an eq-based hash table, and that used to work; now it doesn't. (puthash marker value ht) <...move marker...> (gethash marker ht) won't work.