From: Pip Cet <pipcet@gmail.com>
To: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-diffs@gnu.org
Subject: Re: emacs-27 41232e6: Avoid crashes due to bidi cache being reset during redisplay
Date: Sun, 31 May 2020 14:44:54 +0000 [thread overview]
Message-ID: <CAOqdjBe1wd1ozvsZALz8bemVHjxj=nWkxZViZ8Rm6JvjVXsfXw@mail.gmail.com> (raw)
In-Reply-To: <20200531142647.08FCA20A2B@vcs0.savannah.gnu.org>
On Sun, May 31, 2020 at 2:26 PM Eli Zaretskii <eliz@gnu.org> wrote:
> diff --git a/src/xdisp.c b/src/xdisp.c
> index bff6218..60848f4 100644
> --- a/src/xdisp.c
> +++ b/src/xdisp.c
> @@ -11539,7 +11539,9 @@ display_echo_area_1 (ptrdiff_t a1, Lisp_Object a2)
> /* Display. */
> clear_glyph_matrix (w->desired_matrix);
> XSETWINDOW (window, w);
> + void *itdata = bidi_shelve_cache ();
But what if we're out of memory? bidi_shelve_cache will call xmalloc...
(Playing around with this, the composition code also tries to allocate
memory when I call memory_full.)
next parent reply other threads:[~2020-05-31 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200531142645.22884.78754@vcs0.savannah.gnu.org>
[not found] ` <20200531142647.08FCA20A2B@vcs0.savannah.gnu.org>
2020-05-31 14:44 ` Pip Cet [this message]
2020-05-31 15:12 ` emacs-27 41232e6: Avoid crashes due to bidi cache being reset during redisplay Eli Zaretskii
2020-05-31 15:36 ` Pip Cet
2020-05-31 15:46 ` Eli Zaretskii
2020-05-31 16:07 ` Eli Zaretskii
2020-05-31 16:24 ` Pip Cet
2020-05-31 16:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOqdjBe1wd1ozvsZALz8bemVHjxj=nWkxZViZ8Rm6JvjVXsfXw@mail.gmail.com' \
--to=pipcet@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-diffs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).