From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Wed, 5 Sep 2018 15:50:27 +0000 Message-ID: References: <86h8j5f33t.fsf@gmail.com> <20300f3e-3061-2cf6-2431-bdd79d00820f@cs.ucla.edu> <83o9dcx9eh.fsf@gnu.org> <00d18e5a-0040-bbf0-c3dd-61e3ac99be4e@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1536162562 16575 195.159.176.226 (5 Sep 2018 15:49:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Sep 2018 15:49:22 +0000 (UTC) Cc: eliz@gnu.org, andrewjmoreton@gmail.com, emacs-devel@gnu.org To: eggert@cs.ucla.edu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 05 17:49:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxa3M-0003yn-El for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 17:49:12 +0200 Original-Received: from localhost ([::1]:56870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxa5S-0008Vu-Ip for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 11:51:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxa5I-0008VE-Lp for emacs-devel@gnu.org; Wed, 05 Sep 2018 11:51:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxa5I-0001PY-31 for emacs-devel@gnu.org; Wed, 05 Sep 2018 11:51:12 -0400 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:37364) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxa5H-0001O1-0r; Wed, 05 Sep 2018 11:51:11 -0400 Original-Received: by mail-lj1-x22d.google.com with SMTP id v9-v6so6681982ljk.4; Wed, 05 Sep 2018 08:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0xHmWyzD64pLlB9jZkc7tldXajA7qW79JK1bbo0b+jM=; b=W2pLqWKWRBD5FMAfmj2TpvFbika6xflB2YmmxxvCRXtnhc9t6b1A+clJX6pQ7tT8g2 duA/ZkYCZj9iRso/BoBZu5F1biT48Kr8TiVXJMHimx/Myn+ujXQ5iUnJHdXa3tmCzo1J RSO//brUsiq+NooPMgg4KNsqZ1BNhi7ueZCxHBI8Jxn5PQt+7AHk1k2l46+GLm+xLxj4 SXNT6g+7ESKN/YR0x2AX8WIkfS/qCJeIYPoRY66RiMQgUD65E5GpSC5ARyWJqcud2CbP I15xZmYI8kknZXT3eeMbib9N0gPlT02uvDZH2mlAgpHGbsl+W9L2pv2zB1ZO7ew2ssc4 AzZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xHmWyzD64pLlB9jZkc7tldXajA7qW79JK1bbo0b+jM=; b=Qps9Dyd6PIh5UFxmLCjyKo8RsZURtkudlNMFThlF8MDWlhCC6Idac/UZ3Eeu2oUdXs O1ygFD/tMR/30d8R150J1JoHq16XzyWc5LC2ptmOH6Wa8zuzMle6juLP/PQHxdl+gx4F BksCpXCDxP5bns+wGnaBHVdlR/P1PbV02XgE31hTCwREBs6pIgKRbOfiaIAK6XE97ACZ HfWMOTO9bHuFNcGNK2nBe8bOmgqiwRzvKuXunsngDF5D4qcmDCnBHZ4oEG3EHwHiqTyo 5tgNGYEB4nAyR/5kMZD/phBFfn97hF+0FwRCOj4Rjf0C9TBJdhsTFYje9XTXRsZqwJVv nqew== X-Gm-Message-State: APzg51D1JsJUPuNDmqQYKFeGH9yPMV7ofYcttfdhOTvf73sulO+wTx+m IW8hT3KXh2KxuxKZ5q4MN9Z+NVQqMfuZlbbxakU= X-Google-Smtp-Source: ANB0VdZhRGumqYhIPa+BedDDs18v1URX+hfBCpgVd8q6wNDYO1mbTz2l1T7PhGHVwSjUE+k62WK0/xrBDKJFceH9SJ8= X-Received: by 2002:a2e:9243:: with SMTP id v3-v6mr23249560ljg.92.1536162669332; Wed, 05 Sep 2018 08:51:09 -0700 (PDT) In-Reply-To: <00d18e5a-0040-bbf0-c3dd-61e3ac99be4e@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229301 Archived-At: On Wed, Sep 5, 2018 at 3:41 PM Paul Eggert wrote: > or the eassert buried inside XFIXNUM There is no eassert inside XFIXNUM, which makes it different from XSYMBOL etc. I think there should be; that would break the code we're talking about here, but IMHO it's much cleaner not to call XFIXNUM on a non-fixnum, knowing that the clever way the code is written will prevent the meaningless integer thus achieved from ever being used. I doubt there is a performance gain to be had from that way of writing code, and it's very hard to read. And there might even be a performance win to assuming XFIXNUM's argument has the right tag value.