From: Pip Cet <pipcet@gmail.com>
To: eggert@cs.ucla.edu
Cc: eliz@gnu.org, andrewjmoreton@gmail.com, emacs-devel@gnu.org
Subject: Re: Bignum speedup patch causes crash at startup
Date: Wed, 5 Sep 2018 15:50:27 +0000 [thread overview]
Message-ID: <CAOqdjBdZMmnFq1WgxRWfihpcz-UJNTqHAGickO4oVHS+7XGy_A@mail.gmail.com> (raw)
In-Reply-To: <00d18e5a-0040-bbf0-c3dd-61e3ac99be4e@cs.ucla.edu>
On Wed, Sep 5, 2018 at 3:41 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
> or the eassert buried inside XFIXNUM
There is no eassert inside XFIXNUM, which makes it different from
XSYMBOL etc. I think there should be; that would break the code we're
talking about here, but IMHO it's much cleaner not to call XFIXNUM on
a non-fixnum, knowing that the clever way the code is written will
prevent the meaningless integer thus achieved from ever being used. I
doubt there is a performance gain to be had from that way of writing
code, and it's very hard to read. And there might even be a
performance win to assuming XFIXNUM's argument has the right tag
value.
next prev parent reply other threads:[~2018-09-05 15:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 14:21 Bignum speedup patch causes crash at startup Andy Moreton
2018-09-04 15:10 ` Eli Zaretskii
2018-09-04 16:24 ` Eli Zaretskii
2018-09-04 18:59 ` Paul Eggert
2018-09-05 2:35 ` Eli Zaretskii
2018-09-05 7:31 ` Paul Eggert
2018-09-04 16:40 ` Paul Eggert
2018-09-04 17:30 ` Eli Zaretskii
2018-09-04 17:37 ` Andy Moreton
2018-09-04 17:50 ` Eli Zaretskii
2018-09-04 19:50 ` Andy Moreton
2018-09-04 21:11 ` Paul Eggert
2018-09-04 22:34 ` Tom Tromey
2018-09-05 0:09 ` Andy Moreton
2018-09-05 0:56 ` Paul Eggert
2018-09-05 15:21 ` Eli Zaretskii
2018-09-05 15:17 ` Eli Zaretskii
2018-09-04 19:56 ` Andy Moreton
2018-09-04 20:48 ` Paul Eggert
2018-09-05 15:15 ` Eli Zaretskii
2018-09-05 15:40 ` Paul Eggert
2018-09-05 15:50 ` Pip Cet [this message]
2018-09-05 16:06 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBdZMmnFq1WgxRWfihpcz-UJNTqHAGickO4oVHS+7XGy_A@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=andrewjmoreton@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).