From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Bug#38708: eq vs eql in byte-compiled code Date: Thu, 2 Jan 2020 12:27:14 +0000 Message-ID: References: <8cd1b5b2-b94e-ce64-0d70-c1b8b012d685@cs.ucla.edu> <1e0940ff-e418-bafc-66d3-72b562b2c65b@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44590"; mail-complaints-to="usenet@blaine.gmane.org" Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , Stefan Monnier , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 02 13:28:25 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1imzaR-000BT2-4v for ged-emacs-devel@m.gmane.org; Thu, 02 Jan 2020 13:28:23 +0100 Original-Received: from localhost ([::1]:40626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imzaP-0003a4-Cj for ged-emacs-devel@m.gmane.org; Thu, 02 Jan 2020 07:28:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51845) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imzZx-0003BC-SB for emacs-devel@gnu.org; Thu, 02 Jan 2020 07:27:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imzZw-00060f-ML for emacs-devel@gnu.org; Thu, 02 Jan 2020 07:27:53 -0500 Original-Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:37503) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1imzZw-00060M-Fu for emacs-devel@gnu.org; Thu, 02 Jan 2020 07:27:52 -0500 Original-Received: by mail-ot1-x32a.google.com with SMTP id k14so56874714otn.4 for ; Thu, 02 Jan 2020 04:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FT7Y2ya6u7UsHFsU5vMcr0pyL5nv1GEY7hz6jOBkv+w=; b=AWiVksYPJAB+FJ0uLzBRduhI2AQhAEHKP4lWt5FSi20/Bc+GmRZ/lY4tv5KtQ3XN4T Hp2r1oExRzZXILWGqpTL1Rn6lK+2QwuzuShDPpjjbhGBUCyvu7aKQvBGFODe2Rvx+P+W RbiWANY9gZGR92VL/xjhCSG/pAOZd9499ADisHkI/2sloVbHLiv75KiMGk931M7Nd2ym IL0AfgsXSTxfBA2iqRMTI1cIIFRlFC48awoj0+mRQyxMvAot5gVQmj0iLtiUfsc2ngND YGticFYkBg/2EGI/zlVpKjs1MIdyGTLnqxlNt0Bk+9wo5hmDvq0gCjoq8h+ihNG8y2vj US3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FT7Y2ya6u7UsHFsU5vMcr0pyL5nv1GEY7hz6jOBkv+w=; b=brNeEYr3KisgoVM0+T6f3RceeNdXPjla+AQ2WBcg/HSrsVxyXQMMWSBlEhh+0vpqEK +H6Gde0HwdtESLJlS7JNdDyoOhFbJcERTH4HdC2zDoLD/3zCIKoDiHM0MINyQh7fS+X4 YmhE2CMZz82nTng7KsXXVtTwkdb9n9eQwCwXK9dDg+tTgwfk1fZ/rpJPgpIL/sftMPip ilD0FVPGqE3RulETd0aDWs1rMOv46rCJB6Y5k7JFCmCd9z5HrS5IeKHNNI4bOf/KlkmK 0q/ziSdUSZiUJrwkvWybMFhdC2RN1+TTUZeiCyVanywG/TZUCBk53b2vT/uT6jNOvpY1 MWPA== X-Gm-Message-State: APjAAAVvUxpcmHbZh91xnAQ29zLZk0daitMhC+If3Y4oqbCQbyL/jFNH 0NB5Htxq8LO952lETaSe25Fbdjw0WKR5Q5N+mBA= X-Google-Smtp-Source: APXvYqxEoU4ZQxNMH7B5azByc8UdAXzdrXeLNf3pvUcts8dTlTkoh1HQkugvWjMhCc9qOEz0IS1cg/WbTtbc5Uu5agM= X-Received: by 2002:a9d:68cb:: with SMTP id i11mr87136979oto.210.1577968070799; Thu, 02 Jan 2020 04:27:50 -0800 (PST) In-Reply-To: <1e0940ff-e418-bafc-66d3-72b562b2c65b@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243861 Archived-At: On Thu, Jan 2, 2020 at 7:52 AM Paul Eggert wrote: > I did that, and surprise! it sped up 'make compile-always' by about 7% on the > two platforms I tried it on (Fedora 31 and Ubuntu 18.04.3, both x86-64). For what it's worth, I'm not seeing that effect, and it seems too large to me to be easily explicable. I might be mistaken, but our hash tables never shrink, do they? That sounds like a potential problem to me, particularly for people who mess about with gc settings; but I haven't been able to produce a problem in practice with your patch. > Two or three issues: > > * Should we document that eq == eql on bignums, or continue to leave this stuff > unspecified? I don't think we should be making any new promises about eq. > * Should we try hash-consing floats too? Maybe it wouldn't be as slow as we > thought, for typical computations anyway.... I think the answer is yes here... > * The attached patch could probably be sped up a bit by supporting sets as well > as mappings at the low level, since bignum_map is really just a set of bignums. > Not sure it's worth the effort, though. if it's also yes here.