unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Pip Cet <pipcet@gmail.com>
To: Daniel Colascione <dancol@dancol.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Failing to GC killed buffers considered harmful
Date: Sun, 29 Mar 2020 19:25:08 +0000	[thread overview]
Message-ID: <CAOqdjBdLn2fWC81xRNv1QxmGv9T6BA-6ep2gQd=cx=EPE4BVkQ@mail.gmail.com> (raw)
In-Reply-To: <65b0b33a-a85b-e294-6a75-2419552cdbff@dancol.org>

On Sun, Mar 29, 2020 at 7:12 PM Daniel Colascione <dancol@dancol.org> wrote:
> On 3/29/20 12:07 PM, Pip Cet wrote:
> > On Sun, Mar 29, 2020 at 6:48 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > The call to garbage_collect in Fdump_emacs_portable doesn't actually
> > reduce image size.
>
> It runs finalizers, which can free additional memory.

Indeed; it can also remove entries from weak hash tables, collect
markers, and collect buffers which would otherwise be dumped. In
practice, though, none of that appears to happen in a standard dump,
at least not to the point where image size is affected. And none of
that can happen predictably with conservative garbage collection.

We could make garbage collection predictable in this one case, by not
marking the stack and making dump-emacs-portable a noreturn function.
I don't think we should.



  reply	other threads:[~2020-03-29 19:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-29 14:23 Failing to GC killed buffers considered harmful Eli Zaretskii
2020-03-29 16:45 ` Stefan Monnier
2020-03-29 18:54   ` Eli Zaretskii
2020-03-29 19:06     ` Daniel Colascione
2020-03-29 19:24       ` Eli Zaretskii
2020-03-29 16:46 ` Pip Cet
2020-03-29 18:48   ` Eli Zaretskii
2020-03-29 19:07     ` Pip Cet
2020-03-29 19:12       ` Daniel Colascione
2020-03-29 19:25         ` Pip Cet [this message]
2020-03-29 19:28           ` Eli Zaretskii
2020-03-30 15:36             ` Pip Cet
2020-03-30 15:53               ` dancol
2020-03-30 17:07             ` Stefan Monnier
2020-03-30 17:02   ` Stefan Monnier
2020-03-30 18:32     ` Stefan Monnier
2020-03-30 18:51       ` Eli Zaretskii
2020-03-30 19:14         ` Daniel Colascione
2020-03-30 19:40         ` Stefan Monnier
2020-03-31 14:07           ` Eli Zaretskii
2020-03-31 14:09       ` Eli Zaretskii
2020-03-31 21:57         ` Stefan Monnier
2020-03-31 14:58       ` Pip Cet
2020-03-31 16:52         ` Stefan Monnier
2020-03-31 18:23           ` Pip Cet
2020-03-31 19:20             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOqdjBdLn2fWC81xRNv1QxmGv9T6BA-6ep2gQd=cx=EPE4BVkQ@mail.gmail.com' \
    --to=pipcet@gmail.com \
    --cc=dancol@dancol.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).