From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Failing to GC killed buffers considered harmful Date: Sun, 29 Mar 2020 16:46:03 +0000 Message-ID: References: <838sjj5jg9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="65833"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Colascione , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 29 18:47:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jIb6G-000H3u-CP for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Mar 2020 18:47:52 +0200 Original-Received: from localhost ([::1]:39572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIb6F-0002t3-EC for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Mar 2020 12:47:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47408) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIb59-0001pI-Ak for emacs-devel@gnu.org; Sun, 29 Mar 2020 12:46:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIb58-0006uV-EY for emacs-devel@gnu.org; Sun, 29 Mar 2020 12:46:43 -0400 Original-Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:37686) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIb56-0006lA-KZ; Sun, 29 Mar 2020 12:46:40 -0400 Original-Received: by mail-ot1-x32c.google.com with SMTP id g23so15448217otq.4; Sun, 29 Mar 2020 09:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x6DliYA1c85d9Omhp4Z8PG/u0sHONKXH15AEyRUWmoQ=; b=RiQTmtWZKG5BDktxQTunJoDGpLnMfJ59KCbAuL31fEijx3UcwM2jLT0QF1PGw8c402 f1AgLGEkO89R9YGQWZAeZBTYCzUc4lEiWU3HqvUBZ+CnybIHVhDCdWcbnGlrr8r1nBkj boPOEY+o68hXSHsuQHT8XkNhQrQzrlHfWPNjBCjgfWdCzPh2G9ZPKlvJE1kLx0cFbW2G UmvCQagRy7b9oBGUsGGIZ3HIYi/hhwo7FEl7ZJTkCIh0UiN4vko7dIQ8cZ7dRg64yFRA FwzrspCeoMZOcxRPVX6jyVps4tiDj9tEnCV/Q0lkZW8Bmxxe4Fl6ufKayyyVwaC/oSGn xZeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x6DliYA1c85d9Omhp4Z8PG/u0sHONKXH15AEyRUWmoQ=; b=avxJ3mvQ7jdLT0sW+q5H5DJ/4DmEkZQgxZ2EsQ6XqfPv78JS8P3xOPrLc8w3kQQXNd rqxv5ZD3h09PR1izvRY+QK8AxaUcefFpRcEAA6/qwfx5IHN5ex+wB1Ls9OW+qHNPW2bC wDnWU/xkks+8MT4hS9PdJfe8AJzLp2+VMQXDkFgdVi9u0J2WuT5d6caLxtEXcPK99KEn /j6ODP/J1TDAK14+tLoquEeEIAzLGFKJZXtRskmpCOKBlqIaRjZCM0b0aQprYRfjwMFa JhXczCb/5dbEEc6fWVihSkGSK4t9Qy5wxlbqx7lOCaW5NtEInnlZP7GruBxAJpN2F/6D a2Sw== X-Gm-Message-State: ANhLgQ2LLVJaIL4xFR4yn5L1Hljn3klMxa+jtiEF1GCpNNK+E455t4xu Q+UHw7Ks8CGZbkZE8wTKQnczJJyab/S1GPWeWIPP40xg X-Google-Smtp-Source: ADFU+vtP/mFxx9hrIokenqb5qG4kIBcOahI4vzl6IZDZi/ln/Ffp/oVm3+1PeNlhUDn7Bjy7OFQPAZeKXyPbiclgbao= X-Received: by 2002:a05:6830:15cf:: with SMTP id j15mr6642837otr.292.1585500399445; Sun, 29 Mar 2020 09:46:39 -0700 (PDT) In-Reply-To: <838sjj5jg9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245946 Archived-At: On Sun, Mar 29, 2020 at 2:22 PM Eli Zaretskii wrote: > This recent change on master: > causes us to dump killed buffers in some cases. Presumably, the call > to GC right before we start pdumping fails to collect a killed buffer, > and it ends up being dumped. When we restore from emacs.pdump, an > Emacs built with --enable-checking on a platform that uses mmap for > buffer text aborts here: Not in all cases, I'm afraid. > We could, of course, remove the assertion, but then we are left with a > dead buffer that will never be GC'ed, AFAIU, because objects that come > from the portable dump are considered constantly marked. The same is true of all other objects, though, right? It seems like it's simply a bad assert to me. The problem appears to be that "all_buffers" points to a killed buffer, and is remembered by pdumper.