From: Pip Cet <pipcet@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
emacs-diffs@gnu.org, emacs-devel@gnu.org
Subject: Re: master 9227864: Further fix for aborts due to GC losing pseudovectors
Date: Tue, 26 May 2020 17:25:38 +0000 [thread overview]
Message-ID: <CAOqdjBcvBH0Fyr4HbOAtG-ELzNQrBstCJYd8bixJXDZeRODThw@mail.gmail.com> (raw)
In-Reply-To: <jwv5zci69ac.fsf-monnier+emacs@gnu.org>
On Tue, May 26, 2020 at 2:51 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > Oh, you're right. No harm so far since LISP_ALIGNMENT is 8 on current platforms.
>
> For 64bit float, a LISP_ALIGNMENT greater than 8 would imply
> a significant amount of waste (same for cons cells on 32bit systems).
> So I think it'll stay at 8 for the foreseeable future (which doesn't
> mean we can't decide to use large alignment for some other objects, of
> course).
I'm hoping that if we have an allocate_aligned_pseudovector function
(or macro) we won't need LISP_ALIGNMENT at all. Which is good, since
it was misnamed (pure Lisp data and Lisp data on the stack never
obeyed LISP_ALIGNMENT. I'm suspicious about pdumper data, too, as
pdumper.c sets DUMP_ALIGNMENT to GCALIGNMENT on many practical
platforms, not LISP_ALIGNMENT). It's true that GCALIGNMENT is 1 on
some platforms, but we can change that, can't we?
I guess the recent bugs also make it impossible to do a 32-bit
--wide-int USE_LSB_TAG build. My suspicion is that that would actually
be faster, since we need only look at one 32-bit word to chase a
pointer, but it would make stack marking a lot slower...
next prev parent reply other threads:[~2020-05-26 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200526060645.22243.34109@vcs0.savannah.gnu.org>
[not found] ` <20200526060646.662E120A2C@vcs0.savannah.gnu.org>
2020-05-26 6:40 ` master 9227864: Further fix for aborts due to GC losing pseudovectors Pip Cet
2020-05-26 7:09 ` Paul Eggert
2020-05-26 7:25 ` Pip Cet
2020-05-26 7:40 ` Paul Eggert
2020-05-26 8:02 ` Pip Cet
2020-05-26 14:51 ` Stefan Monnier
2020-05-26 17:25 ` Pip Cet [this message]
2020-05-26 17:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBcvBH0Fyr4HbOAtG-ELzNQrBstCJYd8bixJXDZeRODThw@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=emacs-diffs@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).