From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch Date: Mon, 22 Jul 2019 04:12:05 +0000 Message-ID: References: <20190721193221.1964.53182@vcs0.savannah.gnu.org> <20190721193222.8C19E20BE2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000094d1e6058e3d49b5" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="127895"; mail-complaints-to="usenet@blaine.gmane.org" To: emacs-devel@gnu.org, Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 22 06:12:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpPgv-000X9n-4l for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 06:12:49 +0200 Original-Received: from localhost ([::1]:58640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpPgt-0006Kl-JQ for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 00:12:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50275) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpPgq-0006Kf-Ud for emacs-devel@gnu.org; Mon, 22 Jul 2019 00:12:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpPgp-0006Ph-Es for emacs-devel@gnu.org; Mon, 22 Jul 2019 00:12:44 -0400 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:45653) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpPgp-0006P3-93 for emacs-devel@gnu.org; Mon, 22 Jul 2019 00:12:43 -0400 Original-Received: by mail-ot1-x332.google.com with SMTP id x21so330905otq.12 for ; Sun, 21 Jul 2019 21:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6wW0JLAQaoiOvR+He+NrzwaE1qn1JFqFaYjo150jwUg=; b=OssC/bF20r6ePx89W5zam+0sirXxWzO4JdqzUO9k8BSswdcRx2dP90XbsCpF2QeOWF f9JsHiWpT7WcI1g7E37Qab0sppF/Ax1iyN1+bTAzaqYtB5GjPx24jRL5UtE0p+uq1wbZ da2ZYuqENYVjXaOds1qPbn/ToUB7AEclUL2o7PbVcLsebrpZaeHDpl6oKkXFY1daWvIF e+Dp2CgHlflauEgUf7JziI6N2sxFmCTfGSmXev2uwAj5CH0cztIeKE/QY8+7Sy5HakGB +j046LRfCFF7OotxmdfEVh2y0sFJQ9BPQ8lynBIxnuvdsJHj4kWStdwUiFiNNorfzAop R0jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6wW0JLAQaoiOvR+He+NrzwaE1qn1JFqFaYjo150jwUg=; b=Th2+eVv4LkXw1PiJIcIUKTDXSsqK4PMeo1T0fiOd3TGtuN+DWc8N999fBydii4XaYq oj/0kl0k+Lyyyb504Oh3U1LxQ+8uJzpurnt1TNequQ+MeAG4wVE/p4sLDaKqodJOeEoM 0LNnIqFCA6eWFJFH9FTnk7T5kqYQPMkseOzIMf6NJi90HpPLhjHsHTbZ1VpZeMjRuPcx LWRGdjN55a+I7T7+ZhkD1YlLiOjls64icziSQrqB8WG1S/KiLiEMTFE4XP+fXtWnJcL2 H2+HWHiH95taZMVLeTSjHHmTmUbFVh6vTv+Jy7VXdbb+0vPjOTVfhF3R1aNNgcpd+4Bp Ueww== X-Gm-Message-State: APjAAAU/uwu2GesVzq0CS5ZMNwx8SOVZZyH/xzUfPCQEoXhHvIc0br3u XhvUQpiy5egS5Qs6NbZOJLsgpFMIEkTj/xKr+5wtyQ== X-Google-Smtp-Source: APXvYqw7cpjq08+HfTUMSwmyAohsO/iDzpLI/mBvpqFtB4UWcQmnuSibEly74U3Mevy3yJKpaD8XIMBtbemM15gauXQ= X-Received: by 2002:a9d:7352:: with SMTP id l18mr46126739otk.292.1563768762182; Sun, 21 Jul 2019 21:12:42 -0700 (PDT) In-Reply-To: <20190721193222.8C19E20BE2@vcs0.savannah.gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::332 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238779 Archived-At: --00000000000094d1e6058e3d49b5 Content-Type: text/plain; charset="UTF-8" On Sun, Jul 21, 2019 at 7:32 PM Paul Eggert wrote: > static void > -allow_garbage_collection (void *ptr) > +allow_garbage_collection (intmax_t consing) > { > - object_ct *p = ptr; > - consing_until_gc = *p; > + consing_until_gc = consing; Shouldn't we count the allocations that happened while GC was inhibited and subtract them from consing_until_gc afterwards? Also, should garbage_collect_1 use inhibit_garbage_collection rather than fiddling with consing_until_gc directly? Attaching a patch that does both. --00000000000094d1e6058e3d49b5 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Trigger-GC-earlier-after-garbage-collection-was-inhi.patch" Content-Disposition: attachment; filename="0001-Trigger-GC-earlier-after-garbage-collection-was-inhi.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jydvhtlv0 RnJvbSA3ZGExMTIyYjliZjRmMGFiOGRhNjk1OGJjYTM2YzliYzA3MjY1NjRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBNb24s IDIyIEp1bCAyMDE5IDA0OjA5OjI5ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gVHJpZ2dlciBHQyBl YXJsaWVyIGFmdGVyIGdhcmJhZ2UgY29sbGVjdGlvbiB3YXMgaW5oaWJpdGVkCgoqIHNyYy9hbGxv Yy5jIChhbGxvd19nYXJiYWdlX2NvbGxlY3Rpb24pOiBEb24ndCBpZ25vcmUgYWxsb2NhdGlvbnMK dGhhdCBoYXBwZW4gd2hpbGUgZ2FyYmFnZSBjb2xsZWN0aW9uIGlzIGluaGliaXRlZC4KKGdhcmJh Z2VfY29sbGVjdF8xKTogdXNlIGBpbmhpYml0LWdhcmJhZ2UtY29sbGVjdGlvbicuCi0tLQogc3Jj L2FsbG9jLmMgfCA0ICsrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2FsbG9jLmMgYi9zcmMvYWxsb2MuYwppbmRleCBh YTkyMDBmMmViLi5hMzIzMDJmNmUyIDEwMDY0NAotLS0gYS9zcmMvYWxsb2MuYworKysgYi9zcmMv YWxsb2MuYwpAQCAtNTUwNyw3ICs1NTA3LDcgQEAgc3RhdGljcHJvIChMaXNwX09iamVjdCBjb25z dCAqdmFyYWRkcmVzcykKIHN0YXRpYyB2b2lkCiBhbGxvd19nYXJiYWdlX2NvbGxlY3Rpb24gKGlu dG1heF90IGNvbnNpbmcpCiB7Ci0gIGNvbnNpbmdfdW50aWxfZ2MgPSBjb25zaW5nOworICBjb25z aW5nX3VudGlsX2djICs9IGNvbnNpbmcgLSBPQkpFQ1RfQ1RfTUFYOwogICBnYXJiYWdlX2NvbGxl Y3Rpb25faW5oaWJpdGVkLS07CiB9CiAKQEAgLTU4MjMsNyArNTgyMyw3IEBAIGdhcmJhZ2VfY29s bGVjdF8xIChzdHJ1Y3QgZ2NzdGF0ICpnY3N0KQogCiAgIC8qIEluIGNhc2UgdXNlciBjYWxscyBk ZWJ1Z19wcmludCBkdXJpbmcgR0MsCiAgICAgIGRvbid0IGxldCB0aGF0IGNhdXNlIGEgcmVjdXJz aXZlIEdDLiAgKi8KLSAgY29uc2luZ191bnRpbF9nYyA9IE9CSkVDVF9DVF9NQVg7CisgIGluaGli aXRfZ2FyYmFnZV9jb2xsZWN0aW9uICgpOwogCiAgIC8qIFNhdmUgd2hhdCdzIGN1cnJlbnRseSBk aXNwbGF5ZWQgaW4gdGhlIGVjaG8gYXJlYS4gIERvbid0IGRvIHRoYXQKICAgICAgaWYgd2UgYXJl IEdDJ2luZyBiZWNhdXNlIHdlJ3ZlIHJ1biBvdXQgb2YgbWVtb3J5LCBzaW5jZQotLSAKMi4yMi4w Cgo= --00000000000094d1e6058e3d49b5--