From: Pip Cet <pipcet@gmail.com>
To: emacs-devel@gnu.org, "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-diffs@gnu.org
Subject: Re: emacs-27 c2b8ce4: Calc: don't treat nil as an integer (bug#40155)
Date: Sun, 29 Mar 2020 08:20:12 +0000 [thread overview]
Message-ID: <CAOqdjBcTp_TGNfDvRpA+53h7FUgQEKZB4L0CQqfN7GOtunrNPg@mail.gmail.com> (raw)
In-Reply-To: <20200328115157.083362094A@vcs0.savannah.gnu.org>
On Sat, Mar 28, 2020 at 11:52 AM Mattias Engdegård
<mattiase@savannah.gnu.org> wrote:
> diff --git a/test/lisp/calc/calc-tests.el b/test/lisp/calc/calc-tests.el
> index 784b404..8fffb7c 100644
> --- a/test/lisp/calc/calc-tests.el
> +++ b/test/lisp/calc/calc-tests.el
> @@ -334,6 +334,17 @@ An existing calc stack is reused, otherwise a new one is created."
> (should (equal tos '(- (* 2 (var x var-x)) 4)))
> (should (equal trail "pdiv 2 * x - 4\nprem 8 * x + 1\n"))))))
>
> +(ert-deftest calc-Math-integerp ()
> + (should (Math-integerp -7))
> + (should (Math-integerp (ash 1 65)))
> + (should-not (Math-integerp '(float 1 0)))
> + (should-not (Math-integerp nil))
> +
> + (should (Math-num-integerp -7))
> + (should (Math-num-integerp (ash 1 65)))
> + (should (Math-num-integerp '(float 1 0)))
> + (should-not (Math-integerp nil)))
Shouldn't we be testing (Math-num-integerp nil) here? If not, why not?
next parent reply other threads:[~2020-03-29 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200328115155.23664.87229@vcs0.savannah.gnu.org>
[not found] ` <20200328115157.083362094A@vcs0.savannah.gnu.org>
2020-03-29 8:20 ` Pip Cet [this message]
2020-03-29 9:17 ` emacs-27 c2b8ce4: Calc: don't treat nil as an integer (bug#40155) Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBcTp_TGNfDvRpA+53h7FUgQEKZB4L0CQqfN7GOtunrNPg@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=emacs-diffs@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).