From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: feature/native-comp 5bc0855 2/2: Don't treat '=' as simple equality emitting constraints (bug#46812) Date: Sun, 7 Mar 2021 07:03:34 +0000 Message-ID: References: <20210228230215.15472.12941@vcs0.savannah.gnu.org> <20210228230217.1971E20E1B@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10507"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Andrea Corallo via Emacs development discussions." To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 07 08:04:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lInTB-0002ch-Gg for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 08:04:53 +0100 Original-Received: from localhost ([::1]:38068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lInTA-0003pO-IB for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Mar 2021 02:04:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lInSa-0003Ou-C4 for emacs-devel@gnu.org; Sun, 07 Mar 2021 02:04:16 -0500 Original-Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]:42168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lInSV-0002i8-D3 for emacs-devel@gnu.org; Sun, 07 Mar 2021 02:04:15 -0500 Original-Received: by mail-oi1-x229.google.com with SMTP id x135so3082096oia.9 for ; Sat, 06 Mar 2021 23:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EIABWTzXvHR+/sPAWFpm41CJgdFcPbDhuzkk/pbnSMI=; b=pPKV4RVx1aDt0f4A81ygxxgLip98G3CIjXQOsIjwb53nEhqO81jsKDYzSp2Oy5ijr8 dbQiBNEZCZMlOdHKx9Bt52VrllMZBfWJvI/ZhEscP9wpiT7sjGvk4HGbPO1I8T6Fa+rC 2CqlNRh/KR+NO0F6L0DlaZ1SeMsWO+qeM85m3Ys+cFExy/mgkl6HAOqC88dB9bUIs1vl yQ5FXvXfOnG/38de6vneQJsS9ssObx9EcupSMjFYvPXSLr4Vo2VCtnlSnpi0y2xt1nQu 30WW5Am6D08pJUOJHWhhJliAq9yb2gQ37MQMv3G6+no5FidMuzgEp/qwo1jAKk4B1ffc 9XZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EIABWTzXvHR+/sPAWFpm41CJgdFcPbDhuzkk/pbnSMI=; b=SPy9by4vTI8c1lMffvkc6GqDbEuH0BbUpP8RB8XGZ6/hEsX8u19uf2ctkHUibEGxF8 8EQ4Y3tpOqDmkHXmyc5mbeP1yaoIi6g7twiBoAX95OXZKvCdszEqqP9nB1Y/awX0lM5x pAASkGDKQUoTvYoOG0YC0STSMLONno0OhG3uV//7e1HgCeQuVd5fBF1c/LZp7JlYvPqh vkcxnpRVV7GxY68j53hVC/WnjPIf7BtVTjYWCvyhgPei5LnytFMprlxaOCdLzEP4CdA8 D/Ljzihc6S88RHf3TEDApNSZjXJk7Omk6Wh37U+FukU7js8T7SkeMqDRXkAvpGseekQ9 /cCw== X-Gm-Message-State: AOAM531UfyIJCFaHkrTiG/WstiRkWxvCjuGP1wucSlhxzQuLAUUdTbNi y9tmlCpX2rF8Kifcg5l0AmmEXJbtlsu7Djx7rdc= X-Google-Smtp-Source: ABdhPJywcVQ0oPhTEQLqo+ycReOIj1/eT7i5cFmqER327TSBaSUI13KVsr4EjlPCFxUvRsueOCq/MQkV0srSHtAA42A= X-Received: by 2002:a54:4196:: with SMTP id 22mr2690302oiy.30.1615100650258; Sat, 06 Mar 2021 23:04:10 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::229; envelope-from=pipcet@gmail.com; helo=mail-oi1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266113 Archived-At: On Sat, Mar 6, 2021 at 10:18 PM Andrea Corallo wrote: > The two reported miscompilations should be fixed now as of c60f2f458a, > please have a look. I did. I still don't understand how the intersect-first-then-relax approach is meant to work, and it's not working. Here's a more fundamental problem: if we modify two values known to be equal, they might no longer be: (let* ((cons1 '(a)) (cons2 (copy-sequence cons1)) (cons3 (copy-sequence cons1))) (subr-type (native-compile `(lambda (x y) (unless (eq x ',cons1) (error "")) (unless (eq y ',cons2) (error "")) (setcar ',cons1 'b) (equal y ',cons3))))) > Still have to look into the missed optimization for the null returning > function, will do. I'm not sure what you're referring to here. My approach, and it's perfectly okay for you to see this differently, would be to fix the correctness bugs first, then go for any missed optimizations. Pip