From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Spiers Newsgroups: gmane.emacs.devel Subject: Re: Patch upstream Git for Elisp diff hunk headings Date: Sat, 13 Feb 2021 19:35:38 +0000 Message-ID: References: <87czx68y4i.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Protesilaos Stavrou , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 13 20:36:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB0io-0007Rg-7h for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Feb 2021 20:36:50 +0100 Original-Received: from localhost ([::1]:49520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lB0in-0004NS-9F for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Feb 2021 14:36:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lB0ht-0003sl-9T for emacs-devel@gnu.org; Sat, 13 Feb 2021 14:35:53 -0500 Original-Received: from mail-ej1-f44.google.com ([209.85.218.44]:33178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lB0hr-0004wj-QA for emacs-devel@gnu.org; Sat, 13 Feb 2021 14:35:52 -0500 Original-Received: by mail-ej1-f44.google.com with SMTP id jt13so5088656ejb.0 for ; Sat, 13 Feb 2021 11:35:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/d5DEDzEx93G1cuNJ+T4KH/+6PHg3b4A8X5J2LBMRb0=; b=cgcBnFQr3Rvrmi25Zpv+ud6R5nNDT1oYYvFO5LKGxHd3pLaWBSFq9sT3HRr5c4plsW vflBr7x+g9UUSHYT4Pm8mHCLeca3+1Ds2kxAuEUtS0N4bCy4rxoX9yM9cVxbUpcyNkAI n3H4uEkfaNqYuYOp4r5cu0CWDKzKWhbZe8gIALqW+3Vkxmc3JNKv1cswlaaJYAgrlJcD m50yXuPlfAHp9ja0mQ3qGnbnNSi4fG15XS50G0L9l1fKTurHIw/1+ABd1iifd86uvHht /q3hLoEauR9KvPgU+GW/EfPv4lzJ942ZkZ2eNM59lJGfdkrvQAbP20kWiuvvcJkt9865 Mpew== X-Gm-Message-State: AOAM531Fp0JAJbFxr4UI7voYnZDXupNz771j0B31riQhTMQz/ONnWkGL 0LJYliRDWqry6bEeYjiXu6TdcQX08HLdx8IiuWU= X-Google-Smtp-Source: ABdhPJxPxO5oSgHV/0R5V7kRL3StN3rubdwbBOyIAq9AFSYXt4YnS9iSFF/sC2NJbB/RzJWX5N6Bjy1f9gi+QXXmpfs= X-Received: by 2002:a17:907:a059:: with SMTP id gz25mr8728385ejc.400.1613244949568; Sat, 13 Feb 2021 11:35:49 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=209.85.218.44; envelope-from=adam.spiers@gmail.com; helo=mail-ej1-f44.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264648 Archived-At: On Thu, 11 Feb 2021 at 19:38, Stefan Monnier wrote: > > git_config diff.elisp.xfuncname "^(\\(.*)$" > > LGTM. > But as you suggested, it would be good to add something like > "^;;;;* [^[:space:]]" to it. Thanks Stefan and everyone else for your feedback. This has now been submitted to the git mailing list: https://public-inbox.org/git/20210213192447.6114-1-git@adamspiers.org/ so if you have further feedback, please reply there. (I thought about cross-posting, but that usually angers at least one person ;-)