Re: [NonGNU ELPA] new package: clangd-inactive-regions

[Filippo Argiolas <filippo.argiolas@gmail.com>]

On Sun, Nov 3, 2024 at 2:22 AM Stefan Kangas <stefankangas@gmail.com> wrote:
>
> Felician Nemeth <felician.nemeth@gmail.com> writes:
>
> > There is an open pull request by Slava Akhmechet in eglot-x that
> > implements a similar feature for clangd and ccls (which uses a differnet
> > LSP extension) [1].  There I wondered its compatibility with the
> > built-in hide-ifdef-mode.
> >
> > Slava originally sent the pull request to the Eglot's repository [2],
> > but João said "Eglot is, by design, only for LSP nor for extensions to
> > the protocol."
>
> I see the logic in João's arguments for wanting to limit eglot.el to the
> LSP standard only.  But then the natural question is: where does
> functionality covering LSP extensions belong?
>
> One option is to have separate packages for every LSP extension out
> there, or indeed a catch-all like eglot-x.el.  Maybe this is okay.
> However, does Eglot's design goals really mean that we will _never_ want
> these features in Emacs core?  I'm not so sure.
>
> This is why I'm proposing to submit the new clangd-inactive-regions
> package to GNU ELPA instead.  That way we could more easily integrate
> this into Emacs later (i.e. without having to worry about copyright
> assignments).  We would still need to figure some things out, of course,
> such as where this functionality goes: to some new `eglot-extras.el', to
> various major modes, or what.
>
> Regarding eglot-x.el, of which you Felician seems to be the only major
> contributor, I would actually say the exact same thing.  Why isn't this
> package on GNU ELPA?  I suggest that you to submit it.  :-)
>
> I'm copying in João, in case he has anything to add here.

Thanks everyone for the feedback!

Before creating this package I had some discussion about this with
João, don't remember if it was in debbugs or here.
His stance then too was that this was server specific and did not
belong in eglot.
The output from that discussion was adding a section into eglot
manual[1] that describes how to extend eglot using this very same use
case as an example.
If one wanted to just use the shadow face the code is all there and
it's the same I'm using.

Most of the code in my package is for the trick to darken the inactive
regions after fontification. But I'd say a proper opacity attribute
would be way more suited to emacs core than my ugly hack :-)

About GNU ELPA, I can look into it, could you send the paperwork
off-list? I'm ok with it as long as I don't need to involve my
employer.


1. https://joaotavora.github.io/eglot/#Extending-Eglot-1