From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Troels Nielsen Newsgroups: gmane.emacs.devel Subject: Re: special_mtime Date: Wed, 4 Jul 2012 21:45:17 +0200 Message-ID: References: <83ehor4j9p.fsf@gnu.org> <4FF4796A.3080409@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1341431131 18579 80.91.229.3 (4 Jul 2012 19:45:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 Jul 2012 19:45:31 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 04 21:45:30 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SmVVx-0008Ga-Ox for ged-emacs-devel@m.gmane.org; Wed, 04 Jul 2012 21:45:29 +0200 Original-Received: from localhost ([::1]:60911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmVVw-00021L-Op for ged-emacs-devel@m.gmane.org; Wed, 04 Jul 2012 15:45:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmVVt-00021G-OJ for emacs-devel@gnu.org; Wed, 04 Jul 2012 15:45:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmVVs-0006nT-5h for emacs-devel@gnu.org; Wed, 04 Jul 2012 15:45:25 -0400 Original-Received: from mail-qa0-f41.google.com ([209.85.216.41]:53564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmVVo-0006kd-SX; Wed, 04 Jul 2012 15:45:21 -0400 Original-Received: by qabg27 with SMTP id g27so3843851qab.0 for ; Wed, 04 Jul 2012 12:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EkypABAt3M0MEcV5ZCu1oKK/gfxt8uUZHUl+3v4M1dw=; b=F63DYJn+g0qGeTEuLwN8doMFmjj7Bw1oaqPAimiPxTHLD5Qyf6VwQ3u4/vk8+MSKJH DvxSxUDbElNGYI5FdQnOfNHccFRKboGaFznQJ/82MZ7KEgNFwEDUJK+/XmDrmrwbsU/e d3hYhr5/yFVVA5Spt3EonmMkK8SrwHo9jn7ZO4jWA2ETJ6h659ngCsp7+TdjQjXZgQGf ErUR0w5Hs1BquAsT38Q7l+r3zUKiXK0LkDqyFouvvzq0gSwczCkpOw7TDfgSbKK/UAW2 OcbOjpjsbCx+LPmjFiu5lI1+waOPT2OL85W/hfOHWoKrqx5geAwwDS12eyLPYaY0bsWZ UDbw== Original-Received: by 10.229.134.203 with SMTP id k11mr11720866qct.146.1341431117361; Wed, 04 Jul 2012 12:45:17 -0700 (PDT) Original-Received: by 10.229.88.143 with HTTP; Wed, 4 Jul 2012 12:45:17 -0700 (PDT) In-Reply-To: <4FF4796A.3080409@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151426 Archived-At: On Wed, Jul 4, 2012 at 7:12 PM, Paul Eggert wrote: > On 07/04/2012 08:51 AM, Eli Zaretskii wrote: >> How about a better name that somehow hints at what the function does, > > Thanks for catching that. I changed it to time_error_value. > If you think of a better name please feel free to change it again. > Hi Paul +/* Return a special mtime value indicating the error number ERRNUM. */ +static EMACS_TIME +special_mtime (int errnum) +{ + EMACS_TIME t; + int ns = (errno == ENOENT || errno == EACCES || errno == ENOTDIR + ? NONEXISTENT_MODTIME_NSECS + : UNKNOWN_MODTIME_NSECS); + EMACS_SET_SECS_NSECS (t, 0, ns); + return t; +} Shouldn't errno be errnum here? Regards Troels Nielsen