From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Tue, 31 Dec 2024 12:29:08 -0600 Message-ID: References: <87ldx0vufd.fsf@sebasmonia.com> <8fde5a67-f778-f0c8-bcdd-ece08c95d369@gmail.com> <87h67nm4su.fsf@sebasmonia.com> <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> <36a57a48-76ab-4254-b3bc-af1fff2d9b98@app.fastmail.com> <87ttb9k04u.fsf@sebasmonia.com> <86wmfkt6ei.fsf@gnu.org> <39071ad9-a369-2e2f-aa1c-779f8103b566@gmail.com> <87cyh8z9tg.fsf@sebasmonia.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006b5a30062a951b9e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14276"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , Eli Zaretskii , emacs-devel To: =?UTF-8?B?U2ViYXN0acOhbiBNb27DrWE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 19:30:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSh0I-0003Xh-SB for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 19:30:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSgzb-0004VS-V6; Tue, 31 Dec 2024 13:29:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSgza-0004VI-6C for emacs-devel@gnu.org; Tue, 31 Dec 2024 13:29:22 -0500 Original-Received: from mail-qv1-f53.google.com ([209.85.219.53]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSgzY-00006Y-Hu; Tue, 31 Dec 2024 13:29:21 -0500 Original-Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6d89a727a19so98292576d6.0; Tue, 31 Dec 2024 10:29:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735669759; x=1736274559; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YxC6QAsz2LTfeI2FjupQnmmGYS5VYs8j447LpExVdJ8=; b=SXnFpAkeK1uoS0qIzDqSE12SEU8gbzci0RlLD4EOearJo8E/daCbNk4YYfWySCpXUl 3W0r7gDVhcvDyt2mc+pDClkWssMw4hsTviiUnr5KRW/+jkL6I8NUec1QPiK1VGt0ppZP RW7HEL3tyDJSHuIP98XqA/I0u8vFkVAC1uLKPqecn4qrh223Qfw72A/S8RNsO+xMcigo ZrCzWAvVk+Ddlcpqp4ZWdcHSkfeBlQjcY2kNOdDhLxrNU5Z34aBRFOcjI1lM+B3m7P46 Dc8DzxuScvjj6YQE1yHo6obnyoMe5AWf5COA/lw4VY/EKMIvdiuRdc+XzO0DyZTTxSBX GLww== X-Forwarded-Encrypted: i=1; AJvYcCUR/KWThiQzOtblfKQpKl2RoKRrJU2o2h6lLd+k8RuV9ViieCX0Blo+wlgul+98YoDoaxpZ@gnu.org, AJvYcCUtXTqg2P51N+QNkR58YRy7VYSwaiTyr09wGeJvctXSGCzX1Ya3wEYgirYmXCQYHF1riAgBSGdrHiaFErA=@gnu.org X-Gm-Message-State: AOJu0YwxmEANMWW4RyJbMJzczsdoPsWmvsQQL8ANY9+QYSH4DVWUiHjo WIoI7pj4VfIiB037nAD83eAK/kH3s7km7c6xhkXSfST2Q0+ZcSDu7pQQl98rvnyhtJ1WZ6wfDvS jyiWCos2Cu3ebc6w2CST1sykJYUc= X-Gm-Gg: ASbGncv5wp0bCDxIUhU3OpcyHEO2nusMw+W5idI9OEeZhzGXSrCiEyHg4zMTDZkwjyl 4F+BznS912cWbdLDxt53CL3JtEamJgzKWR9YE6U+RBOY9wiany7eWbu34v0Qa4sQT4SG8WehX X-Google-Smtp-Source: AGHT+IEUDSdRqFO4yg+vNgbaTLtCQQVCaRVjhgLPtizekRQMkA/JXL1rpLEYodledHmMBpscwl/xdAKjxLCzuGrUCKA= X-Received: by 2002:a05:6214:21ca:b0:6d8:a3f2:4cc with SMTP id 6a1803df08f44-6dd2358136dmr650670186d6.5.1735669758776; Tue, 31 Dec 2024 10:29:18 -0800 (PST) In-Reply-To: <87cyh8z9tg.fsf@sebasmonia.com> Received-SPF: pass client-ip=209.85.219.53; envelope-from=alphadeltapapa@gmail.com; helo=mail-qv1-f53.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.199, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327535 Archived-At: --0000000000006b5a30062a951b9e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable FWIW, I'd recommend using the vtable printer function, as described earlier, so the real records/values can be used and compared as-is. (Apologies if I was unclear earlier, as I thought that was what was already being done.) But I don't have time to contribute code to this patch now, so that's just my recommendation. Also FWIW, I think the long-term goal ought to be to replace EWW's bespoke bookmarks with Emacs bookmarks (i.e. any Emacs bookmark to an HTTP(S) URL ought to be usable by EWW, and it ought to create such bookmarks; EWW should be just another way of opening them). So it would probably be best if the work done could be designed with an eye towards reuse (i.e. using a printer function would mean that the underlying data type could be swapped out later, so this could be just a view of Emacs bookmarks that point to HTTP URLs). My two cents. I won't try to hold up any work or merging for it. Thanks, Adam On Mon, Dec 30, 2024, 23:43 Sebasti=C3=A1n Mon=C3=ADa wrote: > Jim Porter writes: > > > On 12/28/2024 3:04 AM, Eli Zaretskii wrote: > >> Ping! Can we please make some progress here? > > > > In the interest of making progress on this, does anyone have any > > *objections* to this patch? How about we wait a few days for anyone > > with objections to make them known, and if not, we just merge the > > current patch? > > > > Once we do that, we can announce the change in a new thread on this > > list just to give people another chance to raise any objections. > Hi all, > > I am open to comments, suggestions, as mentioned in my last reply. > > I still don't think it is worth it to re-use the bookmark list, but if > there's consensus to change, I will do it. > > Thanks everyone, > Seb > > -- > Sebasti=C3=A1n Mon=C3=ADa > https://site.sebasmonia.com/ > --0000000000006b5a30062a951b9e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

FWIW, I'd recommend using the vtable p= rinter function, as described earlier, so the real records/values can be us= ed and compared as-is. (Apologies if I was unclear earlier, as I thought th= at was what was already being done.)=C2=A0 But I don't have time to con= tribute code to this patch now, so that's just my recommendation.

<= p dir=3D"ltr">Also FWIW, I think the long-term goal ought to be to replace = EWW's bespoke bookmarks with Emacs bookmarks (i.e. any Emacs bookmark t= o an HTTP(S) URL ought to be usable by EWW, and it ought to create such boo= kmarks; EWW should be just another way of opening them).=C2=A0 So it would = probably be best if the work done could be designed with an eye towards reu= se (i.e. using a printer function would mean that the underlying data type = could be swapped out later, so this could be just a view of Emacs bookmarks= that point to HTTP URLs).

My two cents. I won't try = to hold up any work or merging for it.=C2=A0

Thanks,=C2= =A0

Adam


On Mon, Dec 30, 2024, 23:43 Sebasti=C3=A1n Mo= n=C3=ADa <sebastian@sebasmon= ia.com> wrote:
Jim Porter <jporterbugs@gmail.com> writes:

> On 12/28/2024 3:04 AM, Eli Zaretskii wrote:
>> Ping!=C2=A0 Can we please make some progress here?
>
> In the interest of making progress on this, does anyone have any
> *objections* to this patch? How about we wait a few days for anyone > with objections to make them known, and if not, we just merge the
> current patch?
>
> Once we do that, we can announce the change in a new thread on this > list just to give people another chance to raise any objections.
Hi all,

I am open to comments, suggestions, as mentioned in my last reply.

I still don't think it is worth it to re-use the bookmark list, but if<= br> there's consensus to change, I will do it.

Thanks everyone,
Seb

--
Sebasti=C3=A1n Mon=C3=ADa
https://site.sebasmonia.com/
--0000000000006b5a30062a951b9e--