Re: [PATCH] Use vtable for eww-bookmarks

[Adam Porter <adam@alphapapa.net>]

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]

FWIW, I'd recommend using the vtable printer function, as described
earlier, so the real records/values can be used and compared as-is.
(Apologies if I was unclear earlier, as I thought that was what was already
being done.)  But I don't have time to contribute code to this patch now,
so that's just my recommendation.

Also FWIW, I think the long-term goal ought to be to replace EWW's bespoke
bookmarks with Emacs bookmarks (i.e. any Emacs bookmark to an HTTP(S) URL
ought to be usable by EWW, and it ought to create such bookmarks; EWW
should be just another way of opening them).  So it would probably be best
if the work done could be designed with an eye towards reuse (i.e. using a
printer function would mean that the underlying data type could be swapped
out later, so this could be just a view of Emacs bookmarks that point to
HTTP URLs).

My two cents. I won't try to hold up any work or merging for it.

Thanks,

Adam

On Mon, Dec 30, 2024, 23:43 Sebastián Monía <sebastian@sebasmonia.com>
wrote:

> Jim Porter <jporterbugs@gmail.com> writes:
>
> > On 12/28/2024 3:04 AM, Eli Zaretskii wrote:
> >> Ping!  Can we please make some progress here?
> >
> > In the interest of making progress on this, does anyone have any
> > *objections* to this patch? How about we wait a few days for anyone
> > with objections to make them known, and if not, we just merge the
> > current patch?
> >
> > Once we do that, we can announce the change in a new thread on this
> > list just to give people another chance to raise any objections.
> Hi all,
>
> I am open to comments, suggestions, as mentioned in my last reply.
>
> I still don't think it is worth it to re-use the bookmark list, but if
> there's consensus to change, I will do it.
>
> Thanks everyone,
> Seb
>
> --
> Sebastián Monía
> https://site.sebasmonia.com/
>

[-- Attachment #2: Type: text/html, Size: 2506 bytes --]