unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lee Duhem <lee.duhem@gmail.com>
To: Emacs Devel <emacs-devel@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: [PATCH] * lisp.h (USE_LSB_TAG): Sync comment with code
Date: Fri, 28 Nov 2014 17:08:18 +0800	[thread overview]
Message-ID: <CAOSer0DM6pn84W_m63_o5F+DCF9QNSBDXkc71+dZS1vnCtHCwg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

Hi,

In `lisp.h', the comment before `USE_LSB_TAG' does not match
the actual code, this patch fixes that. You may want to take a look.

Sincerely,
lee

[-- Attachment #2: 0001-lisp.h-USE_LSB_TAG-Sync-comment-with-code.patch --]
[-- Type: text/x-patch, Size: 1222 bytes --]

From 4ce73b19ca0032b0cfbdd5b8dee0ca07010d3c17 Mon Sep 17 00:00:00 2001
From: Lee Duhem <lee.duhem@gmail.com>
Date: Tue, 25 Nov 2014 09:54:37 +0800
Subject: [PATCH] * lisp.h (USE_LSB_TAG): Sync comment with code.

---
 src/lisp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lisp.h b/src/lisp.h
index bdff019..94c524a 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -261,7 +261,8 @@ enum Lisp_Bits
 #define VAL_MAX (EMACS_INT_MAX >> (GCTYPEBITS - 1))
 
 /* Whether the least-significant bits of an EMACS_INT contain the tag.
-   On hosts where pointers-as-ints do not exceed VAL_MAX, USE_LSB_TAG is:
+   On hosts where pointers-as-ints do not exceed EMACS_INT_MAX >> GCTYPEBITS,
+   USE_LSB_TAG is:
     a. unnecessary, because the top bits of an EMACS_INT are unused, and
     b. slower, because it typically requires extra masking.
    So, USE_LSB_TAG is true only on hosts where it might be useful.  */
@@ -272,7 +273,6 @@ DEFINE_GDB_SYMBOL_END (USE_LSB_TAG)
 #if !USE_LSB_TAG && !defined WIDE_EMACS_INT
 # error "USE_LSB_TAG not supported on this platform; please report this." \
 	"Try 'configure --with-wide-int' to work around the problem."
-error !;
 #endif
 
 #ifndef alignas
-- 
1.9.3


             reply	other threads:[~2014-11-28  9:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28  9:08 Lee Duhem [this message]
2014-11-28 13:05 ` [PATCH] * lisp.h (USE_LSB_TAG): Sync comment with code Andreas Schwab
2014-11-29  7:40   ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOSer0DM6pn84W_m63_o5F+DCF9QNSBDXkc71+dZS1vnCtHCwg@mail.gmail.com \
    --to=lee.duhem@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).