From: Lee Duhem <lee.duhem@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Andreas Schwab <schwab@suse.de>, emacs-devel@gnu.org
Subject: Re: Why do Fdefvar not protect its argument and temporaries with GCPRO?
Date: Thu, 20 Nov 2014 10:59:28 +0800 [thread overview]
Message-ID: <CAOSer0C3wBOkwKO0DGZsYonumxMRcjuSe2J-2UCbs18CSzLLOQ@mail.gmail.com> (raw)
In-Reply-To: <jwvoas3fglo.fsf-monnier+emacs@gnu.org>
On Wed, Nov 19, 2014 at 5:51 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> I think a few of them do too much GCPRO, since arguments of lisp
>> functions are protected by the caller (and conses are not relocated).
>
> Maybe I'm misunderstanding what you're saying, but to clarify:
> The calling convention we use does not require the caller to
> gcprotect the arguments, instead it's the callee who should protect its
> own arguments, if and when needed.
Thank both of you for your explanation.
>
>>> Is this a bug?
>> In this case, I think it is.
>
> Agreed.
>
I have send a patch for this.
Sincerely,
lee
prev parent reply other threads:[~2014-11-20 2:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 2:48 Why do Fdefvar not protect its argument and temporaries with GCPRO? Lee Duhem
2014-11-19 9:44 ` Andreas Schwab
2014-11-19 13:51 ` Stefan Monnier
2014-11-20 2:59 ` Lee Duhem [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOSer0C3wBOkwKO0DGZsYonumxMRcjuSe2J-2UCbs18CSzLLOQ@mail.gmail.com \
--to=lee.duhem@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).