From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?4KS44KSu4KWA4KSwIOCkuOCkv+CkguCkuSBTYW1lZXIgU2luZ2g=?= Newsgroups: gmane.emacs.devel Subject: Re: Implementing Vertical Text support in Emacs Date: Sun, 20 Nov 2022 17:38:05 +0530 Message-ID: References: <83r13sttj6.fsf@gnu.org> <87wndi6xau.fsf@yahoo.com> <83mtebq0nd.fsf@gnu.org> <838rmtelfg.fsf@gnu.org> <83leqr9pb4.fsf@gnu.org> <83v8p5e5mt.fsf@gnu.org> <83ilj96ec6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003f74c805ede5cb9c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31245"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 20 13:09:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owj8H-0007wh-GY for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Nov 2022 13:09:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owj7X-0002gp-F2; Sun, 20 Nov 2022 07:08:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owj7V-0002gd-0U for emacs-devel@gnu.org; Sun, 20 Nov 2022 07:08:21 -0500 Original-Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owj7T-00075D-2v; Sun, 20 Nov 2022 07:08:20 -0500 Original-Received: by mail-pj1-x1035.google.com with SMTP id a1-20020a17090abe0100b00218a7df7789so1059388pjs.5; Sun, 20 Nov 2022 04:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=R+m5URIGPR+bVnbbgvlM8r8DilrXHicn8pP28BFiTgk=; b=R4C6xmdiqmcUOFdwpM5C1ya3vOp8yjKe8dqivnbxbodhH2hBDiNUltxT32Ul9Yj8HX cbSzMrIIqJpmT79d30i+7Vijj1YsZacDBfnTaWlukyDoVOhvTMLCmOWseX1kSSjM36xp cmjV7clVtJhoMRZjDMsqH9Swe0kihxKAh4tQt/sifdPa67XKfvdcOKYUHs2kfY3yMJrG RfM9NU7GlWMkC8/zay4wGjJX1oESJReB1cfleZ/6q2Tp3t7Maq89WeDtWbe+AEJXhBOr AHC56HhzrUw9p2//ZFCHdiUjvOsVdZOg62aLCFs1rKylkqVdAV/6ahsGLbyD1RBOCyen DyiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R+m5URIGPR+bVnbbgvlM8r8DilrXHicn8pP28BFiTgk=; b=t1kQ9bpSr2QnhgLQbJQuy+KqWAUSjqsUTcuJ7HSwPNclENYuiDqU8fdy1Qs27Ykfkb wXyIFUdjAGNVmJiX1ES3qL4VhmK3JaOtuM1U41zZGCvsFaOBaqUY5Nff6dvs7GyRhcaJ 4cYygyhKLPdL8qiMHClS3MDSmRkvfCfqqyHatAN6HPw17DKpY7Pf/ZJtYeN75hakECWH GQBYHkAMNY9OISRSeK5P6LxhExeNDdra7O8Vt/MxIE/nnTS8oV9RkNTzsLrSdfnyngJQ feUhuHgbl5Y9xdhoioMsrweT+tNcndIoZ6ko2Hmj/jnARttsEoOQpReS0MDcaEC1Q/Z6 nrvw== X-Gm-Message-State: ANoB5pk5RXCiRzYJIauEnWe+QBIKUDItdl8T3Ebh+tkS4zxEkMetxQSY AdiuW8e68leB4l4KM44WKuHOI3E0nN00fqul6YgYV7p3hy0= X-Google-Smtp-Source: AA0mqf7otu9HsulhhO6nsvvG1l3KbL1nvnjaoaWq3wPxKOI+mGkdCKZ2DrmaCSbtBJquGUqk8lAsKjxWnmtVCfOHAnw= X-Received: by 2002:a17:902:f78a:b0:188:a51c:b570 with SMTP id q10-20020a170902f78a00b00188a51cb570mr7594409pln.7.1668946096779; Sun, 20 Nov 2022 04:08:16 -0800 (PST) In-Reply-To: <83ilj96ec6.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=lumarzeli30@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300242 Archived-At: --0000000000003f74c805ede5cb9c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > I'm not sure I understand the question. Are you saying that if you ignor= e > the line overflow, termination of a line, etc., you can write code that > does > display characters column-wise? I thought that displaying line row wise is the "base" of the display_line function with code for line truncation, overflow, bidi etc added on top of it in "if" blocks, so if I could just get the base to work (i.e. displaying lines in a column) then I could work on the the finer details. Am I wrong? In any case, it is hard to discuss this without seeing the code which > doesn't work. Is the code you wrote available anywhere for review? > Unfortunately it is no longer available. One line which I remember causing a problem though was line 24500 in src/xdisp.c row->y =3D it->current_y; if I changed it to: row->x =3D it->current_x; Emacs no longer displays characters. On Sun, Nov 20, 2022 at 5:13 PM Eli Zaretskii wrote: > > From: =E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0 =E0=A4=B8=E0=A4=BF=E0=A4=82= =E0=A4=B9 Sameer Singh > > Date: Sun, 20 Nov 2022 16:48:31 +0530 > > Cc: emacs-devel@gnu.org > > > > I tried writing a vertical version of the display_line function but > could not get it to work. Emacs does not > > display any character after these changes. > > (maybe I should have also rewrote move_it_in_display_line_to?) > > I don't think move_it_in_display_line_to is relevant at this early stage = of > your work. > > > Therefore forgive me for asking again, if for now I just want to make > the characters appear column wise > > instead of row wise, disregarding line overflow, or termination of a > line etc, > > do I still have to look into the display_line function, because as I > recall I had once removed most of the lines > > of the display_line function and Emacs was still displaying lines fines= . > > I'm not sure I understand the question. Are you saying that if you ignor= e > the line overflow, termination of a line, etc., you can write code that > does > display characters column-wise? > > In any case, it is hard to discuss this without seeing the code which > doesn't work. Is the code you wrote available anywhere for review? > --0000000000003f74c805ede5cb9c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm = not sure I understand the question.=C2=A0 Are you saying that if you ignore=
the line overflow, termination of a line, etc., you can write code that doe= s
display characters column-wise?

I thought t= hat displaying line row wise is the "base" of the display_line fu= nction with code for
line truncation, overflow, bidi etc added on= top of it in "if" blocks, so if I could just get the base to wor= k (i.e. displaying lines in a column)
then I could work on the th= e finer details.
Am I wrong?

In any case, it is hard to discu= ss this without seeing the code which
doesn't work.=C2=A0 Is the code you wrote available anywhere for review= ?

Unfortunately it is no longer avail= able.
One line which I remember causing a problem though was line= 24500 in src/xdisp.c
row->y =3D it->current_y;
i= f I changed it to: row->x =3D it->current_x; Emacs no longer displays= characters.
=C2=A0

On Sun, Nov 20, 2022 at 5:13 PM = Eli Zaretskii <eliz@gnu.org> wrot= e:
> From: = =E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0 =E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9 S= ameer Singh <= lumarzeli30@gmail.com>
> Date: Sun, 20 Nov 2022 16:48:31 +0530
> Cc: emacs-dev= el@gnu.org
>
> I tried writing a vertical version of the display_line function but co= uld not get it to work. Emacs does not
> display any character after these changes.
> (maybe I should have also rewrote move_it_in_display_line_to?)

I don't think move_it_in_display_line_to is relevant at this early stag= e of
your work.

> Therefore forgive me for asking again, if for now I just want to make = the characters appear column wise
> instead of row wise, disregarding line overflow, or termination of a l= ine etc,
> do I still have to look into the display_line function, because as I r= ecall I had once removed most of the lines
> of the display_line function and Emacs was still displaying lines fine= s.

I'm not sure I understand the question.=C2=A0 Are you saying that if yo= u ignore
the line overflow, termination of a line, etc., you can write code that doe= s
display characters column-wise?

In any case, it is hard to discuss this without seeing the code which
doesn't work.=C2=A0 Is the code you wrote available anywhere for review= ?
--0000000000003f74c805ede5cb9c--