From: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Implementing Vertical Text support in Emacs
Date: Sun, 20 Nov 2022 17:38:05 +0530 [thread overview]
Message-ID: <CAOR1sLw3is-54mJv08hOyOZftk3uQAFpE7t_c+1zfM7xZYLqvQ@mail.gmail.com> (raw)
In-Reply-To: <83ilj96ec6.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]
>
> I'm not sure I understand the question. Are you saying that if you ignore
> the line overflow, termination of a line, etc., you can write code that
> does
> display characters column-wise?
I thought that displaying line row wise is the "base" of the display_line
function with code for
line truncation, overflow, bidi etc added on top of it in "if" blocks, so
if I could just get the base to work (i.e. displaying lines in a column)
then I could work on the the finer details.
Am I wrong?
In any case, it is hard to discuss this without seeing the code which
> doesn't work. Is the code you wrote available anywhere for review?
>
Unfortunately it is no longer available.
One line which I remember causing a problem though was line 24500 in
src/xdisp.c
row->y = it->current_y;
if I changed it to: row->x = it->current_x; Emacs no longer displays
characters.
On Sun, Nov 20, 2022 at 5:13 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sun, 20 Nov 2022 16:48:31 +0530
> > Cc: emacs-devel@gnu.org
> >
> > I tried writing a vertical version of the display_line function but
> could not get it to work. Emacs does not
> > display any character after these changes.
> > (maybe I should have also rewrote move_it_in_display_line_to?)
>
> I don't think move_it_in_display_line_to is relevant at this early stage of
> your work.
>
> > Therefore forgive me for asking again, if for now I just want to make
> the characters appear column wise
> > instead of row wise, disregarding line overflow, or termination of a
> line etc,
> > do I still have to look into the display_line function, because as I
> recall I had once removed most of the lines
> > of the display_line function and Emacs was still displaying lines fines.
>
> I'm not sure I understand the question. Are you saying that if you ignore
> the line overflow, termination of a line, etc., you can write code that
> does
> display characters column-wise?
>
> In any case, it is hard to discuss this without seeing the code which
> doesn't work. Is the code you wrote available anywhere for review?
>
[-- Attachment #2: Type: text/html, Size: 3106 bytes --]
next prev parent reply other threads:[~2022-11-20 12:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 15:29 Implementing Vertical Text support in Emacs समीर सिंह Sameer Singh
2022-06-13 16:16 ` [External] : " Drew Adams
2022-06-13 16:30 ` Eli Zaretskii
2022-06-15 10:08 ` Richard Stallman
2022-06-15 10:22 ` Po Lu
2022-06-15 11:09 ` समीर सिंह Sameer Singh
2022-06-16 22:48 ` Richard Stallman
2022-06-17 1:43 ` समीर सिंह Sameer Singh
2022-06-17 6:12 ` Eli Zaretskii
2022-09-08 18:44 ` समीर सिंह Sameer Singh
2022-09-08 19:05 ` Eli Zaretskii
2022-09-10 15:53 ` समीर सिंह Sameer Singh
2022-09-10 16:17 ` Eli Zaretskii
2022-09-29 19:57 ` समीर सिंह Sameer Singh
2022-09-30 6:30 ` Eli Zaretskii
2022-11-20 11:18 ` समीर सिंह Sameer Singh
2022-11-20 11:43 ` Eli Zaretskii
2022-11-20 12:08 ` समीर सिंह Sameer Singh [this message]
2022-11-24 11:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOR1sLw3is-54mJv08hOyOZftk3uQAFpE7t_c+1zfM7xZYLqvQ@mail.gmail.com \
--to=lumarzeli30@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).