From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?VHXhuqVuLUFuaCBOZ3V54buFbg==?= Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter api Date: Fri, 17 Sep 2021 20:39:27 +0700 Message-ID: References: <83r1f7hydn.fsf@gnu.org> <83r1dselyo.fsf@gnu.org> <6A4CE984-6ACE-4E66-8EF2-F3D351C02248@gmail.com> <83r1dscpt2.fsf@gnu.org> <83o88wcof9.fsf@gnu.org> <83lf3zdh4z.fsf@gnu.org> <8965C4A0-79D3-4D77-A6BA-D07A6C93F7FE@gmail.com> <83ilz3cs4k.fsf@gnu.org> <04D19C1A-CD64-4156-B932-1C9FEEE4EC7B@gmail.com> <83zgsebc0r.fsf@gnu.org> <1F752923-F357-4A18-B6E2-0120F1B9BD37@gmail.com> <83fsu5bzem.fsf@gnu.org> <83zgsdad5j.fsf@gnu.org> <83sfy391ni.fsf@gnu.org> <03386E3C-A975-4ECD-BF89-6AC62F751725@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23886"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , Theodor Thornhill , =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= , Emacs developers , Eli Zaretskii , Stephen Leake To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 17 15:42:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRE82-0005wS-AE for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Sep 2021 15:42:10 +0200 Original-Received: from localhost ([::1]:33462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRE7z-0004oG-RK for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Sep 2021 09:42:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRE5j-0003IR-6G for emacs-devel@gnu.org; Fri, 17 Sep 2021 09:39:47 -0400 Original-Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:42850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRE5h-0006FJ-PB; Fri, 17 Sep 2021 09:39:46 -0400 Original-Received: by mail-pj1-x1031.google.com with SMTP id p12-20020a17090adf8c00b0019c959bc795so1817045pjv.1; Fri, 17 Sep 2021 06:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mKNVhIFPtMFFuoF3UDWJIRPQVqvvY49TIdjw7wSRKaE=; b=K+P+QXTIE7e7nm6JHcd2RFR7PlnOb3uHeHLBsp2Q9ZSOrOoFrbm19lFQRx6rTLryq6 wGUwnX2m8tcEWNZ+q5Jjg1hJsRljy5FqGQEK81F7G2aMvu0x4ouEgUIlxW0tpWxO/iCt fzjynTwMZCxC7YCy8r13ZOYCz5adwuuKkaXrvEHhW7zEzelwxPHG3/1kk1QAp8GtHmP0 VLiGzOa9BVkai8N3tqxTs2H8FoKyAce2oqjE3J0EMfb8UggxUw1+Oo26WeOlk75Ejyz8 YvdENbG37LUULXxnenHJdUFF1my0IDLuU3fpI7aH4sbPkapAKgyb3jbUxySil8GHTJcY 9Vew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mKNVhIFPtMFFuoF3UDWJIRPQVqvvY49TIdjw7wSRKaE=; b=KgWz9WCfG8p/9fbU4TMsoGfNxZHTEm0IvFm9Pyq7Hh2vPQ40Ug/xTgpiVQ9lUm+aRZ kJGtn0mJRvsPGboSjPRZjNDyPWjOtE6JtnY4s0A7+fqBdX4+G9VGUShFDeWF6oGoyHRd V4kqnNY2EKOnD/X2hZZhnPvytI0ECFryYc8adILzuLP8KttXWPlR/ht+w/bYTzRlzPtI /dCd+arDn9H4Puz2S1vlH6TL65gnStlz50WqgH+uzgINyAYLVrblRbNVYQSy5JK8guL7 WjornO6hfJPRxhvxxH4rsuHC54sPOAIkNfiL8ho0OYdwjCgUFcjfPVcvYMjXXL6euC8d zEKg== X-Gm-Message-State: AOAM533dRjBejGJpRbks2ZlBaBBiq9Aj9jlGQWDphBWlaMdFB3PD0mGh Kx819Ze3/9Wz9Fcrbm6e5u3wiGGKK2ypD4rhUNE= X-Google-Smtp-Source: ABdhPJxXR7vfh4TsfJDDj6oTuwgIFT9g3oLG7kJBRoq720YAejOFU2OFUdkHpTSMsRFHygkhiDnmqAOrNhip4t03+5w= X-Received: by 2002:a17:90a:d312:: with SMTP id p18mr12279278pju.64.1631885983809; Fri, 17 Sep 2021 06:39:43 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=ubolonton@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274874 Archived-At: On Fri, Sep 17, 2021 at 8:14 PM Stefan Monnier w= rote: > Why not just `tree-sitter-language-name` which the major mode can set > buffer-locally. > > (setq-local tree-sitter-language-name 'foo) > > is better than > > (add-to-list 'tree-sitter-major-mode-language-alist '(foo-mode . foo)= ) It can be both, with one being the underlying mechanism for the other. (Tha= t's what I do in my packages.) The alist is a central place that's more conveni= ent for users (not mode writers) to customize, e.g. in case a major mode hasn't added itself yet: (add-hook 'foo-mode-hook (lambda () (setq tree-sitter-language-name 'fo= o))) is less convenient than (add-to-list 'tree-sitter-major-mode-language-alist '(foo-mode . foo)) > [ Among other things because it won't signal an error when > `tree-sitter.el` is not loaded. ] We can make `tree-sitter-major-mode-language-list` autoloaded. --=20 Tu=E1=BA=A5n-Anh Nguy=E1=BB=85n Software Engineer