unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Evgeny Zajcev <lg.zevlg@gmail.com>
To: Alan Third <alan@idiocy.org>, Evgeny Zajcev <lg.zevlg@gmail.com>,
	 emacs-devel <emacs-devel@gnu.org>
Subject: Re: Image transformation filter for upscaled images
Date: Mon, 8 Mar 2021 01:35:50 +0300	[thread overview]
Message-ID: <CAO=W_ZriD-q7SQHzUjcwqWD6EAeg4GAUbLAd+agoTrJqqV4Z0g@mail.gmail.com> (raw)
In-Reply-To: <YEU7hwxh8e24wyC2@breton.holly.idiocy.org>

[-- Attachment #1: Type: text/plain, Size: 1949 bytes --]

вс, 7 мар. 2021 г. в 23:46, Alan Third <alan@idiocy.org>:

> On Sun, Mar 07, 2021 at 10:12:43PM +0300, Evgeny Zajcev wrote:
> > Currently, image transformation for upscaled images uses NEAREST filter,
> > which is fast, but renders very bad results for images with text inside.
> >
> > Maybe change it to GOOD, which is also fast, but renders more decent
> results
> >
> > Here is I've got two screenshots showing the difference:
> >
> > NEAREST (currently hardcoded in Emacs) -
> > http://lgarc.narod.ru/pics/upscaled-nearest.png
> >
> > GOOD (my proposal) - http://lgarc.narod.ru/pics/upscaled-good.png
> >
> > What do you think?
>
> See also bug#38394.
>
> The reason nearest was chosen was because scaled up pixel art (emojis,
> mostly, like etc/images/smilies/wry.xpm) looked abominable


In 2k21 any xpm with any filter will look abominable :)

when using
> the "best" filter,



> but most other types of images look OK when using
> nearest.


We (telega.el project) see many images of different kind daily, and only
some of them looks OK when nearest filter is applied. Most of the time,
especially if some contrast diagonals are involved (including character
glyphs) upscaling results are no ok.  Also, doc-view suffers from this,
most pdf files viewed inside Emacs looks no ok.

On the other hand the bug report complains that scaled up
> pixel art looks abominable with nearest, so clearly there's a
> difference of opinion.
>

Just get rid of any xpm :) Emacs has nice support for SVG after all, we can
write xpm to svg converter to keep pixel art precision.

I don't know whether "good" is a better compromise, I suspect it looks
> quite like "best".
>
I don't know what the best option is, I suspect there's no clear
> one-size-fits-all winning strategy.
>

Or maybe we can make the transformation filter configurable, so it could be
changed from elisp side?

-- 
lg

[-- Attachment #2: Type: text/html, Size: 3373 bytes --]

  reply	other threads:[~2021-03-07 22:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 19:12 Image transformation filter for upscaled images Evgeny Zajcev
2021-03-07 20:45 ` Alan Third
2021-03-07 22:35   ` Evgeny Zajcev [this message]
2021-03-07 23:27     ` Stefan Kangas
2021-03-08  0:42       ` Evgeny Zajcev
2021-03-08  2:31         ` Stefan Kangas
2021-03-08 13:34           ` Eli Zaretskii
2021-03-08 13:31       ` Eli Zaretskii
2021-03-08 18:58       ` Alan Third
2021-03-08 19:18         ` Lars Ingebrigtsen
2021-03-08 21:27           ` Alan Third
2021-03-08 21:31             ` Lars Ingebrigtsen
2021-03-08 21:59               ` Alan Third
2021-03-09  8:34                 ` Evgeny Zajcev
2021-03-09  9:28                   ` Alan Third
2021-03-09  9:46                     ` Evgeny Zajcev
2021-03-09 14:16                     ` Stefan Monnier
2021-03-09 13:09                   ` Eli Zaretskii
2021-03-09 13:48                     ` Evgeny Zajcev
2021-03-09 13:59                     ` Lars Ingebrigtsen
2021-03-09 16:37                       ` Eli Zaretskii
2021-03-09 17:04                         ` Lars Ingebrigtsen
2021-03-09 18:01                           ` Eli Zaretskii
2021-03-10  4:23                           ` Yuri Khan
2021-03-10 14:44                             ` Lars Ingebrigtsen
2021-03-09 13:16                   ` Lars Ingebrigtsen
2021-03-09 13:50                     ` Dov Grobgeld
2021-03-09 18:16                       ` Alan Third
2021-03-09 18:12                     ` Alan Third
2021-03-09 22:31                       ` Basil L. Contovounesios
2021-03-09 23:59                         ` Stefan Monnier
2021-03-10 13:37                         ` Alan Third
2021-03-10 14:49                       ` Lars Ingebrigtsen
2021-03-10 21:45                         ` Alan Third
2021-03-11 16:53                           ` Lars Ingebrigtsen
2021-03-12  1:38                           ` Lars Ingebrigtsen
2021-03-12  2:01                             ` Evgeny Zajcev
2021-03-12 18:32                             ` Alan Third
2021-03-08 20:05         ` Evgeny Zajcev
2021-03-08 21:29           ` Alan Third
2021-03-08 13:27     ` Eli Zaretskii
2021-03-07 23:12   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO=W_ZriD-q7SQHzUjcwqWD6EAeg4GAUbLAd+agoTrJqqV4Z0g@mail.gmail.com' \
    --to=lg.zevlg@gmail.com \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).