Re: Buffer local `switch-to-buffer-preserve-window-point'

[Evgeny Zajcev <lg.zevlg@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 912 bytes --]

пн, 30 нояб. 2020 г. в 20:54, Evgeny Zajcev <lg.zevlg@gmail.com>:

>
>
> пн, 30 нояб. 2020 г. в 20:30, martin rudalics <rudalics@gmx.at>:
>
>>  > Ah, sorry, I thought that is in Emacs, but it was from my init.el :)),
>>  > replace with (switch-to-buffer (other-buffer))
>>
>> OK.
>>
>>  > The problem with their buffer local values is that they are used for
>> buffer
>>  > logic *before* buffer is set as current, see `switch-to-buffer'.  We
>> should
>>  > either use `(buffer-local-value NAME buffer)' to get their values in
>>  > `switch-to-buffer',
>>
>> Good idea.  Could you write a patch?
>>
>>
> Sure, here it is
>
> Probably same should be done for `switch-to-buffer-obey-display-actions',
> but at the moment I care more about `switch-to-buffer-preserve-window-point'
>

Sorry, there was a typo: preserver instead of preserve, here is the update

-- 
lg

[-- Attachment #1.2: Type: text/html, Size: 1680 bytes --]

[-- Attachment #2: 0001-Fix-use-of-switch-to-buffer-preserve-window-point.patch --]
[-- Type: text/x-patch, Size: 1418 bytes --]

From 2e25a05e0b9eb3a891be369bc7428fb017d8902f Mon Sep 17 00:00:00 2001
From: Zajcev Evgeny <zevlg@yandex.ru>
Date: Mon, 30 Nov 2020 20:51:18 +0300
Subject: [PATCH 1/2] Fix use of switch-to-buffer-preserve-window-point

* lisp/window.el (switch-to-buffer): Regard buffer local value
for switch-to-buffer-preserve-window-point variable
---
 lisp/window.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lisp/window.el b/lisp/window.el
index 82976bf836..ea3f581a2f 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -8566,13 +8566,13 @@ switch-to-buffer
 
       (when set-window-start-and-point
         (let* ((entry (assq buffer (window-prev-buffers)))
-	       (displayed (and (eq switch-to-buffer-preserve-window-point
-				   'already-displayed)
+               (preserve-win-point
+                (buffer-local-value 'switch-to-buffer-preserve-window-point
+                                    buffer))
+	       (displayed (and (eq preserve-win-point 'already-displayed)
 			       (get-buffer-window buffer 0))))
 	  (set-window-buffer nil buffer)
-	  (when (and entry
-		     (or (eq switch-to-buffer-preserve-window-point t)
-		         displayed))
+	  (when (and entry (or (eq preserve-win-point t) displayed))
 	    ;; Try to restore start and point of buffer in the selected
 	    ;; window (Bug#4041).
 	    (set-window-start (selected-window) (nth 1 entry) t)
-- 
2.25.1