From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.devel Subject: Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property Date: Thu, 17 Dec 2020 01:08:12 +0300 Message-ID: References: <83o8iyerpi.fsf@gnu.org> <83czzdeogx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000002b065705b69c1d2b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30437"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 16 23:09:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpez2-0007pS-5Z for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Dec 2020 23:09:20 +0100 Original-Received: from localhost ([::1]:52702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpez0-0002Rm-4o for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Dec 2020 17:09:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpeyD-00020Q-Pn for emacs-devel@gnu.org; Wed, 16 Dec 2020 17:08:29 -0500 Original-Received: from mail-lf1-f43.google.com ([209.85.167.43]:39937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpeyA-0005Wd-QM; Wed, 16 Dec 2020 17:08:29 -0500 Original-Received: by mail-lf1-f43.google.com with SMTP id m12so52350986lfo.7; Wed, 16 Dec 2020 14:08:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QL86FYzfANkRLF3glvC3XiKNPXf7eJdiqEmOMcBG+Yw=; b=qM4R7Oyr4ypyzpPRjcOo1vuCSC520MtVvEVxaDfbpHvAa9FjmqSMzf8xE080rPOsof nEPgRpwOVUy5kcU7ESRaD2upSxaGbi/ttaPQkaNWku77hnGKXuEpJbx74QD9aK1da0nL nGQ5HKDyf+uZgOhLqNO4QkogU0v+Es5FY55anrpSOg3Iz5zCcmBqfZXOkHw5MfrPgagr gpP4tRTZfx7b5k++q8NjfYxXXVFUux8evNgIwtkLJM0GUw14YZ5t64tDX2KS0kj+uzZN zh5tiaqvtcSDZ0iLtc/ZGlJBEI4fcuIohLiVnqquaJtEl+76vXCTJTWTI57fN8rcOQBK pkxw== X-Gm-Message-State: AOAM5307CQyF8bGSJpwH2+TdL8tbcaTUxW3B37HFF3cn/9Yl4SINgJuj 6s0KlKvUVCUQe3sedJiTZO2yo+sxwfo3jT8LzWummrFA X-Google-Smtp-Source: ABdhPJyfNxcgEb+pL8RDM95MhI+eTZAdlmI7WQTVNto+ncRnnT07wSKn3BxvPaAUDVDVtb4NR19FPn60t22EzrZkdz4= X-Received: by 2002:ac2:5d68:: with SMTP id h8mr13580218lft.448.1608156504059; Wed, 16 Dec 2020 14:08:24 -0800 (PST) In-Reply-To: <83czzdeogx.fsf@gnu.org> Received-SPF: pass client-ip=209.85.167.43; envelope-from=lg.zevlg@gmail.com; helo=mail-lf1-f43.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261072 Archived-At: --0000000000002b065705b69c1d2b Content-Type: multipart/alternative; boundary="0000000000002b065505b69c1d29" --0000000000002b065505b69c1d29 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=B2=D1=81, 13 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 18:05, Eli Zaretsk= ii : > > From: Evgeny Zajcev > > Date: Sat, 12 Dec 2020 23:42:36 +0300 > > Cc: emacs-devel > > > > > > +@defun svg-embed-base-uri-image svg relative-filename &rest args > > > > +To @var{svg} add an embedded (raster) image placed at > > > > +@var{relative-filename}. @var{relative-filename} is searched insi= de > > > > +@code{file-name-directory} of the @code{:base-uri} svg image > property. > > > > > > This is the only place in the manual where the :base-uri attribute is > > > mentioned. Can we please add some minimal description of what that > > > attribute does and how it is useful? > > > > This is only function, where `:base-uri` could be useful > > Then I think its documentation should say something about what a "base > URI" is. > > > > > +This improves the performance of embedding large images. > > > > > > What is "this" that improves the performance, and how does it do so? > > > > > > > "this" - having support for `:base_uri` > > Yes, but _why_ does having the base URI improve the performance? > > > We should at least hint at the improvement, without that this sentence > > > sounds puzzling. > > > > > > > > I'll try my best in rewording this, however take into account that I'm > very > > bad at wording in English. Maybe it is better for someone else to writ= e > > docs for it? > > Just explain it in your words, and I will reword if needed. > > > I'll compose patch you want a bit later > > Thanks in advance. > Here I've composed the patch. As I can see NEWS already fixed --=20 lg --0000000000002b065505b69c1d29 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=D0=B2=D1=81, 13 =D0=B4=D0=B5=D0=BA. = 2020 =D0=B3. =D0=B2 18:05, Eli Zaretskii <eliz@gnu.org>:
> From: Evgeny Zajcev <zevlg@yandex.ru>
> Date: Sat, 12 Dec 2020 23:42:36 +0300
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> > > +@defun svg-embed-base-uri-image svg relative-filename &= rest args
> > > +To @var{svg} add an embedded (raster) image placed at
> > > +@var{relative-filename}.=C2=A0 @var{relative-filename} is s= earched inside
> > > +@code{file-name-directory} of the @code{:base-uri} svg imag= e property.
> >
> > This is the only place in the manual where the :base-uri attribut= e is
> > mentioned.=C2=A0 Can we please add some minimal description of wh= at that
> > attribute does and how it is useful?
>
> This is only function, where `:base-uri` could be useful

Then I think its documentation should say something about what a "base=
URI" is.

> > > +This improves the performance of embedding large images. > >
> > What is "this" that improves the performance, and how d= oes it do so?
> >
>
> "this" - having support for `:base_uri`

Yes, but _why_ does having the base URI improve the performance?

> We should at least hint at the improvement, without that this sentence=
> > sounds puzzling.
> >
> >
> I'll try my best in rewording this, however take into account that= I'm very
> bad at wording in English.=C2=A0 Maybe it is better for someone else t= o write
> docs for it?

Just explain it in your words, and I will reword if needed.

> I'll compose patch you want a bit later

Thanks in advance.

Here I've composed the patch.=C2= =A0 As I can see NEWS already fixed


--
lg
--0000000000002b065505b69c1d29-- --0000000000002b065705b69c1d2b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Improvements-for-base-uri-svg-image-property.patch" Content-Disposition: attachment; filename="0001-Improvements-for-base-uri-svg-image-property.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kirytovv0 RnJvbSA0NzI4OGFkMTIwM2M3ZmUzYjU4ZThiZGFiNDZjNDkzMmQzNzE1MGRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBaYWpjZXYgRXZnZW55IDx6ZXZsZ0B5YW5kZXgucnU+CkRhdGU6 IFRodSwgMTcgRGVjIDIwMjAgMDE6MDQ6MDkgKzAzMDAKU3ViamVjdDogW1BBVENIXSBJbXByb3Zl bWVudHMgZm9yIGA6YmFzZS11cmknIHN2ZyBpbWFnZSBwcm9wZXJ0eQoKKiBzcmMvaW1hZ2UuYyAo c3ZnX2xvYWQpOiBVc2UgRU5DT0RFX0ZJTEUgZm9yIGA6YmFzZS11cmknCgoqIGRvYy9saXNwcmVm L2Rpc3BsYXkudGV4aTogQWRkIG1vcmUgZG9jdW1lbnRhdGlvbiBmb3IgYDpiYXNlLXVyaScKLS0t CiBkb2MvbGlzcHJlZi9kaXNwbGF5LnRleGkgfCA4ICsrKysrKystCiBzcmMvaW1hZ2UuYyAgICAg ICAgICAgICAgfCA4ICsrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhpIGIv ZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhpCmluZGV4IDJiMzExOWVhNTkuLjJlY2QxNGZlZDkgMTAw NjQ0Ci0tLSBhL2RvYy9saXNwcmVmL2Rpc3BsYXkudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kaXNw bGF5LnRleGkKQEAgLTU5MDQsNyArNTkwNCwxMyBAQCBTVkcgSW1hZ2VzCiBUbyBAdmFye3N2Z30g YWRkIGFuIGVtYmVkZGVkIChyYXN0ZXIpIGltYWdlIHBsYWNlZCBhdAogQHZhcntyZWxhdGl2ZS1m aWxlbmFtZX0uICBAdmFye3JlbGF0aXZlLWZpbGVuYW1lfSBpcyBzZWFyY2hlZCBpbnNpZGUKIEBj b2Rle2ZpbGUtbmFtZS1kaXJlY3Rvcnl9IG9mIHRoZSBAY29kZXs6YmFzZS11cml9IHN2ZyBpbWFn ZSBwcm9wZXJ0eS4KLVRoaXMgaW1wcm92ZXMgdGhlIHBlcmZvcm1hbmNlIG9mIGVtYmVkZGluZyBs YXJnZSBpbWFnZXMuCitAY29kZXs6YmFzZS11cml9IHNwZWNpZmllcyBhIChwb3NzaWJsZSBub24t ZXhpc3RpbmcpIGZpbGVuYW1lIG5hbWUgb2YKK3RoZSBzdmcgaW1hZ2UgdG8gYmUgY3JlYXRlZCwg dGh1cyBhbGwgdGhlIGVtYmVkZGVkIGZpbGVzIGFyZSBzZWFyY2hlZAorcmVsYXRpdmVseSB0byB0 aGUgQGNvZGV7OmJhc2UtdXJpfSBmaWxlbmFtZSdzIGRpcmVjdG9yeS4gIElmCitAY29kZXs6YmFz ZS11cml9IGlzIG9tbWl0ZWQsIHRoZW4gZmlsZW5hbWUgZnJvbSB3aGVyZSBzdmcgaW1hZ2UgaXMK K2xvYWRlZCBpcyB1c2VkLiAgVXNpbmcgQGNvZGV7OmJhc2UtdXJpfSBpbXByb3ZlcyB0aGUgcGVy Zm9ybWFuY2Ugb2YKK2VtYmVkZGluZyBsYXJnZSBpbWFnZXMsIGNvbXBhcmluZyB0byBAY29kZXtz dmctZW1iZWR9LCBiZWNhdXNlIGFsbCB0aGUKK3dvcmsgaXMgZG9uZSBkaXJlY3RseSBieSBsaWJy c3ZnLgogCiBAbGlzcAogOzsgRW1iZWRpbmcgL3RtcC9zdWJkaXIvcm1zLmpwZyBhbmQgL3RtcC9h bm90aGVyL3Jtcy5qcGcKZGlmZiAtLWdpdCBhL3NyYy9pbWFnZS5jIGIvc3JjL2ltYWdlLmMKaW5k ZXggZGMwNmU5Y2UyMC4uYmEzOWZkYzc4NSAxMDA2NDQKLS0tIGEvc3JjL2ltYWdlLmMKKysrIGIv c3JjL2ltYWdlLmMKQEAgLTk3NzksOCArOTc3OSw5IEBAIHN2Z19sb2FkIChzdHJ1Y3QgZnJhbWUg KmYsIHN0cnVjdCBpbWFnZSAqaW1nKQogCX0KICAgICAgIC8qIElmIHRoZSBmaWxlIHdhcyBzbHVy cGVkIGludG8gbWVtb3J5IHByb3Blcmx5LCBwYXJzZSBpdC4gICovCiAgICAgICBpZiAoIVNUUklO R1AgKGJhc2VfdXJpKSkKLSAgICAgICAgYmFzZV91cmkgPSBFTkNPREVfRklMRSAoZmlsZSk7Ci0g ICAgICBzdWNjZXNzX3AgPSBzdmdfbG9hZF9pbWFnZSAoZiwgaW1nLCBjb250ZW50cywgc2l6ZSwg U1NEQVRBIChiYXNlX3VyaSkpOworICAgICAgICBiYXNlX3VyaSA9IGZpbGU7CisgICAgICBzdWNj ZXNzX3AgPSBzdmdfbG9hZF9pbWFnZSAoZiwgaW1nLCBjb250ZW50cywgc2l6ZSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBTU0RBVEEgKEVOQ09ERV9GSUxFIChiYXNlX3VyaSkp KTsKICAgICAgIHhmcmVlIChjb250ZW50cyk7CiAgICAgfQogICAvKiBFbHNlIGl0J3Mgbm90IGEg ZmlsZSwgaXQncyBhIExpc3Agb2JqZWN0LiAgTG9hZCB0aGUgaW1hZ2UgZnJvbSBhCkBAIC05Nzk4 LDcgKzk3OTksOCBAQCBzdmdfbG9hZCAoc3RydWN0IGZyYW1lICpmLCBzdHJ1Y3QgaW1hZ2UgKmlt ZykKICAgICAgIGlmICghU1RSSU5HUCAoYmFzZV91cmkpKQogICAgICAgICBiYXNlX3VyaSA9IEJW QVIgKGN1cnJlbnRfYnVmZmVyLCBmaWxlbmFtZSk7CiAgICAgICBzdWNjZXNzX3AgPSBzdmdfbG9h ZF9pbWFnZSAoZiwgaW1nLCBTU0RBVEEgKGRhdGEpLCBTQllURVMgKGRhdGEpLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChOSUxQIChiYXNlX3VyaSkgPyBOVUxMIDogU1NEQVRB IChiYXNlX3VyaSkpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoU1RSSU5H UCAoYmFzZV91cmkpID8KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU1NEQVRB IChFTkNPREVfRklMRSAoYmFzZV91cmkpKSA6IE5VTEwpKTsKICAgICB9CiAKICAgcmV0dXJuIHN1 Y2Nlc3NfcDsKLS0gCjIuMjUuMQoK --0000000000002b065705b69c1d2b--