Re: [PATCH] Fix display box cursor under image with margins

[Evgeny Zajcev <lg.zevlg@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

сб, 25 апр. 2020 г. в 13:35, Eli Zaretskii <eliz@gnu.org>:

> > From: Evgeny Zajcev <lg.zevlg@gmail.com>
> > Date: Sat, 18 Apr 2020 21:05:16 +0300
> > Cc: emacs-devel <emacs-devel@gnu.org>
> >
> >  > Here is the patch to fix issue making cursor hollow under non-mask
> image, but containing margins.
> >  This
> >  > patch keeps box cursor to be box in case image has margins.
> >
> >  Could you please give an example of such an image and what the results
> >  look like, before and after the patch?  It's hard to understand the
> >  details of this otherwise.
> >
> > Here is first screenshot how hollow cursor looks on image with margin -
> > http://lgarc.narod.ru/pics/emacs-hollow-cursor.png
> >
> > And here is how it looks with patch applied -
> http://lgarc.narod.ru/pics/emacs-box-cursor.png
> >
> > Without patch, look of the cursor won't change, it will remain being
> hollow
>
> Thanks.  Frankly, I'm not sure the change is for the better.
>
> Does anyone else have an opinion?
>

For me there is two problems with the hollow cursor under images:
1) You can't distinguish which window is active, since cursor is also
hollow in other window
2) Hollow cursor is barely visible on small screens with high ppi

-- 
lg

[-- Attachment #2: Type: text/html, Size: 2128 bytes --]