From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.devel Subject: Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property Date: Sat, 19 Dec 2020 15:24:38 +0300 Message-ID: References: <83o8iyerpi.fsf@gnu.org> <83czzdeogx.fsf@gnu.org> <834kkiumxt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ac9ef305b6d04fb6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31575"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 19 13:26:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqbJy-00085D-0X for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Dec 2020 13:26:50 +0100 Original-Received: from localhost ([::1]:35344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqbJw-0003UD-Tx for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Dec 2020 07:26:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqbI9-0002u3-Bu for emacs-devel@gnu.org; Sat, 19 Dec 2020 07:24:57 -0500 Original-Received: from mail-lf1-f42.google.com ([209.85.167.42]:34676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqbI4-0002xX-OR; Sat, 19 Dec 2020 07:24:54 -0500 Original-Received: by mail-lf1-f42.google.com with SMTP id o19so12494234lfo.1; Sat, 19 Dec 2020 04:24:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WhNwD7B0vosZnXjpI0D6rJ0481iY3pTDS8BvjsYSX1k=; b=R+2teUSWovdjQ9t7IPNFu7ZsgrKz6IiFo67a3iKeJhJYtljLcpM2veLzGql8RGnX4Y R+xzg6IfMPQP/UOF3mWKmrY/wVV5mR6xWaHjBHrtQafJb/RF+yPAAf6IrNjs7v05vV6l bNeo9zUzZlLGAVb8AE7cE0RVrY8BgGGb7lr0v6xoja0MLlB/SzA6TcrY0cRUjeC7AB6X /q6525kiPJgwlHPAEnx4if/C3bcI7BxDIDuE44dDe2u90DsTehxPLqSRcRhcBtD3wAMK +gf6BpuSq1szK5opMO2qN2+e9RmZe4TJphRFYi2hesanBkZENYVgOy/lHoNxenbqRh1v l5pA== X-Gm-Message-State: AOAM530t9kjLwWFgv/BZm1GYScXRyEQDrKelr3mk8LeclzxVFIh7Xg89 8/yusvxl96uSW1yZCKJHJcItjggb6BwKA5pOyBrj5x4v X-Google-Smtp-Source: ABdhPJy2pykvIhns/SBaYpAOgJOAd2l1y3dP6+CqjfqMxehzEd81jPRz0/1grtYleBPgS672ICTY0M3CmA7FWZVd0/c= X-Received: by 2002:a05:651c:1282:: with SMTP id 2mr3489206ljc.383.1608380689711; Sat, 19 Dec 2020 04:24:49 -0800 (PST) In-Reply-To: <834kkiumxt.fsf@gnu.org> Received-SPF: pass client-ip=209.85.167.42; envelope-from=lg.zevlg@gmail.com; helo=mail-lf1-f42.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261248 Archived-At: --000000000000ac9ef305b6d04fb6 Content-Type: multipart/alternative; boundary="000000000000ac9ef105b6d04fb4" --000000000000ac9ef105b6d04fb4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=81=D0=B1, 19 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 13:09, Eli Zaretsk= ii : > > From: Evgeny Zajcev > > Date: Thu, 17 Dec 2020 01:08:12 +0300 > > Cc: emacs-devel > > > > Here I've composed the patch. As I can see NEWS already fixed > > Do you think the current NEWS entry is sufficiently complete and > accurate? > Yeah, NEWS entries are good The patch LGTM, with a couple of wording nits: > > > * doc/lispref/display.texi: Add more documentation for `:base-uri' > > This should mention the name of the @node where the change is done, in > parentheses (as if it were a function). > > > diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi > > index 2b3119ea59..2ecd14fed9 100644 > > --- a/doc/lispref/display.texi > > +++ b/doc/lispref/display.texi > > @@ -5904,7 +5904,13 @@ SVG Images > > To @var{svg} add an embedded (raster) image placed at > > @var{relative-filename}. @var{relative-filename} is searched inside > > @code{file-name-directory} of the @code{:base-uri} svg image property. > > -This improves the performance of embedding large images. > > +@code{:base-uri} specifies a (possible non-existing) filename name of > ^^^^^^^^ ^^^^^^^^^^^^^ > "possibly" and "file name". > > Noted, here is the updated patch --=20 lg --000000000000ac9ef105b6d04fb4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=D1=81=D0=B1, 19 =D0=B4=D0=B5=D0=BA. = 2020 =D0=B3. =D0=B2 13:09, Eli Zaretskii <eliz@gnu.org>:
> From: Evgeny Zajcev <zevlg@yandex.ru>
> Date: Thu, 17 Dec 2020 01:08:12 +0300
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> Here I've composed the patch.=C2=A0 As I can see NEWS already fixe= d

Do you think the current NEWS entry is sufficiently complete and
accurate?

Yeah, NEWS entries are good
The patch LGTM, with a couple of wording nits:

> * doc/lispref/display.texi: Add more documentation for `:base-uri'=

This should mention the name of the @node where the change is done, in
parentheses (as if it were a function).

> diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi
> index 2b3119ea59..2ecd14fed9 100644
> --- a/doc/lispref/display.texi
> +++ b/doc/lispref/display.texi
> @@ -5904,7 +5904,13 @@ SVG Images
>=C2=A0 To @var{svg} add an embedded (raster) image placed at
>=C2=A0 @var{relative-filename}.=C2=A0 @var{relative-filename} is search= ed inside
>=C2=A0 @code{file-name-directory} of the @code{:base-uri} svg image pro= perty.
> -This improves the performance of embedding large images.
> +@code{:base-uri} specifies a (possible non-existing) filename name of=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^^^^^^^=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^^^^^^^^^^^^
"possibly" and "file name".


Noted, here is the updated patch
<= /div>
--
lg
--000000000000ac9ef105b6d04fb4-- --000000000000ac9ef305b6d04fb6 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Improvements-for-base-uri-svg-image-property.patch" Content-Disposition: attachment; filename="0001-Improvements-for-base-uri-svg-image-property.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kivob1g10 RnJvbSAyMjRhZDE1MzM2ZjAwZGYyMjYwOWMyODUwNmVhMjMxYzJhNjg4NTdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBaYWpjZXYgRXZnZW55IDx6ZXZsZ0B5YW5kZXgucnU+CkRhdGU6 IFRodSwgMTcgRGVjIDIwMjAgMDE6MDQ6MDkgKzAzMDAKU3ViamVjdDogW1BBVENIXSBJbXByb3Zl bWVudHMgZm9yIGA6YmFzZS11cmknIHN2ZyBpbWFnZSBwcm9wZXJ0eQoKKiBzcmMvaW1hZ2UuYyAo c3ZnX2xvYWQpOiBVc2UgRU5DT0RFX0ZJTEUgZm9yIGA6YmFzZS11cmknCgoqIGRvYy9saXNwcmVm L2Rpc3BsYXkudGV4aSAoU1ZHIEltYWdlcyk6IEFkZCBtb3JlIGRvY3VtZW50YXRpb24gZm9yCiAg YDpiYXNlLXVyaScKLS0tCiBkb2MvbGlzcHJlZi9kaXNwbGF5LnRleGkgfCA4ICsrKysrKystCiBz cmMvaW1hZ2UuYyAgICAgICAgICAgICAgfCA4ICsrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEy IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYv ZGlzcGxheS50ZXhpIGIvZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhpCmluZGV4IDJiMzExOWVhNTku Ljk0OWZkODk4N2MgMTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVmL2Rpc3BsYXkudGV4aQorKysgYi9k b2MvbGlzcHJlZi9kaXNwbGF5LnRleGkKQEAgLTU5MDQsNyArNTkwNCwxMyBAQCBTVkcgSW1hZ2Vz CiBUbyBAdmFye3N2Z30gYWRkIGFuIGVtYmVkZGVkIChyYXN0ZXIpIGltYWdlIHBsYWNlZCBhdAog QHZhcntyZWxhdGl2ZS1maWxlbmFtZX0uICBAdmFye3JlbGF0aXZlLWZpbGVuYW1lfSBpcyBzZWFy Y2hlZCBpbnNpZGUKIEBjb2Rle2ZpbGUtbmFtZS1kaXJlY3Rvcnl9IG9mIHRoZSBAY29kZXs6YmFz ZS11cml9IHN2ZyBpbWFnZSBwcm9wZXJ0eS4KLVRoaXMgaW1wcm92ZXMgdGhlIHBlcmZvcm1hbmNl IG9mIGVtYmVkZGluZyBsYXJnZSBpbWFnZXMuCitAY29kZXs6YmFzZS11cml9IHNwZWNpZmllcyBh IChwb3NzaWJseSBub24tZXhpc3RpbmcpIGZpbGUgbmFtZSBvZiB0aGUKK3N2ZyBpbWFnZSB0byBi ZSBjcmVhdGVkLCB0aHVzIGFsbCB0aGUgZW1iZWRkZWQgZmlsZXMgYXJlIHNlYXJjaGVkCityZWxh dGl2ZWx5IHRvIHRoZSBAY29kZXs6YmFzZS11cml9IGZpbGVuYW1lJ3MgZGlyZWN0b3J5LiAgSWYK K0Bjb2RlezpiYXNlLXVyaX0gaXMgb21taXRlZCwgdGhlbiBmaWxlbmFtZSBmcm9tIHdoZXJlIHN2 ZyBpbWFnZSBpcworbG9hZGVkIGlzIHVzZWQuICBVc2luZyBAY29kZXs6YmFzZS11cml9IGltcHJv dmVzIHRoZSBwZXJmb3JtYW5jZSBvZgorZW1iZWRkaW5nIGxhcmdlIGltYWdlcywgY29tcGFyaW5n IHRvIEBjb2Rle3N2Zy1lbWJlZH0sIGJlY2F1c2UgYWxsIHRoZQord29yayBpcyBkb25lIGRpcmVj dGx5IGJ5IGxpYnJzdmcuCiAKIEBsaXNwCiA7OyBFbWJlZGluZyAvdG1wL3N1YmRpci9ybXMuanBn IGFuZCAvdG1wL2Fub3RoZXIvcm1zLmpwZwpkaWZmIC0tZ2l0IGEvc3JjL2ltYWdlLmMgYi9zcmMv aW1hZ2UuYwppbmRleCBkYzA2ZTljZTIwLi5iYTM5ZmRjNzg1IDEwMDY0NAotLS0gYS9zcmMvaW1h Z2UuYworKysgYi9zcmMvaW1hZ2UuYwpAQCAtOTc3OSw4ICs5Nzc5LDkgQEAgc3ZnX2xvYWQgKHN0 cnVjdCBmcmFtZSAqZiwgc3RydWN0IGltYWdlICppbWcpCiAJfQogICAgICAgLyogSWYgdGhlIGZp bGUgd2FzIHNsdXJwZWQgaW50byBtZW1vcnkgcHJvcGVybHksIHBhcnNlIGl0LiAgKi8KICAgICAg IGlmICghU1RSSU5HUCAoYmFzZV91cmkpKQotICAgICAgICBiYXNlX3VyaSA9IEVOQ09ERV9GSUxF IChmaWxlKTsKLSAgICAgIHN1Y2Nlc3NfcCA9IHN2Z19sb2FkX2ltYWdlIChmLCBpbWcsIGNvbnRl bnRzLCBzaXplLCBTU0RBVEEgKGJhc2VfdXJpKSk7CisgICAgICAgIGJhc2VfdXJpID0gZmlsZTsK KyAgICAgIHN1Y2Nlc3NfcCA9IHN2Z19sb2FkX2ltYWdlIChmLCBpbWcsIGNvbnRlbnRzLCBzaXpl LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNTREFUQSAoRU5DT0RFX0ZJTEUg KGJhc2VfdXJpKSkpOwogICAgICAgeGZyZWUgKGNvbnRlbnRzKTsKICAgICB9CiAgIC8qIEVsc2Ug aXQncyBub3QgYSBmaWxlLCBpdCdzIGEgTGlzcCBvYmplY3QuICBMb2FkIHRoZSBpbWFnZSBmcm9t IGEKQEAgLTk3OTgsNyArOTc5OSw4IEBAIHN2Z19sb2FkIChzdHJ1Y3QgZnJhbWUgKmYsIHN0cnVj dCBpbWFnZSAqaW1nKQogICAgICAgaWYgKCFTVFJJTkdQIChiYXNlX3VyaSkpCiAgICAgICAgIGJh c2VfdXJpID0gQlZBUiAoY3VycmVudF9idWZmZXIsIGZpbGVuYW1lKTsKICAgICAgIHN1Y2Nlc3Nf cCA9IHN2Z19sb2FkX2ltYWdlIChmLCBpbWcsIFNTREFUQSAoZGF0YSksIFNCWVRFUyAoZGF0YSks Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKE5JTFAgKGJhc2VfdXJpKSA/IE5V TEwgOiBTU0RBVEEgKGJhc2VfdXJpKSkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChTVFJJTkdQIChiYXNlX3VyaSkgPworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBTU0RBVEEgKEVOQ09ERV9GSUxFIChiYXNlX3VyaSkpIDogTlVMTCkpOwogICAgIH0KIAog ICByZXR1cm4gc3VjY2Vzc19wOwotLSAKMi4yNS4xCgo= --000000000000ac9ef305b6d04fb6--