Why having string-chop-newline

Why having string-chop-newline

[Evgeny Zajcev]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

Why is `string-chop-newline' needed?

(string-trim-right string "\n") or (string-remove-suffix "\n" string) looks
much more descriptive and maintainable.

`string-chop-newline` name does not say us from where newline is chopped

If one need a function to map across a list of strings returning remove
newline from the tail, then `partial-apply' could be used, such as:

(mapcar (apply-partially 'string-remove-suffix "\n")
list-of-strings-with-trailing-newline)

I propose not to add one-liners just to have them in because other string
manipulating packages provides similar one liners

What do you think?

Thanks

-- 
lg

[-- Attachment #2: Type: text/html, Size: 979 bytes --]

Re: Why having string-chop-newline

[tomas]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

On Wed, Dec 30, 2020 at 12:06:39PM +0300, Evgeny Zajcev wrote:
> Why is `string-chop-newline' needed?

FWIW, "my" Emacs has no function named like that. Perhaps you
should give us a hint towards where you found it, to help set
the context...

Cheers
 - t

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Why having string-chop-newline

[Stefan Kangas]

<tomas@tuxteam.de> writes:

> On Wed, Dec 30, 2020 at 12:06:39PM +0300, Evgeny Zajcev wrote:
>> Why is `string-chop-newline' needed?
>
> FWIW, "my" Emacs has no function named like that. Perhaps you
> should give us a hint towards where you found it, to help set
> the context...

See this commit on master:

commit f329a3180ead740bb85e1edfc48ae360a56f7ffd
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date:   Mon Dec 21 22:05:37 2020 +0100

    Add string-chop-newline

    * doc/lispref/strings.texi (Creating Strings): Document it.
    * lisp/emacs-lisp/subr-x.el (string-chop-newline): Add new function.

Re: Why having string-chop-newline

[tomas]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

On Wed, Dec 30, 2020 at 03:56:48AM -0800, Stefan Kangas wrote:
> <tomas@tuxteam.de> writes:
> 
> > On Wed, Dec 30, 2020 at 12:06:39PM +0300, Evgeny Zajcev wrote:
> >> Why is `string-chop-newline' needed?
> >
> > FWIW, "my" Emacs has no function named like that. Perhaps you
> > should give us a hint towards where you found it, to help set
> > the context...
> 
> See this commit on master:
> 
> commit f329a3180ead740bb85e1edfc48ae360a56f7ffd
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Date:   Mon Dec 21 22:05:37 2020 +0100
> 
>     Add string-chop-newline
> 
>     * doc/lispref/strings.texi (Creating Strings): Document it.
>     * lisp/emacs-lisp/subr-x.el (string-chop-newline): Add new function.

Oh, thanks. Seems my bleeding edge lags a bit :)

Cheers
 - t

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]