From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.devel Subject: Re: Buffer local `switch-to-buffer-preserve-window-point' Date: Mon, 30 Nov 2020 20:54:35 +0300 Message-ID: References: <7ea00c29-61f5-5ba2-3760-f47ab65b60dd@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ba555c05b556b49c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37892"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 30 18:55:45 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjnOr-0009kR-Ai for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Nov 2020 18:55:45 +0100 Original-Received: from localhost ([::1]:41270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjnOq-0005hV-9K for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Nov 2020 12:55:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjnNz-0005Gx-7m for emacs-devel@gnu.org; Mon, 30 Nov 2020 12:54:51 -0500 Original-Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:40284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjnNx-0006LI-Hu for emacs-devel@gnu.org; Mon, 30 Nov 2020 12:54:51 -0500 Original-Received: by mail-lf1-x129.google.com with SMTP id u19so23326884lfr.7 for ; Mon, 30 Nov 2020 09:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T49ZWksyaeBtal2Kh2qTL2i3l6qbLSGebzQyk8Z+mfQ=; b=tzOMgZiOQfLWgf3uk5W2++0mOAnDj1wn0TDYxxbh10oGXCBIsPvvxBCr/1+oWb5vau IESAj0nidngsbzj6kfoz33SiaVxZBAODM7EX+CeYjIrF8sepmoT+nnITU7bvKDePekNJ OeBPI5zLnF9Ro0KEvltrp1sKBVDRBKrAFjK8qP/kcCI1mxzeqcxlXpQerecAGC4PKsq9 zO9Ws0Qfu+RTPFDGOtyv9NAJGJgzBHM8mEeKGM2D9/I/ebbObbx/rwH4La/pIczp3SZ+ QY+r6RvkBrGgI2jhYmk+EsRD3VX3HopLZSB3dQ1NQtmgjlAyK+nEvwugQZJEaY9hI2Gq rw7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T49ZWksyaeBtal2Kh2qTL2i3l6qbLSGebzQyk8Z+mfQ=; b=Y5123xhUOT/RFQUr6Ha9HjqnxWmuLGA7OVa7VcVGJ4NB2sgG1/bp6YBvK8R4xu1wv6 Mc2js7W1ZSi6jJVlmf3W3smmsniwoffDLm+sU1CjTgcJWshH5KfdTkKXuyHQ5gOaQ650 Rqkxhd/VPniAwTzE1Kr4EUYeu/hVTYKOmde0yKTiYRaGoYWnAlc+6zdykC511mkM4rzH /V5IIyenDJb4lD3NrkYTV0LbJP2bq6w/yMFd+UmFBug0iMGXKD6ak5wqfmxSNk4Pub8y Y40eJUstNHYzqsLMBY6qvlTU1y731IKhZNcWEH0JkiK2ZQbsJRu+E4GiebEDGj7n5qXn jKJA== X-Gm-Message-State: AOAM532F7XTVzhluBQ3zFOW0yAP/FZdIlfehcZWcBTg5FN16/aii7JoU O9vToAGWIUei9qaQYxDXuUCFJmhEw6X4sjWmTCk= X-Google-Smtp-Source: ABdhPJzu4EAa/TdkKqOJsSvvXMCUSrCMEenUNrH4CnC4zwfdE5/4PtNTkVkYK+mMVTkgGFljCgGcU4oYcb9qCKAxJeQ= X-Received: by 2002:a19:cd6:: with SMTP id 205mr9669018lfm.117.1606758887468; Mon, 30 Nov 2020 09:54:47 -0800 (PST) In-Reply-To: <7ea00c29-61f5-5ba2-3760-f47ab65b60dd@gmx.at> Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=lg.zevlg@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260082 Archived-At: --000000000000ba555c05b556b49c Content-Type: multipart/alternative; boundary="000000000000ba555905b556b49a" --000000000000ba555905b556b49a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=BF=D0=BD, 30 =D0=BD=D0=BE=D1=8F=D0=B1. 2020 =D0=B3. =D0=B2 20:30, marti= n rudalics : > > Ah, sorry, I thought that is in Emacs, but it was from my init.el :)), > > replace with (switch-to-buffer (other-buffer)) > > OK. > > > The problem with their buffer local values is that they are used for > buffer > > logic *before* buffer is set as current, see `switch-to-buffer'. We > should > > either use `(buffer-local-value NAME buffer)' to get their values in > > `switch-to-buffer', > > Good idea. Could you write a patch? > > Sure, here it is Probably same should be done for `switch-to-buffer-obey-display-actions', but at the moment I care more about `switch-to-buffer-preserve-window-point= ' --=20 lg --000000000000ba555905b556b49a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=D0=BF=D0=BD, 30 =D0=BD=D0=BE=D1=8F= =D0=B1. 2020 =D0=B3. =D0=B2 20:30, martin rudalics <rudalics@gmx.at>:
=C2=A0> Ah, sorry, I thought that is in Emacs, b= ut it was from my init.el :)),
=C2=A0> replace with (switch-to-buffer (other-buffer))

OK.

=C2=A0> The problem with their buffer local values is that they are used= for buffer
=C2=A0> logic *before* buffer is set as current, see `switch-to-buffer&#= 39;.=C2=A0 We should
=C2=A0> either use `(buffer-local-value NAME buffer)' to get their v= alues in
=C2=A0> `switch-to-buffer',

Good idea.=C2=A0 Could you write a patch?


Sure, here it is
<= br>
Probably same should be done for `switch-to-buffer-obey-displ= ay-actions', but at the moment I care more about `switch-to-buffer-pres= erve-window-point'

--
lg
--000000000000ba555905b556b49a-- --000000000000ba555c05b556b49c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-use-of-switch-to-buffer-preserve-window-point.patch" Content-Disposition: attachment; filename="0001-Fix-use-of-switch-to-buffer-preserve-window-point.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ki4upea40 RnJvbSAyZTI1YTA1ZTBiOWViM2E4OTFiZTM2OWJjNzQyOGZiMDE3ZDg5MDJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBaYWpjZXYgRXZnZW55IDx6ZXZsZ0B5YW5kZXgucnU+CkRhdGU6 IE1vbiwgMzAgTm92IDIwMjAgMjA6NTE6MTggKzAzMDAKU3ViamVjdDogW1BBVENIXSBGaXggdXNl IG9mIHN3aXRjaC10by1idWZmZXItcHJlc2VydmUtd2luZG93LXBvaW50CgoqIGxpc3Avd2luZG93 LmVsIChzd2l0Y2gtdG8tYnVmZmVyKTogUmVnYXJkIGJ1ZmZlciBsb2NhbCB2YWx1ZQpmb3Igc3dp dGNoLXRvLWJ1ZmZlci1wcmVzZXJ2ZS13aW5kb3ctcG9pbnQgdmFyaWFibGUKLS0tCiBsaXNwL3dp bmRvdy5lbCB8IDEwICsrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC93aW5kb3cuZWwgYi9saXNwL3dpbmRv dy5lbAppbmRleCA4Mjk3NmJmODM2Li5lYTNmNTgxYTJmIDEwMDY0NAotLS0gYS9saXNwL3dpbmRv dy5lbAorKysgYi9saXNwL3dpbmRvdy5lbApAQCAtODU2NiwxMyArODU2NiwxMyBAQCBzd2l0Y2gt dG8tYnVmZmVyCiAKICAgICAgICh3aGVuIHNldC13aW5kb3ctc3RhcnQtYW5kLXBvaW50CiAgICAg ICAgIChsZXQqICgoZW50cnkgKGFzc3EgYnVmZmVyICh3aW5kb3ctcHJldi1idWZmZXJzKSkpCi0J ICAgICAgIChkaXNwbGF5ZWQgKGFuZCAoZXEgc3dpdGNoLXRvLWJ1ZmZlci1wcmVzZXJ2ZS13aW5k b3ctcG9pbnQKLQkJCQkgICAnYWxyZWFkeS1kaXNwbGF5ZWQpCisgICAgICAgICAgICAgICAocHJl c2VydmVyLXdpbi1wb2ludAorICAgICAgICAgICAgICAgIChidWZmZXItbG9jYWwtdmFsdWUgJ3N3 aXRjaC10by1idWZmZXItcHJlc2VydmUtd2luZG93LXBvaW50CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBidWZmZXIpKQorCSAgICAgICAoZGlzcGxheWVkIChhbmQgKGVxIHBy ZXNlcnZlci13aW4tcG9pbnQgJ2FscmVhZHktZGlzcGxheWVkKQogCQkJICAgICAgIChnZXQtYnVm ZmVyLXdpbmRvdyBidWZmZXIgMCkpKSkKIAkgIChzZXQtd2luZG93LWJ1ZmZlciBuaWwgYnVmZmVy KQotCSAgKHdoZW4gKGFuZCBlbnRyeQotCQkgICAgIChvciAoZXEgc3dpdGNoLXRvLWJ1ZmZlci1w cmVzZXJ2ZS13aW5kb3ctcG9pbnQgdCkKLQkJICAgICAgICAgZGlzcGxheWVkKSkKKwkgICh3aGVu IChhbmQgZW50cnkgKG9yIChlcSBwcmVzZXJ2ZXItd2luLXBvaW50IHQpIGRpc3BsYXllZCkpCiAJ ICAgIDs7IFRyeSB0byByZXN0b3JlIHN0YXJ0IGFuZCBwb2ludCBvZiBidWZmZXIgaW4gdGhlIHNl bGVjdGVkCiAJICAgIDs7IHdpbmRvdyAoQnVnIzQwNDEpLgogCSAgICAoc2V0LXdpbmRvdy1zdGFy dCAoc2VsZWN0ZWQtd2luZG93KSAobnRoIDEgZW50cnkpIHQpCi0tIAoyLjI1LjEKCg== --000000000000ba555c05b556b49c--