From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.devel Subject: Re: Loading svg from memory using custom filename for base_uri Date: Sat, 12 Dec 2020 14:52:16 +0300 Message-ID: References: <953508BA-5721-4BFF-AF28-54DF93DC7AD2@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000015f7c905b6430b7a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13024"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , Evgeny Zajcev , emacs-devel , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 12 22:08:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koC8G-0003KL-26 for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Dec 2020 22:08:48 +0100 Original-Received: from localhost ([::1]:34736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koC8F-0007eX-3x for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Dec 2020 16:08:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koAPC-0006Vd-RX for emacs-devel@gnu.org; Sat, 12 Dec 2020 14:18:15 -0500 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:39579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koAP9-0007MP-Px; Sat, 12 Dec 2020 14:18:09 -0500 Original-Received: by mail-lf1-x130.google.com with SMTP id a12so20057363lfl.6; Sat, 12 Dec 2020 11:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ibC8gLfsxiQ8yyc9kqFQVpcRwktK2m9IxH4XO6VQtEk=; b=U+UYJw/YMWcbM8u5mLbDOIPa8xuNm6YVKUQzYer9mowtCJ9961RTSVGEVJsLkzuBUh D54nqCds/aBAvvzIC/A3ggJc8rqqgbcAzTch0MBj0IcGm1aCLofnjQzVmoemMpfCEv/d sr6RgbLUFzncQRs1NCzf1MWEII7sKE6zjWAisThpgMkrKhgRgpfrChgsR/hOimzTxO/5 lYBOuIc0JwmmE22Imw31Mu8ois+VFRqCsRa8JG0j9gZSjPO9b9Fa58hKUEY5g+aTAm30 DfK8rCELyKgzZ/VJaHP3H2y9+aAn3ifwhTeP9cZzZIC1huXK+xZHkmi+pmu6uC22ogv/ 7gmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ibC8gLfsxiQ8yyc9kqFQVpcRwktK2m9IxH4XO6VQtEk=; b=i8GhI3bD+2erZUp+LXXcFcVI0mj1kUnTLxmx3hdMeKB19+u2z2DzWqZq+6d/NtiIYq xJ/UAKDLFYvRzGkKueCbGQElbhyOGWfdnpDq9HdU3MMGQirx4mgbMp2Vx8NeBt0rWLHi VdmTL50Y41p6kCDnNoLfBrA5efGf6Sqj2zhtSCjHWOxoRGsceuAF4K5ILfrcvEQAAXm1 eQ3ZCSElydoRzbdmDrkBG/H2OuXQJ5oSQmBdecA3c8bMihXjzg5o7kaWneeLvIGEmx8Z wOLnSkGl86dVyIG5wGDD9/SZcU6Qm9yKCpGJ4WKQ4ociWAaP6viFfRNdBQTknNbedHRF D/1w== X-Gm-Message-State: AOAM532KzkVK/4pwZrDv7PHo63somvOQhyaeftpXOmEa5etDxfNELepc nINocf3fferSnI3mYO8FuSF7/KEuEC2ZRkBUA7LxbNVMTcA= X-Google-Smtp-Source: ABdhPJw8UXmMm9ujWuXu6YU3V5GC0CJ3qMKmroHYjk2BmWUgRFk5wDZJVPSESo9mDC49kHmIhO+LZQ7sD06Z1C6dz1c= X-Received: by 2002:a05:651c:3db:: with SMTP id f27mr7004346ljp.494.1607773948605; Sat, 12 Dec 2020 03:52:28 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=lg.zevlg@gmail.com; helo=mail-lf1-x130.google.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260726 Archived-At: --00000000000015f7c905b6430b7a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=81=D0=B1, 12 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 13:45, Alan Third = : > On Sat, Dec 12, 2020 at 08:46:10AM +0300, lg.zevlg@gmail.com wrote: > > > > > 4 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 02:02, Evgeny Zajcev > =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): > > > > > > =EF=BB=BF > > > > > > > > > =D0=BF=D1=82, 4 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 01:11, Evgeny= Zajcev : > > >> > > >> > > >> =D1=87=D1=82, 3 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 22:57, Alan = Third : > > >>>> On Thu, Dec 03, 2020 at 08:50:15PM +0300, Evgeny Zajcev wrote: > > >>>> > > > >>>> > Here is updated patch, with support for `:base-uri` for :file > image spec as > > >>>> > well > > >>>> > > >>>> It looks good to me. There are two things I think we need. One is = to > > >>>> add an entry for :base-uri to the svg_format array in image.c, > > >>> done! > > >>> > > >>> and > > >>> some documentation, if you fancy writing it? > > >>> > > >> Documentation better to write when `svg-embed` will support this > feature. > > > > > > I wrote a new function `svg-embed-base-uri-image' to do the job, and > wrote documentation for it. > > > > > > > JFYI: I=E2=80=99ve been using Emacs with this patch applied for one wee= k, > > utilizing svg file embeding heavily, works as expected without any > > issues > > Thanks. I've pushed it to the master branch. > Just interested, why not the latest patch with `svg-embed-base-uri-image` function implemented and documentation written? That latest patch, also adds :base-uri to svg_format spec --=20 lg --00000000000015f7c905b6430b7a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=D1=81=D0=B1, 12 =D0=B4=D0=B5=D0=BA. = 2020 =D0=B3. =D0=B2 13:45, Alan Third <alan@idiocy.org>:
On Sat, Dec 12, 2020 at 08:46:10AM +0300, lg.zevlg@gmail.com wrote:
>
> > 4 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 02:02, Evgeny Zajcev &= lt;lg.zevlg@gmail.c= om> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):
> >
> > =EF=BB=BF
> >
> >
> > =D0=BF=D1=82, 4 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 01:11, Ev= geny Zajcev <lg.= zevlg@gmail.com>:
> >>
> >>
> >> =D1=87=D1=82, 3 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 22:57= , Alan Third <alan@= idiocy.org>:
> >>>> On Thu, Dec 03, 2020 at 08:50:15PM +0300, Evgeny Zajc= ev wrote:
> >>>> >
> >>>> > Here is updated patch, with support for `:base-u= ri` for :file image spec as
> >>>> > well
> >>>>
> >>>> It looks good to me. There are two things I think we = need. One is to
> >>>> add an entry for :base-uri to the svg_format array in= image.c,
> >>> done!
> >>>
> >>> and
> >>> some documentation, if you fancy writing it?
> >>>
> >> Documentation better to write when `svg-embed` will support t= his feature.
> >
> > I wrote a new function `svg-embed-base-uri-image' to do the j= ob, and wrote documentation for it.
> >
>
> JFYI: I=E2=80=99ve been using Emacs with this patch applied for one we= ek,
> utilizing svg file embeding heavily, works as expected without any
> issues

Thanks. I've pushed it to the master branch.

<= /div>
Just interested, why not the latest patch with `svg-embed-base-ur= i-image` function implemented and documentation written?

That latest patch, also adds :base-uri to svg_format spec

--
lg
--00000000000015f7c905b6430b7a--