From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.devel Subject: Re: master 69ec333eab0: Allow customizing partial-completion to be more like substring Date: Tue, 24 Sep 2024 07:32:22 -0400 Message-ID: References: <172449136475.5211.17507793835510648935@vcs2.savannah.gnu.org> <20240824092245.2C0C9C41F06@vcs2.savannah.gnu.org> <87frqu6xbe.fsf@gmx.de> <865xrhca52.fsf@gnu.org> <86seu2hb9t.fsf@gnu.org> <86bk0h49dl.fsf@gnu.org> <86wmj1e1p3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000062bc940622dbdc6f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16828"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 24 14:49:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1st4yX-00047M-FR for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Sep 2024 14:49:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1st4xw-00029p-Oh; Tue, 24 Sep 2024 08:48:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st3mW-0006it-4t for emacs-devel@gnu.org; Tue, 24 Sep 2024 07:32:37 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st3mU-0005hm-3K for emacs-devel@gnu.org; Tue, 24 Sep 2024 07:32:35 -0400 Original-Received: from mail-ej1-f69.google.com ([209.85.218.69]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.98) id 1st3mS-00000007Pvz-1NZP for emacs-devel@gnu.org; Tue, 24 Sep 2024 07:32:32 -0400 Original-Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a8a92ab4dd0so349074966b.1 for ; Tue, 24 Sep 2024 04:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1727177551; x=1727782351; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=erRpXw5qDRj5Euc+2zyt4j8YT9F6Sz8UJ3/sbbbNOOs=; b=lvve07Wv5AKsembTmQa8iMq47MbltWf7OIDqycCTdKPnnZkSifjoe3wYi9ufT+RKmg POEq6OVj0VcpEngqYdBsQWM9R5Bh9ZvSLsnnIHF6d95lt6OO/We2YOn75Mqy6NyUQUxQ u9bTojq+AVEjHbUtRBrPNDVK2uld7S/f184YE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1727177552; bh=erRpXw5qDRj5Euc+2zyt4j8YT9F6Sz8UJ3/sbbbNOOs=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=lb/iIWrTbMrFTdGKA6rrl9QZljK0Rby26KPznWdlvBPKfXflCtGqB6onLc15rI06i keWc2aYHEt83uOipTW+35cbrECUu7Q9uQDSoCRncsQ4B0es7rvwiH+u2P4ZnJr6c+h YLJc94DJgsRDfvfVOwz78fgNfTaOqnu+6BqRz1IeJp6JSDFYTDYK/ERAvyNnuQxttC ErnjsOimWIHtB6KU8m+LV+vXxD9r/WdC2IYz1lIRMQ9fdmICp+5xkWbdS/+iHV6fIE uCRE7tyyVRkH58Nh9y7jM+eAqFkvvrqanQ7im/xM3vskCwdezvLTCXtPFftZn0ERm3 gCa2NQKvdaU+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727177551; x=1727782351; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=erRpXw5qDRj5Euc+2zyt4j8YT9F6Sz8UJ3/sbbbNOOs=; b=lPPsqiGBSgq6S9XFbsQjcPtwLeRTFtnj0m4qDKyikmQpsFQm2NhC4PFCG5u2EKWIFH W/7WnIYKhbnIosbJf3YbP4JcrHeFrCcxngvyefVw20QXnEE8wO8W1XxjKp1+Z2jcgdcg 6kMz/qczFdAfpmHRtdE/qok0dWQGo5vBpxtwAlm41EksPxE1VoT/nP6Ph9imBCvt1dWB byD3juswiCDIcwFQqsVFFGU8N8pgEA4f0lL2Cx8Q3ReeTjwu9fXQ6fIvXyPyQhHi5KMM XukMWAVpZF1Z31Dz1dBUakcwbOHVqVsTkHn4xUgZ/m5G+ZVXYeXoCZFgaSZj5nYBvXlE 0MHQ== X-Gm-Message-State: AOJu0YwPr7h3xQDzbzO8C47/4FaNb7hQ9UQ8xfgZhyRszWyaMBHxCCC4 uXY3iY/JvoK1FBiZxX/71ZbRJlcdThAQ2s6vBlzo/hDOMzWlTv6PsEsVKMMX8dmKB8POswt8qnE V6VOA/oXIwyD+kBH5L/wjDxW8sGxqg22VfqcdSlwAohB9CZWM/8Y63NtNs8o9dQNMLmH6GYtgLv IZzKVfjF+TUxear+aTH3bQjcGsqRhrgB4= X-Received: by 2002:a17:906:c108:b0:a8a:1ffe:70f1 with SMTP id a640c23a62f3a-a90d50efd99mr1564633866b.50.1727177551297; Tue, 24 Sep 2024 04:32:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqhz5QHMETXBWCZU8iVsBt/+VjN062fVE5ULKY8VPbI4FiP9EzLA+GAlJpfbeQDidRwm2ZWmbp95LX/MBTcW0= X-Received: by 2002:a17:906:c108:b0:a8a:1ffe:70f1 with SMTP id a640c23a62f3a-a90d50efd99mr1564631466b.50.1727177550896; Tue, 24 Sep 2024 04:32:30 -0700 (PDT) In-Reply-To: <86wmj1e1p3.fsf@gnu.org> Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 24 Sep 2024 08:48:20 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324027 Archived-At: --00000000000062bc940622dbdc6f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 24, 2024, 7:22=E2=80=AFAM Eli Zaretskii wrote: > > From: Spencer Baugh > > Cc: emacs-devel@gnu.org > > Date: Mon, 23 Sep 2024 15:36:10 -0400 > > > > Eli Zaretskii writes: > > >> Date: Sat, 14 Sep 2024 11:47:42 +0300 > > >> From: Eli Zaretskii > > >> Cc: emacs-devel@gnu.org > > >> > > >> > Date: Fri, 06 Sep 2024 13:23:19 -0400 > > >> > From: Spencer Baugh via "Emacs development discussions." < > emacs-devel@gnu.org> > > >> > Eli Zaretskii writes: > > >> > > Spencer, would you please take care of these gotchas? > > >> > > > >> > The attached patch does so. > > >> > > >> Thanks, installed. But the new single-or-list feature should be > > >> documented in the ELisp manual. > > > > > > Ping! single-or-list is still undocumented, AFAICT. We should > > > document it ASAP, as it is not good to have on the master branch > > > features which are not reflected in the documentation. > > > > > > TIA > > > > I started writing documentation, but I came to the conclusion that most > > users other than completion-styles should use the "group" widget > > instead. And documenting single-or-list would encourage using it > > instead of group, which I don't think is correct. > > > > Maybe this widget should just be moved to minibuffer.el? > > > > Alternatively, if there are any other customizable variables or values > > in Emacs which are sometimes a single value, and sometimes a list, then > > this widget would be useful for those. If we can think of any such > > variables, then that would help justify the existence of single-or-list > > (and I would convert their defcustoms to use single-or-list). That > > would help in writing documentation about when exactly to use it. > > I'm not sure I understand: are you saying that your change to > minibuffer.el can be rewritten to not use single-or-list? If so, I'm > okay with that, and in that case we should simply remove > single-or-list, until there are some users of it. > No, it's still necessary for my changes in minibuffer.el. But I don't think it's useful outside that. > --00000000000062bc940622dbdc6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Sep 24, 2024, 7:22=E2=80=AFAM Eli Zaretskii &l= t;eliz@gnu.org> wrote:
> From: Spencer Baugh <sbaugh@janestree= t.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 23 Sep 2024 15:36:10 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
> >> Date: Sat, 14 Sep 2024 11:47:42 +0300
> >> From: Eli Zaretskii <eliz@gnu.org>
> >> Cc: emacs-devel@gnu.org
> >>
> >> > Date: Fri, 06 Sep 2024 13:23:19 -0400
> >> > From:=C2=A0 Spencer Baugh via "Emacs development di= scussions." <emacs-devel@gnu.org>
> >> > Eli Zaretskii <eliz@gnu.org> writes:
> >> > > Spencer, would you please take care of these gotcha= s?
> >> >
> >> > The attached patch does so.
> >>
> >> Thanks, installed.=C2=A0 But the new single-or-list feature s= hould be
> >> documented in the ELisp manual.
> >
> > Ping! single-or-list is still undocumented, AFAICT.=C2=A0 We shou= ld
> > document it ASAP, as it is not good to have on the master branch<= br> > > features which are not reflected in the documentation.
> >
> > TIA
>
> I started writing documentation, but I came to the conclusion that mos= t
> users other than completion-styles should use the "group" wi= dget
> instead.=C2=A0 And documenting single-or-list would encourage using it=
> instead of group, which I don't think is correct.
>
> Maybe this widget should just be moved to minibuffer.el?
>
> Alternatively, if there are any other customizable variables or values=
> in Emacs which are sometimes a single value, and sometimes a list, the= n
> this widget would be useful for those.=C2=A0 If we can think of any su= ch
> variables, then that would help justify the existence of single-or-lis= t
> (and I would convert their defcustoms to use single-or-list).=C2=A0 Th= at
> would help in writing documentation about when exactly to use it.

I'm not sure I understand: are you saying that your change to
minibuffer.el can be rewritten to not use single-or-list?=C2=A0 If so, I= 9;m
okay with that, and in that case we should simply remove
single-or-list, until there are some users of it.

No, it's still necessa= ry for my changes in minibuffer.el.=C2=A0 But I don't think it's us= eful outside that.
--00000000000062bc940622dbdc6f--