From: Spencer Baugh <sbaugh@janestreet.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 69ec333eab0: Allow customizing partial-completion to be more like substring
Date: Tue, 24 Sep 2024 07:32:22 -0400 [thread overview]
Message-ID: <CAO=BR8M24ryXxpdXQLYrkeMi39qnUPC1DAewwxOt6T9aEsuNjA@mail.gmail.com> (raw)
In-Reply-To: <86wmj1e1p3.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]
On Tue, Sep 24, 2024, 7:22 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Spencer Baugh <sbaugh@janestreet.com>
> > Cc: emacs-devel@gnu.org
> > Date: Mon, 23 Sep 2024 15:36:10 -0400
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> > >> Date: Sat, 14 Sep 2024 11:47:42 +0300
> > >> From: Eli Zaretskii <eliz@gnu.org>
> > >> Cc: emacs-devel@gnu.org
> > >>
> > >> > Date: Fri, 06 Sep 2024 13:23:19 -0400
> > >> > From: Spencer Baugh via "Emacs development discussions." <
> emacs-devel@gnu.org>
> > >> > Eli Zaretskii <eliz@gnu.org> writes:
> > >> > > Spencer, would you please take care of these gotchas?
> > >> >
> > >> > The attached patch does so.
> > >>
> > >> Thanks, installed. But the new single-or-list feature should be
> > >> documented in the ELisp manual.
> > >
> > > Ping! single-or-list is still undocumented, AFAICT. We should
> > > document it ASAP, as it is not good to have on the master branch
> > > features which are not reflected in the documentation.
> > >
> > > TIA
> >
> > I started writing documentation, but I came to the conclusion that most
> > users other than completion-styles should use the "group" widget
> > instead. And documenting single-or-list would encourage using it
> > instead of group, which I don't think is correct.
> >
> > Maybe this widget should just be moved to minibuffer.el?
> >
> > Alternatively, if there are any other customizable variables or values
> > in Emacs which are sometimes a single value, and sometimes a list, then
> > this widget would be useful for those. If we can think of any such
> > variables, then that would help justify the existence of single-or-list
> > (and I would convert their defcustoms to use single-or-list). That
> > would help in writing documentation about when exactly to use it.
>
> I'm not sure I understand: are you saying that your change to
> minibuffer.el can be rewritten to not use single-or-list? If so, I'm
> okay with that, and in that case we should simply remove
> single-or-list, until there are some users of it.
>
No, it's still necessary for my changes in minibuffer.el. But I don't
think it's useful outside that.
>
[-- Attachment #2: Type: text/html, Size: 3561 bytes --]
next prev parent reply other threads:[~2024-09-24 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172449136475.5211.17507793835510648935@vcs2.savannah.gnu.org>
[not found] ` <20240824092245.2C0C9C41F06@vcs2.savannah.gnu.org>
2024-08-24 10:15 ` master 69ec333eab0: Allow customizing partial-completion to be more like substring Michael Albinus
2024-08-31 9:30 ` Eli Zaretskii
2024-09-06 17:23 ` Spencer Baugh via Emacs development discussions.
2024-09-14 8:47 ` Eli Zaretskii
2024-09-21 9:57 ` Eli Zaretskii
2024-09-23 19:36 ` Spencer Baugh
2024-09-24 11:22 ` Eli Zaretskii
2024-09-24 11:32 ` Spencer Baugh [this message]
2024-09-24 12:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO=BR8M24ryXxpdXQLYrkeMi39qnUPC1DAewwxOt6T9aEsuNjA@mail.gmail.com' \
--to=sbaugh@janestreet.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).