unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
Date: Thu, 21 Sep 2023 08:29:29 +0200	[thread overview]
Message-ID: <CAO48Bk_RGsgavFa+nnnCi3QNrBPq6Y1VVKBHXSA7hEjAVtx35A@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi

reading removed FIXME in the second hunk:

# FIXME: Don't install the dump file into the app bundle when
# self-contained install is disabled.

I understand that we should install if self-contained is enabled.

However, I see

+ifeq (${ns_self_contained},no)

Shouldn't that read as

+ifeq (${ns_self_contained},yes)

I'm confused...

/PA
-- 
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #2: Type: text/html, Size: 3016 bytes --]

             reply	other threads:[~2023-09-21  6:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21  6:29 Pedro Andres Aranda Gutierrez [this message]
2023-09-21  8:46 ` Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Gerd Möllmann
2023-09-21  9:59   ` Pedro Andres Aranda Gutierrez
2023-09-21 10:22     ` Gerd Möllmann
2023-09-21 16:50   ` Alan Third
2023-09-21 17:06     ` Gerd Möllmann
2023-09-21 17:29       ` Alan Third
2023-09-21 17:58         ` Gerd Möllmann
2023-09-21 18:46           ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO48Bk_RGsgavFa+nnnCi3QNrBPq6Y1VVKBHXSA7hEjAVtx35A@mail.gmail.com \
    --to=paaguti@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).