Re: RE: [External] : Re: master 6362f65474: Add new command `duplicate-line'

Re: RE: [External] : Re: master 6362f65474: Add new command `duplicate-line'

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

> >* I feel like most of these line based commands exist*

> >* in other editors because they don't have Emacs' `C-k'.*

> More generally, they don't have Emacs...

But even so...

If I wrote the duplicate-line-or-region, it wasn't because of any other
editor having whatever... It was just because I sometimes need to duplicate
things and don't want them to appear in the kill-ring.
Actually, the more I think, the more I realise how much I duplicate stuff
:-)

Same goes with moving lines around, which I've also seen being talked
about. Having a package is good enough for me and there's a package for
that in ELPA.

Don't need that as part of stock Emacs core either...
we'll always have ~/.emacs.d and ELPA, right?

/PA
-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #2: Type: text/html, Size: 1691 bytes --]

Re: [External] : Re: master 6362f65474: Add new command `duplicate-line'

[Eli Zaretskii]

> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Mon, 20 Jun 2022 07:56:15 +0200
> 
> If I wrote the duplicate-line-or-region, it wasn't because of any other editor having whatever... It was just
> because I sometimes need to duplicate things and don't want them to appear in the kill-ring.

Why is it a problem for something to appear in the kill-ring?

Re: [External] : Re: master 6362f65474: Add new command `duplicate-line'

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

As such it is not a problem, but it's convenient. Say I want to duplicate a
line and paste something I yanked before after the first word in the line.
With my bindings:
Ctrl-a (beginning of line)
Ctrl-c D (duplicate line)
Esc-f (forward-word)
Ctrl-Y (paste)
Which is somehow quick and convenient.

I've been using this duplicate-line stuff for some time and it's only
afterwards that I have become aware of it being offered in other editors.

/PA

On Mon, 20 Jun 2022 at 13:08, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> > Date: Mon, 20 Jun 2022 07:56:15 +0200
> >
> > If I wrote the duplicate-line-or-region, it wasn't because of any other
> editor having whatever... It was just
> > because I sometimes need to duplicate things and don't want them to
> appear in the kill-ring.
>
> Why is it a problem for something to appear in the kill-ring?
>


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #2: Type: text/html, Size: 1861 bytes --]

Re: [External] : Re: master 6362f65474: Add new command `duplicate-line'

[Eli Zaretskii]

> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Tue, 21 Jun 2022 07:06:47 +0200
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> As such it is not a problem, but it's convenient. Say I want to duplicate a line and paste something I yanked
> before after the first word in the line.
> With my bindings:
> Ctrl-a (beginning of line)
> Ctrl-c D (duplicate line)
> Esc-f (forward-word)
> Ctrl-Y (paste)
> Which is somehow quick and convenient.

You mean, the problem is to say "C-u C-y" instead?

\\[universal-argument] not working?

[Robert Pluim]

>>>>> On Tue, 21 Jun 2022 13:19:59 +0300, Eli Zaretskii <eliz@gnu.org> said:

    Eli> You mean, the problem is to say "C-u C-y" instead?

Apropos, something appears to have broken command substitution for
universal-argument:

C-h k C-y

    Reinsert ("paste") the last stretch of killed text.
    More precisely, reinsert the most recent kill, which is the stretch of
    text most recently killed OR yanked, as returned by `current-kill' (which
    see).  Put point at the end, and set mark at the beginning without
    activating it. With just \[universal-argument] as argument, put point
    at beginning, and mark at end.
    With argument N, reinsert the Nth most recent kill.

(this is after a 'make bootstrap' on master)

Robert
-- 

Re: \\[universal-argument] not working?

[Stefan Kangas]

Robert Pluim <rpluim@gmail.com> writes:

> Apropos, something appears to have broken command substitution for
> universal-argument:
>
> C-h k C-y
>
>     Reinsert ("paste") the last stretch of killed text.
>     More precisely, reinsert the most recent kill, which is the stretch of
>     text most recently killed OR yanked, as returned by `current-kill' (which
>     see).  Put point at the end, and set mark at the beginning without
>     activating it. With just \[universal-argument] as argument, put point

That looks like Bug#56106.  It should be fixed on master (thanks, Lars!).

Re: \\[universal-argument] not working?

[Robert Pluim]

>>>>> On Tue, 21 Jun 2022 15:02:20 +0200, Stefan Kangas <stefan@marxist.se> said:

    Stefan> Robert Pluim <rpluim@gmail.com> writes:
    >> Apropos, something appears to have broken command substitution for
    >> universal-argument:
    >> 
    >> C-h k C-y
    >> 
    >> Reinsert ("paste") the last stretch of killed text.
    >> More precisely, reinsert the most recent kill, which is the stretch of
    >> text most recently killed OR yanked, as returned by `current-kill' (which
    >> see).  Put point at the end, and set mark at the beginning without
    >> activating it. With just \[universal-argument] as argument, put point

    Stefan> That looks like Bug#56106.  It should be fixed on master (thanks, Lars!).

Indeed, that fixes it for me. How dare I be 4 commits behind Lars 😼

Robert
-- 

Re: \\[universal-argument] not working?

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 21 Jun 2022 14:50:35 +0200
> 
> Apropos, something appears to have broken command substitution for
> universal-argument:
> 
> C-h k C-y
> 
>     Reinsert ("paste") the last stretch of killed text.
>     More precisely, reinsert the most recent kill, which is the stretch of
>     text most recently killed OR yanked, as returned by `current-kill' (which
>     see).  Put point at the end, and set mark at the beginning without
>     activating it. With just \[universal-argument] as argument, put point
>     at beginning, and mark at end.
>     With argument N, reinsert the Nth most recent kill.
> 
> (this is after a 'make bootstrap' on master)

Doesn't happen here (but I didn't bootstrap).

Re: \\[universal-argument] not working?

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> (this is after a 'make bootstrap' on master)

Is this with the current master?  I fixed something in this area a
couple hours ago...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [External] : Re: master 6362f65474: Add new command `duplicate-line'

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1.1: Type: text/plain, Size: 947 bytes --]

Hi Eli,

I hope you understand what I want to do from the attached screencast.

Best, /PA

On Tue, 21 Jun 2022 at 12:20, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> > Date: Tue, 21 Jun 2022 07:06:47 +0200
> > Cc: emacs-devel <emacs-devel@gnu.org>
> >
> > As such it is not a problem, but it's convenient. Say I want to
> duplicate a line and paste something I yanked
> > before after the first word in the line.
> > With my bindings:
> > Ctrl-a (beginning of line)
> > Ctrl-c D (duplicate line)
> > Esc-f (forward-word)
> > Ctrl-Y (paste)
> > Which is somehow quick and convenient.
>
> You mean, the problem is to say "C-u C-y" instead?
>


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #1.2: Type: text/html, Size: 1684 bytes --]

[-- Attachment #2: Screencast_22-06-22_07:32:04.webm --]
[-- Type: video/webm, Size: 161845 bytes --]

Re: master 6362f65474: Add new command `duplicate-line'

[Visuwesh]

[வெள்ளி ஜூன் 17, 2022 13:34] Lars Ingebrigtsen wrote:

> branch: master
> commit 6362f65474bad81c1d57b9b603c65686a0dd853e
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Add new command `duplicate-line'
>     
>     * lisp/misc.el (copy-from-above-command): Mention it.
>     (duplicate-line): New command (bug#46621).
> ---
>  etc/NEWS     |  4 ++++
>  lisp/misc.el | 17 ++++++++++++++++-
>  2 files changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/etc/NEWS b/etc/NEWS
> index 3b9515c2d4..d27c18f4ec 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -298,6 +298,10 @@ startup.  Previously, these functions ignored
>  \f
>  * Changes in Emacs 29.1
>  
> +---
> +** New command 'duplicate-line'.
> +This command duplicates the current line the specified number of times.
> +
>  ---
>  ** Files with the '.eld' extension are now visited in 'lisp-data-mode'.
>  
> diff --git a/lisp/misc.el b/lisp/misc.el
> index 0bb8ee6c7b..88932681c1 100644
> --- a/lisp/misc.el
> +++ b/lisp/misc.el
> @@ -33,7 +33,9 @@
>    "Copy characters from previous nonblank line, starting just above point.
>  Copy ARG characters, but not past the end of that line.
>  If no argument given, copy the entire rest of the line.
> -The characters copied are inserted in the buffer before point."
> +The characters copied are inserted in the buffer before point.
> +
> +Also see the `copy-line' command."

Shouldn't this be `duplicate-line'?

>    (interactive "P")
>    (let ((cc (current-column))
>  	n
> @@ -61,6 +63,19 @@ The characters copied are inserted in the buffer before point."
>  				 (+ n (point)))))))
>      (insert string)))
>  
> +;;;###autoload
> +(defun duplicate-line (&optional n)
> +  "Duplicate the current line N times.
> +Also see the `copy-from-above-command' command."
> +  (interactive "p")
> +  (let ((line (buffer-substring (line-beginning-position) (line-end-position))))
> +    (save-excursion
> +      (forward-line 1)
> +      (unless (bolp)
> +        (insert "\n"))
> +      (dotimes (_ n)
> +        (insert line "\n")))))
> +
>  ;; Variation of `zap-to-char'.
>  
>  ;;;###autoload

Re: master 6362f65474: Add new command `duplicate-line'

[Ergus]

Hi:

I saw this command and I would like to make some suggestions very simple
to implement, but that provides some consistency and improve user
interaction.

1) Could we consider to move the cursor when duplicate-line based on
prefix value?  This may be useful to bind the command giving a more
intuitive behavior. For example: USERPREFIX-<up> and USERPREFIX-<down>.

Actually the current command `duplicate-line' is what I expect for
USERPREFIX-<up>, which "emulates" like "we have duplicated before or
up".

Many packages around try to implement such commands because they are
available y sublime ad VS-Code... for example:
https://github.com/wyuenho/move-dup/blob/master/move-dup.el

2) From the same package may we consider a command "move-line", which in
the same fashion the user could bind to move the current line up/down?

3) Could we provide a consistent alternative to all mark-? commands?
Because mark-work selects from the current position to the end of the
work, but mark-sexp or mark-paragraph marks the whole current
sexp/paragraph... moving the cursor to the beginning maybe as mark-word
is a current a long standing command we may provide an alternative like
mark-current-word or similes...

The idea behind this is to provide a more consistent API that avoids to
wrap all per-case commands like transpose-word could have bother like
duplicate-work with just a few lines.

4) Could we provide a mark-line command to complete the family of
mark-something commands? Actually all this could rely on thing-at-point
api right?

Best,
Ergus

On Fri, Jun 17, 2022 at 11:14:14PM +0530, Visuwesh wrote:
>[வெள்ளி ஜூன் 17, 2022 13:34] Lars Ingebrigtsen wrote:
>
>> branch: master
>> commit 6362f65474bad81c1d57b9b603c65686a0dd853e
>> Author: Lars Ingebrigtsen <larsi@gnus.org>
>> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>>
>>     Add new command `duplicate-line'
>>
>>     * lisp/misc.el (copy-from-above-command): Mention it.
>>     (duplicate-line): New command (bug#46621).
>> ---
>>  etc/NEWS     |  4 ++++
>>  lisp/misc.el | 17 ++++++++++++++++-
>>  2 files changed, 20 insertions(+), 1 deletion(-)
>>
>> diff --git a/etc/NEWS b/etc/NEWS
>> index 3b9515c2d4..d27c18f4ec 100644
>> --- a/etc/NEWS
>> +++ b/etc/NEWS
>> @@ -298,6 +298,10 @@ startup.  Previously, these functions ignored
>>
>>  * Changes in Emacs 29.1
>>
>> +---
>> +** New command 'duplicate-line'.
>> +This command duplicates the current line the specified number of times.
>> +
>>  ---
>>  ** Files with the '.eld' extension are now visited in 'lisp-data-mode'.
>>
>> diff --git a/lisp/misc.el b/lisp/misc.el
>> index 0bb8ee6c7b..88932681c1 100644
>> --- a/lisp/misc.el
>> +++ b/lisp/misc.el
>> @@ -33,7 +33,9 @@
>>    "Copy characters from previous nonblank line, starting just above point.
>>  Copy ARG characters, but not past the end of that line.
>>  If no argument given, copy the entire rest of the line.
>> -The characters copied are inserted in the buffer before point."
>> +The characters copied are inserted in the buffer before point.
>> +
>> +Also see the `copy-line' command."
>
>Shouldn't this be `duplicate-line'?
>
>>    (interactive "P")
>>    (let ((cc (current-column))
>>  	n
>> @@ -61,6 +63,19 @@ The characters copied are inserted in the buffer before point."
>>  				 (+ n (point)))))))
>>      (insert string)))
>>
>> +;;;###autoload
>> +(defun duplicate-line (&optional n)
>> +  "Duplicate the current line N times.
>> +Also see the `copy-from-above-command' command."
>> +  (interactive "p")
>> +  (let ((line (buffer-substring (line-beginning-position) (line-end-position))))
>> +    (save-excursion
>> +      (forward-line 1)
>> +      (unless (bolp)
>> +        (insert "\n"))
>> +      (dotimes (_ n)
>> +        (insert line "\n")))))
>> +
>>  ;; Variation of `zap-to-char'.
>>
>>  ;;;###autoload
>

Re: master 6362f65474: Add new command `duplicate-line'

[Lars Ingebrigtsen]

Ergus <spacibba@aol.com> writes:

> Many packages around try to implement such commands because they are
> available y sublime ad VS-Code... for example:
> https://github.com/wyuenho/move-dup/blob/master/move-dup.el

[...]

> 4) Could we provide a mark-line command to complete the family of
> mark-something commands? Actually all this could rely on thing-at-point
> api right?

I feel like most of these line based commands exist in other editors
because they don't have Emacs' `C-k'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

RE: [External] : Re: master 6362f65474: Add new command `duplicate-line'

[Drew Adams]

> I feel like most of these line based commands exist 
> in other editors because they don't have Emacs' `C-k'.

More generally, they don't have Emacs...