unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
Date: Thu, 21 Sep 2023 11:59:22 +0200	[thread overview]
Message-ID: <CAO48Bk9iuC0E7G6EVrRe448pAn0OOuQ-av0P9g6pWyoFdNF_CQ@mail.gmail.com> (raw)
In-Reply-To: <04a0c0f2-a3b6-47f3-b4da-fed2dadd0ee2@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

Thank you for the clarification!
The FIXME was sort of misleading here. A double negation always is ;-)

Best, /PA

On Thu, 21 Sept 2023 at 10:47, Gerd Möllmann <gerd.moellmann@gmail.com>
wrote:

> On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> > Hi
> >
> > reading removed FIXME in the second hunk:
> >
> > # FIXME: Don't install the dump file into the app bundle when
> > # self-contained install is disabled.
> >
> > I understand that we should install if self-contained is enabled.
> >
> > However, I see
> >
> > +ifeq (${ns_self_contained},no)
> >
> > Shouldn't that read as
> >
> > +ifeq (${ns_self_contained},yes)
> >
> > I'm confused...
>
> I assume that is nextstep/Makefile.in.  We want to cp the .pdmp file
> only if we don't do a self-contained build (...=no).
>
>

-- 
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #2: Type: text/html, Size: 1763 bytes --]

  reply	other threads:[~2023-09-21  9:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21  6:29 Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Pedro Andres Aranda Gutierrez
2023-09-21  8:46 ` Gerd Möllmann
2023-09-21  9:59   ` Pedro Andres Aranda Gutierrez [this message]
2023-09-21 10:22     ` Gerd Möllmann
2023-09-21 16:50   ` Alan Third
2023-09-21 17:06     ` Gerd Möllmann
2023-09-21 17:29       ` Alan Third
2023-09-21 17:58         ` Gerd Möllmann
2023-09-21 18:46           ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO48Bk9iuC0E7G6EVrRe448pAn0OOuQ-av0P9g6pWyoFdNF_CQ@mail.gmail.com \
    --to=paaguti@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=gerd.moellmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).