From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pedro Andres Aranda Gutierrez Newsgroups: gmane.emacs.devel Subject: Re: Make all tree-sitter modes optional Date: Fri, 20 Jan 2023 17:31:44 +0100 Message-ID: References: <83a62dobfi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004f16d305f2b4971c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 20 17:33:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIuKP-0004oK-5I for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Jan 2023 17:33:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIuJk-0003dx-Cy; Fri, 20 Jan 2023 11:32:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIuJg-0003d9-Cz for emacs-devel@gnu.org; Fri, 20 Jan 2023 11:32:38 -0500 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIuJT-00042e-W6; Fri, 20 Jan 2023 11:32:26 -0500 Original-Received: by mail-ej1-x62c.google.com with SMTP id rl14so11987406ejb.2; Fri, 20 Jan 2023 08:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kWiq2ydoW7dYDsQUfI77k2DKTf0qGXMd+XD7kZK1jIw=; b=DZ4Qf5Eo8nwEXegHjAByzOkMsYjII+zoMOwJKA07NsxkzUV6Xic1h+BLgJ8VRDc5jO uRB7JtLI4QUvWtSlc7O7dyKl4DvLAQiHbbflreKoXaR0EI1zTU+lOaBP2T1lbvcu4GqS yf1QNOj9NxgAqFn1XayXzfFTpoWds6nAbEGXQfmy5RmBA1fIwajIQQx2/CNcrabbFKz8 bOvBK+uYkhltqydCvaNO8uheOs1z52QsYi1MDTl/XhDHajUdkC65LljL74lCXG7AqUU0 8nLMGCPtWK0aKjK4N2bpiWWA6eRcF7TqoGd5CSDWZFh4B7uVFlX/LFRwfGVeNzdG+AWm m3Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kWiq2ydoW7dYDsQUfI77k2DKTf0qGXMd+XD7kZK1jIw=; b=ZjgBgPWYkfRS/nMheLa1ZK736o2mbfOCI5+UmZ9a8HiNoBahMloR9Vp99nnHvPeBMh HUfHwfGv4cf4pOnn2EvALOf790Fi4LD3Y6vtovqFqsyitUeUbIT1tHDm/Bz5TgZQwWA/ 2mowF+AuTK2dFAE9xRrQDwzyD5Djvm+l7r527GXp9w1y3mAB+iLkd007KUHg/P5SqDsp t14faaIi0QhCRHzr9XT5z6o064qKlR3WhV5VTH8gyCYSngyet3adsyBBExR2kNn8M7w4 N9xaIuSjeIA07ZfB6vDl0RUfjtuzCnoXxX27q6wKNGZmhIzHW7JX2pXN+egXKLWyW/8u d7pA== X-Gm-Message-State: AFqh2kpuO4I7mMWwK+85RqdCiXHdy5HtusAUNEG5TikHVZ9u2j9rYQQN mNqfSKTsv9Ii9sA1zdER9vZ2Xu3z2q6mMn3pAs11PeRSnixPXg== X-Google-Smtp-Source: AMrXdXsN2oXOh2qlidmKNS567MRvXcxsc4TWeu4NSg70R55lGvFWq42eFm+BcllSmGmTzkZ06/vOYnpB1hi5safLiEs= X-Received: by 2002:a17:906:2f17:b0:871:72fb:ccd1 with SMTP id v23-20020a1709062f1700b0087172fbccd1mr1132305eji.156.1674232330129; Fri, 20 Jan 2023 08:32:10 -0800 (PST) In-Reply-To: <83a62dobfi.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=paaguti@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302579 Archived-At: --0000000000004f16d305f2b4971c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for that :-) It's a first step. However, the *-ts-mode.el files still go through the .el compilation, yielding error messages during the compilation. Additionally, they get installed in the binary distribution: emacs-29 =E2=9E=A4 find Emacs.app -name \*-ts-\* Emacs.app/Contents/Resources/lisp/progmodes/c-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/c-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/go-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/go-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/java-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/java-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/json-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/json-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/ruby-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/ruby-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/rust-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/rust-ts-mode.elc Emacs.app/Contents/Resources/lisp/progmodes/typescript-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/progmodes/typescript-ts-mode.elc Emacs.app/Contents/Resources/lisp/textmodes/toml-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/textmodes/toml-ts-mode.elc Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.el.gz Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.elc That may be a source of confusion ... Just my .02cents, /PA On Fri, 20 Jan 2023 at 09:30, Eli Zaretskii wrote: > > From: Pedro Andres Aranda Gutierrez > > Date: Thu, 19 Jan 2023 17:53:06 +0100 > > > > Now: My experience in the last couple of weeks is that there are > tree-sitter modes in the Emacs tree that > > have non-ts counterparts in MELPA only. And that's been frustrating. > Basically because I don't compile ts > > support and despite that, the treesit .el files are installed and used. > Example: dockerfile-mode is in MELPA > > only. So when I recently opened a Dockerfile, I got an error saying tha= t > Dockerfile-ts-mode couldn't start > > because my emacs hasn't ts support compiled in. > > > > I would have prefered to see the dockerfile opened in text mode with no > errors. And then, when I install the > > Dockerfile-mode package from MELPA, start working with all the goodies = I > got from installing the package > > from MELPA. > > > > My gut feeling is that if I don't have treesit support compiled in > Emacs, I don't want *-ts-*.el files in my elisp > > tree nor any side effects related to these files. Sorry to say, but I > feel that the enthusiasm about treesit some > > have is a bit pushing for me. And I feel uncomfortable when pushed. > > Please try the latest emacs-29 branch, where the tree-sitter based > modes have been made entirely optional. > --=20 Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet --0000000000004f16d305f2b4971c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for that :-)=C2=A0
It's a first step. Howev= er, the *-ts-mode.el files still go through the .el compilation, yielding e= rror messages during the compilation.=C2=A0
Additionally, they ge= t installed in the binary distribution:

emacs-29 = =E2=9E=A4 find Emacs.app -name \*-ts-\*
Emacs.app/Contents/Resources/lis= p/progmodes/c-ts-mode.el.gz
Emacs.app/Contents/Resources/lisp/progmodes/= c-ts-mode.elc
Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.= el.gz
Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.elc
E= macs.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.el.gz
Emac= s.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.elc
Emacs.app= /Contents/Resources/lisp/progmodes/go-ts-mode.el.gz
Emacs.app/Contents/R= esources/lisp/progmodes/go-ts-mode.elc
Emacs.app/Contents/Resources/lisp= /progmodes/java-ts-mode.el.gz
Emacs.app/Contents/Resources/lisp/progmode= s/java-ts-mode.elc
Emacs.app/Contents/Resources/lisp/progmodes/json-ts-m= ode.el.gz
Emacs.app/Contents/Resources/lisp/progmodes/json-ts-mode.elcEmacs.app/Contents/Resources/lisp/progmodes/ruby-ts-mode.el.gz
Emacs.a= pp/Contents/Resources/lisp/progmodes/ruby-ts-mode.elc
Emacs.app/Contents= /Resources/lisp/progmodes/rust-ts-mode.el.gz
Emacs.app/Contents/Resource= s/lisp/progmodes/rust-ts-mode.elc
Emacs.app/Contents/Resources/lisp/prog= modes/typescript-ts-mode.el.gz
Emacs.app/Contents/Resources/lisp/progmod= es/typescript-ts-mode.elc
Emacs.app/Contents/Resources/lisp/textmodes/to= ml-ts-mode.el.gz
Emacs.app/Contents/Resources/lisp/textmodes/toml-ts-mod= e.elc
Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.el.gz
= Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.elc
=
That may be a source of confusion ...

Just my .02cents, /PA

On Fri, 20 Jan 2023 at 09:30, Eli Zaretskii &= lt;eliz@gnu.org> wrote:
> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Thu, 19 Jan 2023 17:53:06 +0100
>
> Now: My experience in the last couple of weeks is that there are tree-= sitter modes in the Emacs tree that
> have non-ts counterparts in MELPA only. And that's been frustratin= g. Basically because I don't compile ts
> support and despite that, the treesit .el files are installed and used= . Example: dockerfile-mode is in MELPA
> only. So when I recently opened a Dockerfile, I got an error saying th= at Dockerfile-ts-mode couldn't start
> because my emacs hasn't ts support compiled in.
>
> I would have prefered to see the dockerfile opened in text mode with n= o errors. And then, when I install the
> Dockerfile-mode package from MELPA, start working with all the goodies= I got from installing the package
> from MELPA.
>
> My gut feeling is that if I don't have treesit support compiled in= Emacs, I don't want *-ts-*.el files in my elisp
> tree nor any side effects related to these files. Sorry to say, but I = feel that the enthusiasm about treesit some
> have is a bit pushing for me. And I feel uncomfortable when pushed.
Please try the latest emacs-29 branch, where the tree-sitter based
modes have been made entirely optional.


--
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um = gestellt zu werden
Georg Kreisler

Headach= es with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.u= niter.operation we should run a leader-deposed hook here, but we can't = yet

--0000000000004f16d305f2b4971c--