unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Jim Porter <jporterbugs@gmail.com>,
	Ulrich Mueller <ulm@gentoo.org>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: emacsclient startup messages
Date: Fri, 5 Nov 2021 08:04:28 +0100	[thread overview]
Message-ID: <CAO48Bk8kT9GMWTyYBgNAYgiac7Ms6=Zb5HQGH43NscuHawYK2A@mail.gmail.com> (raw)
In-Reply-To: <CAO48Bk9m-fWi=6-VhcC-LGYiD0WZjc-+VSaP+nKYHnc1uy8fAw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2433 bytes --]

Hi Eli,

I have been applying the patch to my Ubuntu 20.04 builds for a couple of
days and everything as worked well. Wouldn't it be a good time to put it
into emacs-28?

Just asking, /PA

On Sun, 31 Oct 2021 at 16:44, Pedro Andres Aranda Gutierrez <
paaguti@gmail.com> wrote:

> Hi again,
> it took a bit longer, but here we are... The patch does what I was
> dreaming of (i.e. getting rid of the xdg message when calling emacsclient
> with -a or when $ALTERNATE_EDITOR is set.
>
> Thanks!
> /PA
>
> On Sun, 31 Oct 2021 at 11:03, Pedro Andres Aranda Gutierrez <
> paaguti@gmail.com> wrote:
>
>> HI Jim,
>> I've patched my emacs-28 source and am compiling the whole beat right now.
>> Once installed, I'll let you know :-)
>> /PA
>>
>> On Sat, 30 Oct 2021 at 21:47, Jim Porter <jporterbugs@gmail.com> wrote:
>>
>>> On 10/30/2021 12:16 PM, Jim Porter wrote:
>>> > On 10/30/2021 10:39 AM, Ulrich Mueller wrote:
>>> >> There can be situations where there is an XDG environment for the
>>> client
>>> >> but not for the daemon.
>>> >
>>> > Right, the patch in bug#33847 should handle that case correctly, but
>>> I'm
>>> > pretty sure the current implementation opens users who spawn the Emacs
>>> > daemon on-demand to symlink attacks. That's due to the code needing to
>>> > check both XDG_RUNTIME_DIR and TMPDIR before being sure there's no
>>> > daemon to connect to.
>>> >
>>> > I can think of two ways to avoid this issue:
>>> [snip]
>>> > 2) If XDG_RUNTIME_DIR and ALTERNATE_EDITOR/--alternate-editor are both
>>> > set, never check TMPDIR. This should let both cases work without
>>> > requiring users to explicitly set a flag anywhere, but it the lack of
>>> > explicitness could be more confusing. I think this should work fine in
>>> > all cases, since users running `emacs --daemon' without XDG probably
>>> > won't be using ALTERNATE_EDITOR (the daemon should always be running,
>>> so
>>> > there's no need for an alternate editor).
>>>
>>> I posted a patch for method (2) to bug#51327 here:
>>> <https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-10/msg02638.html
>>> >.
>>>
>>
>>
>> --
>> Fragen sind nicht da um beantwortet zu werden,
>> Fragen sind da um gestellt zu werden
>> Georg Kreisler
>>
>
>
> --
> Fragen sind nicht da um beantwortet zu werden,
> Fragen sind da um gestellt zu werden
> Georg Kreisler
>


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

[-- Attachment #2: Type: text/html, Size: 4032 bytes --]

  reply	other threads:[~2021-11-05  7:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  5:26 emacsclient startup messages Pedro Andres Aranda Gutierrez
2021-10-26 12:18 ` Eli Zaretskii
2021-10-26 16:43   ` Pedro Andres Aranda Gutierrez
2021-10-26 16:32 ` Jim Porter
2021-10-26 16:46   ` Pedro Andres Aranda Gutierrez
2021-10-26 17:03     ` Jim Porter
2021-10-27  5:05       ` Pedro Andres Aranda Gutierrez
2021-10-30 17:39   ` Ulrich Mueller
2021-10-30 19:16     ` Jim Porter
2021-10-30 19:47       ` Jim Porter
2021-10-31 10:03         ` Pedro Andres Aranda Gutierrez
2021-10-31 15:44           ` Pedro Andres Aranda Gutierrez
2021-11-05  7:04             ` Pedro Andres Aranda Gutierrez [this message]
2021-11-05  8:04               ` Eli Zaretskii
2021-11-05  9:40                 ` Ulrich Mueller
2021-11-05 16:35                   ` Jim Porter
2021-11-05 17:52                     ` Ulrich Mueller
2021-11-06 11:35                       ` Pedro Andres Aranda Gutierrez
2021-11-06 18:40                         ` Jim Porter
2021-11-07  9:49                       ` Peter Oliver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO48Bk8kT9GMWTyYBgNAYgiac7Ms6=Zb5HQGH43NscuHawYK2A@mail.gmail.com' \
    --to=paaguti@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).