From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pedro Andres Aranda Gutierrez Newsgroups: gmane.emacs.devel Subject: Re: Make all tree-sitter modes optional Date: Sat, 21 Jan 2023 12:30:26 +0100 Message-ID: References: <83a62dobfi.fsf@gnu.org> <83o7qtm33d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ade8bf05f2c47f03" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="652"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 21 12:31:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJC5x-000AXL-I1 for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Jan 2023 12:31:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJC5N-0002U0-9X; Sat, 21 Jan 2023 06:31:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJC5K-0002Td-AM for emacs-devel@gnu.org; Sat, 21 Jan 2023 06:30:58 -0500 Original-Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJC5H-0003tM-W5; Sat, 21 Jan 2023 06:30:58 -0500 Original-Received: by mail-ed1-x52d.google.com with SMTP id v30so9513514edb.9; Sat, 21 Jan 2023 03:30:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=owmWb/v+ALAz/qIOCXxC5rta3jLIs0rIM14BuhEJliI=; b=Lzz1p03qPSvl6+HW0ruOFYtnOvWuaA+BHVxftqmO2el8yxHvxl/BvxP8BAUN4u56LV IXscwSv7YeREQHBe8AjhJ0VPi9uihJ5coaBTIjJsbwjxNDqQoVT+QfGzE4SatOG+QF7w ZEio0sCf0A55XbfNF/eAiCbHrbprdaxBZ4Rxlri/WaYdDJYC8Xluw7CbtbWnrD1GvfmI Ypu/7RtbIxlRMXFudRt5jPX3DwqDXiMgww3WMYfj1RoL2QXYg6shWKNYO26BGhPGESdz QNzZaJD7ovHVShWqfYn7hVlS4XskNi6IWO/HZCookgN7sSoRCuqwog4yMcvUHN4P9cKK 4Wdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=owmWb/v+ALAz/qIOCXxC5rta3jLIs0rIM14BuhEJliI=; b=zWvkr6To53cArNwF6yPuBBns/pd2TZk5hhtBMSmxov7vZKf6vhoJbqOvKVNYeqd+2I 41GVrY5i+gpBK1Vfpcb8AYB4zWoD50dMst8eQoY8JHhUbs7cBwk8cO2e2FrMpV41O48u YXpGVyr8o9sjy1b7ITs/Rpa8ENrAsKiap0HJd+agNW72KNrwx4DQ8p6ySHtL73hzW9yN 3o2MSZhos55c6JyOkX6DtSbWFfvMgv1WsMmtMx/k+8Am1F5O7EKCOXwTB/RENA8XbBLf br8Rs1ZYm8fON07zBNOj6uwQdPhz+calc/bweBU8AQcMtYAcXRJU7GoZs3fpoX7byT+8 /agw== X-Gm-Message-State: AFqh2kpZJjKqPU7oEop7qGxuTv5hvUslEMGeQ39zRFINtrfa+rbZSE92 XLCmZUQgF33yF1PLpvZO6NNXn5CtZANL91dhCwI/tMng8ShUkw== X-Google-Smtp-Source: AMrXdXum7fzpSeW5hIL+iQTWeL0V9ej4o///7Ir5xL/fhs9BfTyYpTJePhlSZi2cqBH5/JeuznrGAP0Ww6vT3BrWii4= X-Received: by 2002:aa7:c58b:0:b0:49d:7b0:9cd with SMTP id g11-20020aa7c58b000000b0049d07b009cdmr2044116edq.162.1674300653167; Sat, 21 Jan 2023 03:30:53 -0800 (PST) In-Reply-To: <83o7qtm33d.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=paaguti@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302590 Archived-At: --000000000000ade8bf05f2c47f03 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Eli, Eli writes: > Why would it confuse? You also have there stuff like w32-win.el.gz, > which is used only on MS-Windows, and other files that are not > necessarily for your configuration. This is not a problem, and > shouldn't be one. I don't know, maybe for me there is a difference between the OS specific stuff, tree-sitter and other stuff in Emacs: tree-sitter modes 'compete' with 'regular' modes and if I don't have tree-sitter activated at compile time, it can be misleading to see those files there and 'sub-optimal' (to say the least) to get a message that you can't use them. OS related stuff is different in the sense that, well, if I'm on a Linux system and try to use (you say the OS)-specific features, it is natural that I get a 'wake-up' message there and stop trying to do things that make no sense. As for the rest, having dormant features that _work_ (or are WIP with a level of maturity enough to be in master) and only wait for me to test them and activate them if they help me in my day-to-day interactions with Emacs, of course, put 10^n n->infinity of those in Emacs, no problem. In that sense, if there was a way to disregard *-ts-*.el files in ELC/ELN compilation and installation when I compile Emacs _without_ tree-sitter support, the whole picture would be (once again, IMvHO) much more coherent. Thanks for your patience, /PA On Fri, 20 Jan 2023 at 20:13, Eli Zaretskii wrote: > > From: Pedro Andres Aranda Gutierrez > > Date: Fri, 20 Jan 2023 17:31:44 +0100 > > Cc: emacs-devel@gnu.org > > > > Thanks for that :-) > > It's a first step. However, the *-ts-mode.el files still go through the > .el compilation, yielding error messages > > during the compilation. > > What error messages? Please show them, we cannot possibly guess what > messages do you see. > > And why is it a problem that the *.el files are being compiled as part > of the build? A build compiles all the *.el files, including ones you > will never use and ones that you cannot use (e.g., because they are > for Emacs running on other OSes). That is never a problem. > > > Additionally, they get installed in the binary distribution: > > > > emacs-29 =E2=9E=A4 find Emacs.app -name \*-ts-\* > > Emacs.app/Contents/Resources/lisp/progmodes/c-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/c-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/go-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/go-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/java-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/java-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/json-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/json-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/ruby-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/ruby-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/rust-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/rust-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/progmodes/typescript-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/progmodes/typescript-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/textmodes/toml-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/textmodes/toml-ts-mode.elc > > Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.el.gz > > Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.elc > > > > That may be a source of confusion ... > > Why would it confuse? You also have there stuff like w32-win.el.gz, > which is used only on MS-Windows, and other files that are not > necessarily for your configuration. This is not a problem, and > shouldn't be one. > --=20 Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet --000000000000ade8bf05f2c47f03 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Eli,

El= i writes:
> Why would it confuse?=C2=A0 You also have there st= uff like w32-win.el.gz,
> which is used only on MS-Windows, and other= files that are not
> necessarily for your configuration.=C2=A0 This = is not a problem, and
> shouldn't be one.

I don't know, maybe for me there is a difference between the OS s= pecific stuff, tree-sitter and other stuff in Emacs:

tree-sitter modes 'compete' with 'regular' modes and if = I don't have tree-sitter activated at compile time, it can be misleadin= g to see those files there and 'sub-optimal' (to say the least) to = get a message that you can't use them.
OS related stuff is di= fferent in the sense that, well, if I'm on a Linux system and try to us= e (you say the OS)-specific features, it is natural that I get a 'wake-= up' message there and stop trying to do things that make no sense.=C2= =A0
As for the rest, having dormant features that _work_ (or are = WIP with a level of maturity enough to be in master) and only wait for me t= o test them and activate them if they help me in my day-to-day interactions= with Emacs, of course, put 10^n n->infinity of those in Emacs, no probl= em.

In that sense, if there was a way to disregard= *-ts-*.el files in ELC/ELN compilation and installation when I compile Ema= cs _without_ tree-sitter support, the whole picture would be (once again, I= MvHO) much more coherent.

Thanks for your patience= , /PA

On Fri, 20 Jan 2023 at 20:13, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Pedro Andres Aranda Gutierrez = <paaguti@gmail.co= m>
> Date: Fri, 20 Jan 2023 17:31:44 +0100
> Cc: emacs-dev= el@gnu.org
>
> Thanks for that :-)
> It's a first step. However, the *-ts-mode.el files still go throug= h the .el compilation, yielding error messages
> during the compilation.

What error messages?=C2=A0 Please show them, we cannot possibly guess what<= br> messages do you see.

And why is it a problem that the *.el files are being compiled as part
of the build?=C2=A0 A build compiles all the *.el files, including ones you=
will never use and ones that you cannot use (e.g., because they are
for Emacs running on other OSes).=C2=A0 That is never a problem.

> Additionally, they get installed in the binary distribution:
>
> emacs-29 =E2=9E=A4 find Emacs.app -name \*-ts-\*
> Emacs.app/Contents/Resources/lisp/progmodes/c-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/progmodes/c-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/progmodes/cmake-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.el.gz > Emacs.app/Contents/Resources/lisp/progmodes/dockerfile-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/go-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/progmodes/go-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/java-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/progmodes/java-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/json-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/progmodes/json-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/ruby-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/progmodes/ruby-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/rust-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/progmodes/rust-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/progmodes/typescript-ts-mode.el.gz > Emacs.app/Contents/Resources/lisp/progmodes/typescript-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/textmodes/toml-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/textmodes/toml-ts-mode.elc
> Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.el.gz
> Emacs.app/Contents/Resources/lisp/textmodes/yaml-ts-mode.elc
>
> That may be a source of confusion ...

Why would it confuse?=C2=A0 You also have there stuff like w32-win.el.gz, which is used only on MS-Windows, and other files that are not
necessarily for your configuration.=C2=A0 This is not a problem, and
shouldn't be one.


--
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um = gestellt zu werden
Georg Kreisler

Headach= es with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.u= niter.operation we should run a leader-deposed hook here, but we can't = yet

--000000000000ade8bf05f2c47f03--