Checks failing abort make process

Checks failing abort make process

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

Hi,

I've not been able to build Emacs for the last couple of days. Well, I
build it, but the checks fail:

  lisp/autorevert-tests.log
make[3]: *** [Makefile:331: check-doit] Error 1
make[3]: Leaving directory '/home/student/emacs/test'
make[2]: *** [Makefile:300: check] Error 2
make[2]: Leaving directory '/home/student/emacs/test'
make[1]: *** [Makefile:953: check] Error 2
make[1]: Leaving directory '/home/student/emacs'
dh_auto_test: error: make -j1 check VERBOSE=1 returned exit code 2
make: *** [debian/rules:17: binary] Error 2

Just for what it may be worth.

Best, /PA
-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

[-- Attachment #2: Type: text/html, Size: 1132 bytes --]

Re: Checks failing abort make process

[Eli Zaretskii]

> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Thu, 17 Jun 2021 08:44:43 +0200
> 
>   lisp/autorevert-tests.log
> make[3]: *** [Makefile:331: check-doit] Error 1
> make[3]: Leaving directory '/home/student/emacs/test'
> make[2]: *** [Makefile:300: check] Error 2
> make[2]: Leaving directory '/home/student/emacs/test'
> make[1]: *** [Makefile:953: check] Error 2
> make[1]: Leaving directory '/home/student/emacs'
> dh_auto_test: error: make -j1 check VERBOSE=1 returned exit code 2
> make: *** [debian/rules:17: binary] Error 2

Please show the detailed report from ERT regarding the reason of the
failure (it should be in test/lisp/autorevert-tests.log).

Thanks.

Re: Checks failing abort make process

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]

Good point! This is what happens when you have too many open fronts ;-)
Anyhow, I've taken some time to dig into the problem and found the following

less test/lisp/shadowfile-tests.log
Running 8 tests (2021-06-18 08:33:34+0000, selector `(not (or (tag
:expensive-test) (tag :unstable)))')
   passed  1/8  shadow-test01-sites (0.743613 sec)
   passed  2/8  shadow-test02-files (0.007628 sec)
   passed  3/8  shadow-test03-expand-cluster-in-file-name (0.023701 sec)
   passed  4/8  shadow-test04-contract-file-name (0.007431 sec)
   passed  5/8  shadow-test05-file-match (0.023161 sec)
   passed  6/8  shadow-test06-literal-groups (0.029197 sec)
   passed  7/8  shadow-test07-regexp-groups (0.007492 sec)
Autosave file on local temporary directory, do you want to continue? (yes
or no)
test/lisp/shadowfile-tests.log (END)

I went and said 'yes' on the terminal where I was running make and the
build process ended.

This happens on commit bc44763b8342ee9e1bf43ffb202c73fee5ba0bf6

Best, /PA

On Thu, 17 Jun 2021 at 09:52, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> > Date: Thu, 17 Jun 2021 08:44:43 +0200
> >
> >   lisp/autorevert-tests.log
> > make[3]: *** [Makefile:331: check-doit] Error 1
> > make[3]: Leaving directory '/home/student/emacs/test'
> > make[2]: *** [Makefile:300: check] Error 2
> > make[2]: Leaving directory '/home/student/emacs/test'
> > make[1]: *** [Makefile:953: check] Error 2
> > make[1]: Leaving directory '/home/student/emacs'
> > dh_auto_test: error: make -j1 check VERBOSE=1 returned exit code 2
> > make: *** [debian/rules:17: binary] Error 2
>
> Please show the detailed report from ERT regarding the reason of the
> failure (it should be in test/lisp/autorevert-tests.log).
>
> Thanks.
>


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

[-- Attachment #2: Type: text/html, Size: 3121 bytes --]

Re: Checks failing abort make process

[Eli Zaretskii]

> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Fri, 18 Jun 2021 11:09:02 +0200
> Cc: emacs-devel@gnu.org
> 
> Good point! This is what happens when you have too many open fronts ;-) Anyhow, I've taken some time to
> dig into the problem and found the following
> 
> less test/lisp/shadowfile-tests.log
> Running 8 tests (2021-06-18 08:33:34+0000, selector `(not (or (tag :expensive-test) (tag :unstable)))')
>    passed  1/8  shadow-test01-sites (0.743613 sec)
>    passed  2/8  shadow-test02-files (0.007628 sec)
>    passed  3/8  shadow-test03-expand-cluster-in-file-name (0.023701 sec)
>    passed  4/8  shadow-test04-contract-file-name (0.007431 sec)
>    passed  5/8  shadow-test05-file-match (0.023161 sec)
>    passed  6/8  shadow-test06-literal-groups (0.029197 sec)
>    passed  7/8  shadow-test07-regexp-groups (0.007492 sec)
> Autosave file on local temporary directory, do you want to continue? (yes or no) 
> test/lisp/shadowfile-tests.log (END)
> 
> I went and said 'yes' on the terminal where I was running make and the build process ended.
> 
> This happens on commit bc44763b8342ee9e1bf43ffb202c73fee5ba0bf6

Sorry, I don't follow: what does the above have to do with the failure
of autorevert-tests?

Re: Checks failing abort make process

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1: Type: text/plain, Size: 2237 bytes --]

Right, maybe I was overexcited to find out what was *really* happening. So
the process:

1.- I start my make and everything goes smoothly until the message with the
autorevert-tests appears and stays there for some time
2.- At this point I open a second terminal and use 'ps -ef' to see what is
really happen.
3.- There I see that make is stuck in the shadowfile-tests
4.- I examine the log file and disconver that it is waiting on the message
"Autosave file on local temporary directory, do you want to continue? (yes
or no"
5.- I go back to the terminal where make is running and type 'yes<Enter>'
and the make process finishes correctly.

From this I fear that the shadowfile-tests need some interaction which is
not compatible with an automated make process

Best, /PA

On Fri, 18 Jun 2021 at 13:00, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> > Date: Fri, 18 Jun 2021 11:09:02 +0200
> > Cc: emacs-devel@gnu.org
> >
> > Good point! This is what happens when you have too many open fronts ;-)
> Anyhow, I've taken some time to
> > dig into the problem and found the following
> >
> > less test/lisp/shadowfile-tests.log
> > Running 8 tests (2021-06-18 08:33:34+0000, selector `(not (or (tag
> :expensive-test) (tag :unstable)))')
> >    passed  1/8  shadow-test01-sites (0.743613 sec)
> >    passed  2/8  shadow-test02-files (0.007628 sec)
> >    passed  3/8  shadow-test03-expand-cluster-in-file-name (0.023701 sec)
> >    passed  4/8  shadow-test04-contract-file-name (0.007431 sec)
> >    passed  5/8  shadow-test05-file-match (0.023161 sec)
> >    passed  6/8  shadow-test06-literal-groups (0.029197 sec)
> >    passed  7/8  shadow-test07-regexp-groups (0.007492 sec)
> > Autosave file on local temporary directory, do you want to continue?
> (yes or no)
> > test/lisp/shadowfile-tests.log (END)
> >
> > I went and said 'yes' on the terminal where I was running make and the
> build process ended.
> >
> > This happens on commit bc44763b8342ee9e1bf43ffb202c73fee5ba0bf6
>
> Sorry, I don't follow: what does the above have to do with the failure
> of autorevert-tests?
>


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

[-- Attachment #2: Type: text/html, Size: 3315 bytes --]

Re: Checks failing abort make process

[Eli Zaretskii]

> From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
> Date: Sat, 19 Jun 2021 08:22:32 +0200
> Cc: emacs-devel@gnu.org
> 
> 1.- I start my make and everything goes smoothly until the message with the autorevert-tests appears and
> stays there for some time
> 2.- At this point I open a second terminal and use 'ps -ef' to see what is really happen.
> 3.- There I see that make is stuck in the shadowfile-tests
> 4.- I examine the log file and disconver that it is waiting on the message
> "Autosave file on local temporary directory, do you want to continue? (yes or no"
> 5.- I go back to the terminal where make is running and type 'yes<Enter>' and the make process finishes
> correctly.
> 
> From this I fear that the shadowfile-tests need some interaction which is not compatible with an automated
> make process

Can you establish from the log file which test, specifically, in
shadowfile-tests.el triggers this prompt?

Re: Checks failing abort make process

[Eli Zaretskii]

> Date: Sat, 19 Jun 2021 10:05:52 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > From this I fear that the shadowfile-tests need some interaction which is not compatible with an automated
> > make process
> 
> Can you establish from the log file which test, specifically, in
> shadowfile-tests.el triggers this prompt?

Actually, I think I know the answer: it's shadow-test08-shadow-todo.

Does the problem happen if you go to the 'test' subdirectory and type
this command at the shell's prompt:

  $ make lisp/shadowfile-tests

Re: Checks failing abort make process

[Michael Albinus]

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

Hi Pedro,

> Autosave file on local temporary directory, do you want to continue?
> (yes or no)
> test/lisp/shadowfile-tests.log (END)
>
> I went and said 'yes' on the terminal where I was running make and the
> build process ended.

I suppose your local uid is 0, isn't it?

The confirmation message is a result of a recent change in Tramp, see
etc/NEWS:

--8<---------------cut here---------------start------------->8---
*** Writing sensitive auto-save or backup files to the local temporary
directory must be confirmed.  In order to suppress this confirmation,
set user option 'tramp-allow-unsafe-temporary-files' to t.
--8<---------------cut here---------------end--------------->8---

I've pushed a fix to master, which sets tramp-allow-unsafe-temporary-files
to t in filenotify-tests.el and shadowfile-tests.el to t in the
noninteractive case. This should fix the problem.

> Best, /PA

Best regards, Michael.

Re: Checks failing abort make process

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

Hi Michael

Well, I'm building .deb packages using fakeroot, so it seems to be the case
;-)
Anyhow, I can confirm that I've been able to build without stops after your
fix

Best, /PA


On Sat, 19 Jun 2021 at 10:41, Michael Albinus <michael.albinus@gmx.de>
wrote:

> Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
>
> Hi Pedro,
>
> > Autosave file on local temporary directory, do you want to continue?
> > (yes or no)
> > test/lisp/shadowfile-tests.log (END)
> >
> > I went and said 'yes' on the terminal where I was running make and the
> > build process ended.
>
> I suppose your local uid is 0, isn't it?
>
> The confirmation message is a result of a recent change in Tramp, see
> etc/NEWS:
>
> --8<---------------cut here---------------start------------->8---
> *** Writing sensitive auto-save or backup files to the local temporary
> directory must be confirmed.  In order to suppress this confirmation,
> set user option 'tramp-allow-unsafe-temporary-files' to t.
> --8<---------------cut here---------------end--------------->8---
>
> I've pushed a fix to master, which sets tramp-allow-unsafe-temporary-files
> to t in filenotify-tests.el and shadowfile-tests.el to t in the
> noninteractive case. This should fix the problem.
>
> > Best, /PA
>
> Best regards, Michael.
>


-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

[-- Attachment #2: Type: text/html, Size: 2127 bytes --]