unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Liang Wang <netcasper@gmail.com>
To: emacs-devel@gnu.org
Subject: fix bad link for explicit tags in *Tags List* buffer
Date: Wed, 28 Sep 2011 20:23:53 +0800	[thread overview]
Message-ID: <CAO+NnCbvsx+avat8FkJ2mhMXmXD98sXLW6QzAsg413HV2C85FQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

Hi,

I use Emacs source tree as example.  Here is the way I create TAGS file.

$ etags src/*.[hc]

And then run M-x list-tags RET src/buffer.c RET to show buffer *Tags List*.
The first tag in it is current_buffer.  But when I press RET on it,
an error message shows up.  It's like

etags-goto-tag-location: Rerun etags: `^current_buffer' not found
in /home/liang/src/emacs/trunk/src/buffer.c

That's because etags-goto-tag-location wants implicit tag which starts from
 the beginning of the line, but current_buffer is an explicit tag.

To fix it, implicit tag must be used as link, but we can choose either
explicit tag
or implicit tag to show in *Tags List* buffer.

The following patch shows implicit tag.  OK for trunk?

Thanks,
Liang.


diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a8be1ba..032dbfd 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2011-09-28  Liang Wang  <netcasper@gmail.com>
+
+	* progmodes/etags.el (etags-list-tags): Always use explicit tags.
+
 2011-09-21  Michael Albinus  <michael.albinus@gmx.de>

 	* net/tramp.el (tramp-handle-shell-command): Set process sentinel
diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
index d321e9c..f38af05 100644
--- a/lisp/progmodes/etags.el
+++ b/lisp/progmodes/etags.el
@@ -1409,7 +1409,7 @@ hits the start of file."
 	  tag tag-info pt)
     (forward-line 1)
     (while (not (or (eobp) (looking-at "\f")))
-      (setq tag-info (save-excursion (funcall snarf-tag-function t))
+      (setq tag-info (save-excursion (funcall snarf-tag-function nil))
 	    tag (car tag-info)
 	    pt (with-current-buffer standard-output (point)))
       (princ tag)

[-- Attachment #2: etags-list-tags.patch --]
[-- Type: application/octet-stream, Size: 910 bytes --]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a8be1ba..032dbfd 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2011-09-28  Liang Wang  <netcasper@gmail.com>
+
+	* progmodes/etags.el (etags-list-tags): Always use explicit tags.
+
 2011-09-21  Michael Albinus  <michael.albinus@gmx.de>
 
 	* net/tramp.el (tramp-handle-shell-command): Set process sentinel
diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
index d321e9c..f38af05 100644
--- a/lisp/progmodes/etags.el
+++ b/lisp/progmodes/etags.el
@@ -1409,7 +1409,7 @@ hits the start of file."
 	  tag tag-info pt)
     (forward-line 1)
     (while (not (or (eobp) (looking-at "\f")))
-      (setq tag-info (save-excursion (funcall snarf-tag-function t))
+      (setq tag-info (save-excursion (funcall snarf-tag-function nil))
 	    tag (car tag-info)
 	    pt (with-current-buffer standard-output (point)))
       (princ tag)

             reply	other threads:[~2011-09-28 12:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 12:23 Liang Wang [this message]
2012-03-22  6:49 ` fix bad link for explicit tags in *Tags List* buffer Liang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO+NnCbvsx+avat8FkJ2mhMXmXD98sXLW6QzAsg413HV2C85FQ@mail.gmail.com \
    --to=netcasper@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).