From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Liang Wang Newsgroups: gmane.emacs.devel Subject: Re: fix bad link for explicit tags in *Tags List* buffer Date: Thu, 22 Mar 2012 14:49:24 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1332398976 17991 80.91.229.3 (22 Mar 2012 06:49:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2012 06:49:36 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 22 07:49:34 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SAbq1-00034K-Oq for ged-emacs-devel@m.gmane.org; Thu, 22 Mar 2012 07:49:33 +0100 Original-Received: from localhost ([::1]:39096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAbq1-0002At-7q for ged-emacs-devel@m.gmane.org; Thu, 22 Mar 2012 02:49:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAbpx-0002AP-VW for emacs-devel@gnu.org; Thu, 22 Mar 2012 02:49:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAbpv-0006P8-Ux for emacs-devel@gnu.org; Thu, 22 Mar 2012 02:49:29 -0400 Original-Received: from mail-wi0-f169.google.com ([209.85.212.169]:61970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAbpv-0006O6-LP for emacs-devel@gnu.org; Thu, 22 Mar 2012 02:49:27 -0400 Original-Received: by wibhm17 with SMTP id hm17so295991wib.0 for ; Wed, 21 Mar 2012 23:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=hsdMyJ0hWpAKzfO22vBnchy3rHFczLsR3vE2cZFx+Pg=; b=KfPbBZwBak4W1/wLUAUfOAsYpMl9eF5ppv+7bwMyFI2ZBPGysLrNpvBc+pLOuVEb8z AKosS6Af+lfzzyYR5DYv2NiW9rHs5sd5gnMzxVV9LCwZ0z/OuFayur23GSzbYipv9YeN 4YWY6rmPMOGsFGU+rHJQ4TIKoBR0iQ/n7aYxTFdee+M9KbA82bzfWvNQjEpwNCSxkfEe 8el2SzD0BMLaGgBzJ0lT9NSPJpZ/ZtMjcyleVPE4AGoCuQpI5FHbO1W7RuXKrSOkLGkY DgGcYMYIwcZ2mQm4G0Bnxn+1AZeKQOUJsb6tjMbMqWEDrt1ETPDMcX33HrnurDyTK95m PeaQ== Original-Received: by 10.180.76.74 with SMTP id i10mr2287432wiw.2.1332398964823; Wed, 21 Mar 2012 23:49:24 -0700 (PDT) Original-Received: by 10.223.155.193 with HTTP; Wed, 21 Mar 2012 23:49:24 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:149162 Archived-At: Hi, Could this patch be in Emacs 24? I reported it at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9942. Thanks. Liang. On Wed, Sep 28, 2011 at 8:23 PM, Liang Wang wrote: > Hi, > > I use Emacs source tree as example. =C2=A0Here is the way I create TAGS f= ile. > > $ etags src/*.[hc] > > And then run M-x list-tags RET src/buffer.c RET to show buffer *Tags List= *. > The first tag in it is current_buffer. =C2=A0But when I press RET on it, > an error message shows up. =C2=A0It's like > > etags-goto-tag-location: Rerun etags: `^current_buffer' not found > in /home/liang/src/emacs/trunk/src/buffer.c > > That's because etags-goto-tag-location wants implicit tag which starts fr= om > =C2=A0the beginning of the line, but current_buffer is an explicit tag. > > To fix it, implicit tag must be used as link, but we can choose either > explicit tag > or implicit tag to show in *Tags List* buffer. > > The following patch shows implicit tag. =C2=A0OK for trunk? > > Thanks, > Liang. > > > diff --git a/lisp/ChangeLog b/lisp/ChangeLog > index a8be1ba..032dbfd 100644 > --- a/lisp/ChangeLog > +++ b/lisp/ChangeLog > @@ -1,3 +1,7 @@ > +2011-09-28 =C2=A0Liang Wang =C2=A0 > + > + =C2=A0 =C2=A0 =C2=A0 * progmodes/etags.el (etags-list-tags): Always use= explicit tags. > + > =C2=A02011-09-21 =C2=A0Michael Albinus =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* net/tramp.el (tramp-handle-shell-command): S= et process sentinel > diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el > index d321e9c..f38af05 100644 > --- a/lisp/progmodes/etags.el > +++ b/lisp/progmodes/etags.el > @@ -1409,7 +1409,7 @@ hits the start of file." > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tag tag-info pt) > =C2=A0 =C2=A0 (forward-line 1) > =C2=A0 =C2=A0 (while (not (or (eobp) (looking-at "\f"))) > - =C2=A0 =C2=A0 =C2=A0(setq tag-info (save-excursion (funcall snarf-tag-f= unction t)) > + =C2=A0 =C2=A0 =C2=A0(setq tag-info (save-excursion (funcall snarf-tag-f= unction nil)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tag (car tag-info) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pt (with-current-buffer standard= -output (point))) > =C2=A0 =C2=A0 =C2=A0 (princ tag)