unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jürgen Hötzel" <juergen@archlinux.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: johnw <johnw@newartisans.com>, emacs-devel@gnu.org
Subject: Re: make eshell-path-env buffer-local
Date: Tue, 8 Jan 2013 18:19:57 +0100	[thread overview]
Message-ID: <CANmXxHMf5zAXD7EZ0CO1ePJtMaVhYYO1BqMF+X7Px_fQ0T_7=w@mail.gmail.com> (raw)
In-Reply-To: <87boczg150.fsf@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi Michael,

On Tue, Jan 8, 2013 at 4:11 PM, Michael Albinus <michael.albinus@gmx.de> wrote:
> Jürgen Hötzel <juergen@archlinux.org> writes:
>
>> Hi Michael,
>
> Hi Juergen,
>
>>> Wouldn't it be more consistent to declare `eshell-path-env' buffer-local
>>> in esh-util.el?
> Yes, but the eshell buffer's default-directory can switch between local
> and remote randomly:
>
> cd /
> cd /adb::

Good point!

Regards, Jürgen

[-- Attachment #2: 0001-Make-eshell-path-env-become-buffer-local.patch --]
[-- Type: application/octet-stream, Size: 774 bytes --]

From ef191eefa6fbc3e16870c59e1d4ec1b491748698 Mon Sep 17 00:00:00 2001
From: Juergen Hoetzel <juergen@archlinux.org>
Date: Tue, 8 Jan 2013 18:13:38 +0100
Subject: [PATCH] Make `eshell-path-env' become buffer-local

---
 lisp/eshell/esh-util.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/eshell/esh-util.el b/lisp/eshell/esh-util.el
index 2f49a21..f9b8621 100644
--- a/lisp/eshell/esh-util.el
+++ b/lisp/eshell/esh-util.el
@@ -229,6 +229,7 @@ If N or M is nil, it means the end of the list."
   "Content of $PATH.
 It might be different from \(getenv \"PATH\"\), when
 `default-directory' points to a remote host.")
+(make-variable-buffer-local 'eshell-path-env)
 
 (defun eshell-parse-colon-path (path-env)
   "Split string with `parse-colon-path'.
-- 
1.8.1


  reply	other threads:[~2013-01-08 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 14:07 make eshell-path-env buffer-local Jürgen Hötzel
2013-01-08 14:25 ` Michael Albinus
2013-01-08 14:53   ` Jürgen Hötzel
2013-01-08 15:11     ` Michael Albinus
2013-01-08 17:19       ` Jürgen Hötzel [this message]
2013-01-17 10:05         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANmXxHMf5zAXD7EZ0CO1ePJtMaVhYYO1BqMF+X7Px_fQ0T_7=w@mail.gmail.com' \
    --to=juergen@archlinux.org \
    --cc=emacs-devel@gnu.org \
    --cc=johnw@newartisans.com \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).