From: Jim Porter <jporterbugs@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix M-x gdb when debugging over Tramp
Date: Wed, 14 Apr 2021 22:02:07 -0700 [thread overview]
Message-ID: <CANh=_JHC7THK8Rct42s8QGewPTnP9BARvFn0XvgRd_yOmFB3gA@mail.gmail.com> (raw)
In-Reply-To: <87y2dtaq6q.fsf@gmx.de>
On Thu, Apr 8, 2021 at 5:58 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Jim Porter <jporterbugs@gmail.com> writes:
>
> Hi Jim,
>
> > Here's a pair of patches (one against the latest git revision, and one
> > against the emacs-27 branch) to fix debugging via M-x gdb over Tramp.
> > There were two problems:
> >
> > 1) In `gdb-jsonify-buffer', when replacing the "fullname" with a Tramp
> > path, the wildcard was greedy, resulting in only one "fullname" being
> > replaced. This had the effect of rendering it impossible to have more
> > than one breakpoint, as all but the first breakpoint would have
> > unmodified "fullname"s. This fix isn't needed for Emacs 28, since
> > `gdb-jsonify-buffer' was replaced with a more-accurate parser for
> > GDB/MI.
> >
> > 2) In `gdb-frame-handler', `gdb-selected-file' needs to be the *local*
> > file path, since that's what `gud-last-frame' expects. Without this,
> > the overlay arrow for the current line in the source buffer won't
> > show.
>
> From my POV these patches look OK, but I'm a very occasional gdb
> user. It would be great if somebody else could verify.
Thanks for taking a look. Of course, if anyone with more experience
using M-x gdb could take a look, that would be helpful too.
> I have also the impression that this is related to bug#39408, bug#28392
> and bug#44151. Perhaps this could be checked, and in case of yes, I
> would much appreciate if we could solve all of these bugs.
Indeed, it looks like bug#39408 is my issue (1) above, and bug#28392
is my issue (2). bug#44151 looks like it's done(ish): the first part
is something you've already fixed in Tramp, and the second part
(mentioned in comment 11) is a duplicate of bug#28392.
Given that these are already tracked as bugs, should I just submit
patches to both bug#39408 and bug#28392? I'd have to rearrange my
existing patches slightly, but that's easy.
- Jim
next prev parent reply other threads:[~2021-04-15 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 23:14 [PATCH] Fix M-x gdb when debugging over Tramp Jim Porter
2021-04-08 12:58 ` Michael Albinus
2021-04-15 5:02 ` Jim Porter [this message]
2021-04-15 7:55 ` Michael Albinus
2021-04-16 5:03 ` Jim Porter
2021-05-01 4:13 ` Jim Porter
2021-05-01 10:18 ` Michael Albinus
2021-04-19 11:55 ` William Xu
2021-04-19 12:44 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANh=_JHC7THK8Rct42s8QGewPTnP9BARvFn0XvgRd_yOmFB3gA@mail.gmail.com' \
--to=jporterbugs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).