From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: Increase default `line-spacing' to 0.05, 0.10 or 0.15 [proposal] Date: Thu, 6 May 2021 16:17:17 -0700 Message-ID: References: <871ramlbpy.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19566"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 07 01:18:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lenGE-0004y9-Ih for ged-emacs-devel@m.gmane-mx.org; Fri, 07 May 2021 01:18:26 +0200 Original-Received: from localhost ([::1]:42488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lenGD-000400-61 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 19:18:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lenFL-0003Yr-FR for emacs-devel@gnu.org; Thu, 06 May 2021 19:17:31 -0400 Original-Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:44640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lenFJ-0001hA-OV for emacs-devel@gnu.org; Thu, 06 May 2021 19:17:31 -0400 Original-Received: by mail-pg1-x52b.google.com with SMTP id y32so5804387pga.11 for ; Thu, 06 May 2021 16:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TeKw/4w13IOLLqYOUiYl++aTCFMvDiqpMd7gvC2LZdM=; b=C2XP608P70h7aKJCvA7N/gLIGARGHHFZMTmMNpPnBdmMI4WeBWSICQG7plb7xlGe/8 AFBWQj87rW6s2xpHfii/rx7Ri6hdBmvVc0Z2V4W4OoqONtXG3MpOOzLfIHVDBInR+9+u mVy2A3C3j9igrdta57TuUwbLvDkG555D75tBzxbYtfdHS6kjD1RiDLqhyMQ6qvDNuNP3 npWSrQtMRdSUNcOx7Hy0cQCteaVh+CBaejEGd50BXQRbAEgKILMf8g4ZVcLG5N60bjOH 0NMLYKQGoe1848WQO+cPEUuBfKSLN1cYc+JspLKZWddwXJT/CLNNrAzIptMQGgejBkb2 1s0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TeKw/4w13IOLLqYOUiYl++aTCFMvDiqpMd7gvC2LZdM=; b=VM4B/TLFo83T8DND3cEbvcZiiLEEhUHRG317CxYcNn8ImJmfASiyOLxT5d0rmzk5os zLO2nOKx7kiwlThzRf/f3dgIeUOsee5vgdsB6zXujjZcGtfujZwFGEmg9Io0iv5ouYcR KVwm38tih4czcvrJKIeHhqfm5lZbWr7uACZYuXsrlt3FD1/mwr6MbCL/u4Rj4Azk+7eV ZdRA9qjNiH3a2NCfo1YLtkk/XF0tb1tZfsZNQn4/w0VPWQ8w0sCmZCEhhPR9AAfQC6y9 Jsy792WjOnw5nSdocp6aLwMvl4OgSTUJLyE7P01m9WR0YJoTV3/EQmQ31C/K1wjh9h4U JDPQ== X-Gm-Message-State: AOAM533EtjE018G+v34zjAOIuEOI+Yk074Z/FDl8edecuqLczm+KFPqU x4rphsfVvQ94epm/c8xddrfARN6AHJt1LOibG7s= X-Google-Smtp-Source: ABdhPJzM0rrehLkGJH6dxMcy2j72B9P7Y/G9Q4D0r0y2nuOSaqvsHlSRQf//YT9oql+yS726CXCtuUq0ane8Yl0xHfM= X-Received: by 2002:a63:1903:: with SMTP id z3mr6675061pgl.185.1620343048371; Thu, 06 May 2021 16:17:28 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268992 Archived-At: On Thu, May 6, 2021 at 1:21 PM Stefan Kangas wrote= : > > Jim Porter writes: > > > On 5/4/2021 9:12 AM, =C3=93scar Fuentes wrote: > >> There are some negative consequences, though, like the "line" of > >> display-fill-column-indicator-mode losing any apparience of continuity= . > > Given how that mode is implemented, by setting > `display-fill-column-indicator' to ?\u2502, I don't see how it could be > improved without a complete redesign. It doesn't look like this was > implemented with `line-spacing' in mind. Yeah, Emacs' reliance on using characters to draw lines would probably lead me to set `line-spacing' back to 0 if this were changed. It would be interesting if Emacs were able to handle these issues, e.g. by adding some special handling when it sees box-drawing characters, but that would probably be a lot of work. > > I'm not sure if there's an easy way to ensure the fill line looks > > continuous in this case, but if that could be improved, it would help i= n > > a few other areas even if line-spacing weren't increased. For example, > > with `org-prettify-entities' set to t, subscripts add a bit to the line > > height, causing the fill line to appear discontinuous. Likewise, I > > believe overlines add a bit to the line height too. > > Do you have a recipe to reproduce this? Sure, here it is. This might depend on the font used, though: emacs -Q C-x C-f file.org RET x_subscript RET foo RET bar RET M-x display-fill-column-indicator-mode ;; The fill column line should be continuous for most fonts M-x org-toggle-pretty-entities ;; The fill column line should be discontinuous between lines 1 and 2 Even on fonts where the fill column indicator is always discontinuous (e.g. Deja Vu Sans Mono for me), `M-x org-toggle-pretty-entities' makes the gap larger. - Jim