unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [WIP PATCH] Adding more keybindings to rectangle-mark-mode-map
Date: Sat, 1 May 2021 15:31:08 -0700	[thread overview]
Message-ID: <CANh=_JEWqTzwWi1wjmDiRKZBZ9WVLyPY9etenztVCJSyOT2J0Q@mail.gmail.com> (raw)
In-Reply-To: <jwvmtte2x6m.fsf-monnier+emacs@gnu.org>

On Sat, May 1, 2021 at 10:20 AM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > Perhaps it makes sense to bind `C-k' in `rectangle-mark-mode'? It
> > seems to be similar to `C-o' and `C-t' in that there are non-rect
> > bindings that already do something different, but they aren't
> > particularly relevant in `rectangle-mark-mode'.
>
> I don't have an opinion on that.

I don't think I have a strong opinion either. I think my confusion
came about as someone who's migrated from using the rect commands in
`C-x r` to using `rectangle-mark-mode'. Someone who isn't already
familiar with the `C-x r' rect commands probably wouldn't expect `C-k'
to kill the current rect. I wouldn't mind writing a patch for this,
but if I'm the only one who got confused this way, a patch might not
be worthwhile.

> >> For `delete-rectangle` we already have `delete-region`
[snip]
> > Interesting, I didn't know that! I'd tried `M-x delete-region' (and
> > Edit -> Clear from the menu bar) and it deleted the whole,
> > non-rectangular region.
[snip]
> Oh, no, you're right: it's not done in `delete-region` (which is
> a fairly low-level function and hence not ideal to piggy-back such
> high-level UI functionality), but in `backward-delete-char-untabify`.
> Whether it kills or deletes (or just does the good old backspace)
> depends on `delete-active-region`.

Perhaps Edit -> Clear should be bound to `backward-delete-char-untabify'?

> There's an argument to be made for making `C-y` replace the region
> when active, as well, indeed.

That's certainly what I'd expect in general, though I hesitated to
suggest it as others may prefer the current behavior, and I'm not
totally confident I'd be able to write a patch that handles all the
corner cases correctly given how widely-used `C-y' is.

- Jim



  reply	other threads:[~2021-05-01 22:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-01  5:23 [WIP PATCH] Adding more keybindings to rectangle-mark-mode-map Jim Porter
2021-05-01 13:29 ` Stefan Monnier
2021-05-01 16:02   ` Jim Porter
2021-05-01 17:20     ` Stefan Monnier
2021-05-01 22:31       ` Jim Porter [this message]
2021-05-02  6:57         ` Eli Zaretskii
2021-05-02 15:48           ` Jim Porter
2021-05-02 16:09             ` Eli Zaretskii
2021-05-02 16:36               ` Jim Porter
2021-05-02 18:07                 ` Stefan Monnier
2021-05-03  4:06                   ` Jim Porter
2021-05-03  7:55                     ` Andreas Schwab
2021-05-03 15:26                       ` Jim Porter
2021-05-08  1:52                         ` Stefan Monnier
2021-05-08  7:15                           ` Eli Zaretskii
2021-05-08  6:55                         ` Andreas Schwab
2021-05-08 18:57                           ` [PATCH] Improve docstring for delete-active-region (was Re: [WIP PATCH] Adding more keybindings to rectangle-mark-mode-map) Jim Porter
2021-06-18  3:09                             ` Jim Porter
2021-06-19 12:27                               ` Lars Ingebrigtsen
2021-06-19 16:28                                 ` Jim Porter
2021-05-01 17:26     ` [WIP PATCH] Adding more keybindings to rectangle-mark-mode-map Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANh=_JEWqTzwWi1wjmDiRKZBZ9WVLyPY9etenztVCJSyOT2J0Q@mail.gmail.com' \
    --to=jporterbugs@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).