From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: call for more ert tests Date: Mon, 24 Jun 2013 20:24:50 +0200 Message-ID: References: <838v1zjrnl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e01419fd6f9020b04dfea8846 X-Trace: ger.gmane.org 1372098340 10742 80.91.229.3 (24 Jun 2013 18:25:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Jun 2013 18:25:40 +0000 (UTC) Cc: Emacs-Devel devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 20:25:38 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrBSH-0000lc-LE for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 20:25:33 +0200 Original-Received: from localhost ([::1]:47131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrBSH-0008DR-9E for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 14:25:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrBSD-0008CS-Ev for emacs-devel@gnu.org; Mon, 24 Jun 2013 14:25:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrBSB-0002Uy-MX for emacs-devel@gnu.org; Mon, 24 Jun 2013 14:25:29 -0400 Original-Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:45377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrBS5-0002T8-GR; Mon, 24 Jun 2013 14:25:21 -0400 Original-Received: by mail-wi0-f170.google.com with SMTP id ey16so29850wid.5 for ; Mon, 24 Jun 2013 11:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ypkZyksGhm/ji/qLos6Z23ey40Ed52eANdOtQMOsEMo=; b=U/OVdWLh7vJSzpQXK8BPiQze6DbCfoD7voMjZK4ML+NfouIMg0ae0f3pmUK1E/Wlvu 5Thf62vVBCiR5J8NoZP809Yo8LWRtpQ8/Qs/Hzoy6vHa7ct80oQU1apCsb1CozDuYoDm iY7a8gRAUOrlm7CySk8F2V5ZgYEUiYQMQVRWG6RIu4hAc3OzdBLTkPge53RFwKXMhXIt MHuHnd6l3VexN63bXJazx9Cv4jjLip9T9WBZyM5nWHhXH3m+DgTOpBsLr8EOXtCJ11SI bzOz7nX2UVFHxTMA6tpoBqNMNbfvnzRXG5yVY45fXEPZ8VmnihSgCgd90xdNNP5GQ0vm 4zGg== X-Received: by 10.194.237.38 with SMTP id uz6mr17531281wjc.73.1372098320202; Mon, 24 Jun 2013 11:25:20 -0700 (PDT) Original-Received: by 10.194.13.199 with HTTP; Mon, 24 Jun 2013 11:24:50 -0700 (PDT) In-Reply-To: <838v1zjrnl.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160965 Archived-At: --089e01419fd6f9020b04dfea8846 Content-Type: text/plain; charset=UTF-8 On Mon, Jun 24, 2013 at 8:21 PM, Eli Zaretskii wrote: > > From: Glenn Morris > > Date: Mon, 24 Jun 2013 13:31:50 -0400 > > > > One thing that could help reduce this is more unit tests. > > If you haven't used it, ERT makes it pretty easy to write tests. > > Of course, many aspects of Emacs's behaviour are not easy to test (GUI > > stuff, etc.), but many are. See test/automated/ for examples. [2] > > > > For example, package.el seems like something that should have a test > > suite. > > > > So if you fix a bug, please consider adding a unit test to make sure it > > does not come back. Or if you rewrite a lisp package, consider adding > > tests at the same time to check that obvious functionality still works. > > > > I know writing tests is maybe not as interesting as writing shiny new > > features, but I think it will save work in the long run. > > IMO, unless we require every new feature to come with a test and a > report that no regressions were found by running the existing tests, > we will never get any better testability than what we have now. > > Maybe writing tests for all bugs that shows up? --089e01419fd6f9020b04dfea8846 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Mon, Jun 24, 2013 at 8:21 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 24 Jun 2013 13:31:50 -0400
>
> One thing that could help reduce this is more unit tests.
> If you haven't used it, ERT makes it pretty easy to write tests. > Of course, many aspects of Emacs's behaviour are not easy to test = (GUI
> stuff, etc.), but many are. See test/automated/ for examples. [2]
>
> For example, package.el seems like something that should have a test > suite.
>
> So if you fix a bug, please consider adding a unit test to make sure i= t
> does not come back. Or if you rewrite a lisp package, consider adding<= br> > tests at the same time to check that obvious functionality still works= .
>
> I know writing tests is maybe not as interesting as writing shiny new<= br> > features, but I think it will save work in the long run.

IMO, unless we require every new feature to come with a test and a
report that no regressions were found by running the existing tests,
we will never get any better testability than what we have now.


Maybe writing tests= for all bugs that shows up?
--089e01419fd6f9020b04dfea8846--