unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tadeus Prastowo <tadeus.prastowo@unitn.it>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [pcomplete.el (pcomplete-completions-at-point)] Why max?
Date: Wed, 20 Mar 2019 18:17:14 +0100	[thread overview]
Message-ID: <CAN-HRFbzGaJvdk++uJfSPWHkUeBREA9TQ8Qd17A2cp5w+b1yTQ@mail.gmail.com> (raw)
In-Reply-To: <jwvva0do4ov.fsf-monnier+emacs@gnu.org>

On Wed, Mar 20, 2019 at 6:11 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > I confirm that commit 18fc4ac5294d85e37d9e544c04b5d4e89ef3237c solves
> > the problem.
> > Why the problem seems to be dependent on the number of characters and
> > their cases?
>
> It's because when we
>
>     (string-prefix-p s2 string completion-ignore-case)
>
> instead of
>
>     (string-prefix-p s2 res completion-ignore-case)
>
> we still get the correct result if `string` also happens to begin with
> `s2` (in your cases, `s2` is short, typically the same number of chars
> as the number of backslashes in your argument).

I see.  Thank you very much.

Lastly, do you mind closing the following bug report by saying that it
is fixed at commit 18fc4ac5294d85e37d9e544c04b5d4e89ef3237c, please?

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34888

Thanks in advance.

>         Stefan

--
Best regards,
Tadeus



  reply	other threads:[~2019-03-20 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 22:29 [pcomplete.el (pcomplete-completions-at-point)] Why max? Tadeus Prastowo
2019-03-19  9:55 ` Tadeus Prastowo
2019-03-19 16:37   ` Stefan Monnier
2019-03-19 16:40     ` Tadeus Prastowo
2019-03-20  2:09 ` Stefan Monnier
2019-03-20 11:00   ` Tadeus Prastowo
2019-03-20 14:00     ` Stefan Monnier
2019-03-20 16:14       ` Tadeus Prastowo
2019-03-20 17:11         ` Stefan Monnier
2019-03-20 17:17           ` Tadeus Prastowo [this message]
2019-03-20 23:38           ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN-HRFbzGaJvdk++uJfSPWHkUeBREA9TQ8Qd17A2cp5w+b1yTQ@mail.gmail.com \
    --to=tadeus.prastowo@unitn.it \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).